MantisBT - Zandronum
View Issue Details
0002861Zandronum[All Projects] Bugpublic2016-10-06 23:372020-04-20 19:53
unknownna 
Edward-san 
normalfeaturealways
needs testingreopened 
3.0 
 
0002861: smooth mouse movement option no longer toggles m_filter in 3.0
I recall that Torr told me that smooth_mouse does nothing in Skulltag/Zandronum, so we decided to have the menu option toggle m_filter instead since that's what ZDaemon did at the time. With the recent menu change, it naturally toggles smooth_mouse instead. So the question is whether we want it to toggle m_filter or do something else about it.
No tags attached.
related to 0002875resolved Leonard "smooth_mouse 1" potentially hard-coded into Zandronum's mouse behavior 
png menu.png (66,159) 2016-10-06 23:37
https://zandronum.com/tracker/file_download.php?file_id=1911&type=bug
png
Issue History
2016-10-06 23:37unknownnaNew Issue
2016-10-06 23:37unknownnaFile Added: menu.png
2016-10-07 09:21Edward-sanNote Added: 0015782
2016-10-07 09:21Edward-sanAssigned To => Edward-san
2016-10-07 09:21Edward-sanStatusnew => assigned
2016-10-07 09:41Edward-sanNote Edited: 0015782bug_revision_view_page.php?bugnote_id=15782#r9601
2016-10-07 09:41Edward-sanStatusassigned => needs review
2016-10-08 17:11Edward-sanNote Added: 0015809
2016-10-08 17:11Edward-sanStatusneeds review => needs testing
2016-10-09 17:56Torr SamahoTarget Version => 3.0
2016-10-09 19:32unknownnaNote Added: 0015859
2016-10-09 21:08unknownnaStatusneeds testing => resolved
2016-10-09 21:08unknownnaFixed in Version => 3.0
2016-10-09 21:08unknownnaResolutionopen => fixed
2016-10-09 21:56unknownnaNote Added: 0015866
2016-10-09 21:56unknownnaStatusresolved => feedback
2016-10-09 21:56unknownnaResolutionfixed => reopened
2016-10-09 22:02unknownnaNote Edited: 0015866bug_revision_view_page.php?bugnote_id=15866#r9649
2016-10-09 22:27Edward-sanNote Added: 0015867
2016-10-09 22:27Edward-sanStatusfeedback => resolved
2016-10-09 22:27Edward-sanResolutionreopened => fixed
2018-09-30 21:59Blzut3Statusresolved => closed
2020-04-11 00:12Ru5tK1ngRelationship addedrelated to 0002875
2020-04-11 00:16Ru5tK1ngNote Added: 0021257
2020-04-11 00:16Ru5tK1ngStatusclosed => feedback
2020-04-11 00:16Ru5tK1ngResolutionfixed => reopened
2020-04-11 00:17Ru5tK1ngProduct Version3.0-beta => 3.0
2020-04-11 00:17Ru5tK1ngTarget Version3.0 => 3.1
2020-04-19 20:27Torr SamahoNote Added: 0021269
2020-04-19 23:31Edward-sanNote Added: 0021273
2020-04-19 23:32Edward-sanStatusfeedback => needs review
2020-04-19 23:32Edward-sanFixed in Version3.0 =>
2020-04-19 23:32Edward-sanTarget Version3.1 =>
2020-04-20 19:52Torr SamahoNote Added: 0021275
2020-04-20 19:53Torr SamahoStatusneeds review => needs testing

Notes
(0015782)
Edward-san   
2016-10-07 09:21   
(edited on: 2016-10-07 09:41)
Oh well, unless there's time to track down the original problem with smooth_mouse, we have to fix the menu for the time being.

[edit] Done.

(0015809)
Edward-san   
2016-10-08 17:11   
Merged to 3.0 upstream:https://bitbucket.org/Torr_Samaho/zandronum/commits/61a8c6efc099 [^]
(0015859)
unknownna   
2016-10-09 19:32   
Yes, it toggles m_filter now. Nice to see you work so fast, Edward-san. Keep it up!
(0015866)
unknownna   
2016-10-09 21:56   
(edited on: 2016-10-09 22:02)
Quote from Edward-san
Oh well, unless there's time to track down the original problem with smooth_mouse, we have to fix the menu for the time being.

Edward-san, I noticed one difference between ZDoom and Zandronum with cl_capfps 0: The view is jittery in ZDoom and smooth in Zandronum when aiming and moving around at the same time. In ZDoom, you have to use "smooth_mouse 1" to make the view as smooth as Zandronum. Could it be that Carnevil hard-coded "smooth_mouse 1" into Skulltag's default mouse behavior and thus disabled smooth_mouse altogether?

(0015867)
Edward-san   
2016-10-09 22:27   
Sounds plausible. Anyways, this discussion can continue on another ticket.
(0021257)
Ru5tK1ng   
2020-04-11 00:16   
Since 2875 restored actual smooth_mouse functionality, I would suggest committed 61a8c6e be undone and restore the smooth_mouse option and possibly add an m_filter option as well.
(0021269)
Torr Samaho   
2020-04-19 20:27   
I agree.
(0021273)
Edward-san   
2020-04-19 23:31   
PR is ready. Regarding the option 'm_filter', as discussed in the dev meeting, no action is taken, unless there is enough support for it.
(0021275)
Torr Samaho   
2020-04-20 19:52   
I added your patch.