MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002851Zandronum[All Projects] Suggestionpublic2016-10-03 12:412018-09-30 21:52
ReporterTorr Samaho 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002851: Pause in client side demos
DescriptionGoing in direction of 0000581:0002160, I added an experimental demo_pause command. Please test this binary to see if it works as expected.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? test.cld (44,642) 2016-10-04 06:15
https://zandronum.com/tracker/file_download.php?file_id=1899&type=bug
? win7test.cld (363,940) 2016-10-08 09:12
https://zandronum.com/tracker/file_download.php?file_id=1917&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-03 12:41Torr SamahoNew Issue
2016-10-03 12:41Torr SamahoAssigned To => Torr Samaho
2016-10-03 12:41Torr SamahoStatusnew => needs testing
2016-10-03 12:43Torr SamahoProduct Version => 2.1
2016-10-03 12:43Torr SamahoTarget Version => 3.0
2016-10-04 01:19JKist3Note Added: 0015747
2016-10-04 06:03Torr SamahoNote Added: 0015748
2016-10-04 06:03Torr SamahoNote Edited: 0015748bug_revision_view_page.php?bugnote_id=15748#r9577
2016-10-04 06:15JKist3File Added: test.cld
2016-10-04 06:15JKist3Note Added: 0015750
2016-10-04 08:38Edward-sanNote Added: 0015751
2016-10-04 08:41Edward-sanNote Edited: 0015751bug_revision_view_page.php?bugnote_id=15751#r9579
2016-10-04 19:08Torr SamahoNote Added: 0015758
2016-10-05 03:03JKist3Note Added: 0015760
2016-10-08 08:59JKist3Note Added: 0015803
2016-10-08 09:11JKist3Note Edited: 0015803bug_revision_view_page.php?bugnote_id=15803#r9612
2016-10-08 09:12JKist3File Added: win7test.cld
2016-10-08 09:13JKist3Note Edited: 0015803bug_revision_view_page.php?bugnote_id=15803#r9613
2016-10-16 19:41Torr SamahoNote Added: 0016027
2016-10-30 20:50WaTaKiDNote Added: 0016127
2016-10-30 20:50WaTaKiDNote Edited: 0016127bug_revision_view_page.php?bugnote_id=16127#r9834
2016-12-28 00:15CombinebobntNote Added: 0016557
2016-12-28 00:16Ru5tK1ngStatusneeds testing => resolved
2016-12-28 00:16Ru5tK1ngResolutionopen => fixed
2016-12-28 00:16Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:52Blzut3Statusresolved => closed

Notes
(0015747)
JKist3   
2016-10-04 01:19   
I setup a local server and recorded a demo on it with the listed binary. When I try to playback the demo I get a "couldn't read file test.cld" error.
(0015748)
Torr Samaho   
2016-10-04 06:03   
None of the changes should have any effect on finding the demo. Is the file "test.cld" where you expect it to be? Can you upload it somewhere so that I can check the demo?
(0015750)
JKist3   
2016-10-04 06:15   
the file is where I expected it. I attached the file. It only needs doom2.wad iwad, no pwads.
(0015751)
Edward-san   
2016-10-04 08:38   
(edited on: 2016-10-04 08:41)
The demo plays fine for me, but when I try to unlock the pause by demo_pause I get 'connection interrupted' and the player does not move at all, but the sectors, the monsters and more work fine.
(0015758)
Torr Samaho   
2016-10-04 19:08   
This should fix the 'connection interrupted' problem (I didn't notice this before since I only tested a demo recorded from a spectators perspective). Furthermore, demo_skiptics now can be used while a demo is paused, which allows to go through a demo tic by tic.

I also had no problems opening "test.cld". Is it in the same folder as zandronum.exe?
(0015760)
JKist3   
2016-10-05 03:03   
ok so after some debugging I'm pretty sure this is because im trying to test this out on a windowsXP machine. According to Bzlut3 the stable releases use vs2005 and the test ones use vs2015.
(0015803)
JKist3   
2016-10-08 08:59   
(edited on: 2016-10-08 09:13)
Ok. So I installed windows 7 today in order to better help debug things. Now the demos playback! I have run into a few potential bugs, i'm not sure they are all related to demo_pause but I will list them:

1) when pausing a demo, somehow it seems to halfway lock in the angle you are currently looking at. When I advance a demo tic by tic with demo_skiptics 1, the angle i end up looking at when im done advancing is different from what it was in game. You can easily see this with plasma. in the demo the plasma will shoot off at an angle the demo is not facing.

2) weapon animations get desynced when pausing and advancing tic by tic.

3) I wanted to bind a key to pause and advance demos tic by tic. Here is what i put in my zandronum cfg:

;=demo_pause
'=demo_skiptics 1

whenever i press either of those keys or any other key in a demo it just brings up the game menu. It would be preferable to have binds working for this so that you could just press your demo pause button or demo slow motion button after it was paused

I'm attaching a new demo that hopefully shows what im talking about. Try to pause the demo and keep advancing it with demo_skiptics 1 until i have turned to face a new direction from when the demo was originally paused. The demo should be looking in a different direction than I was in game. Also pause the demo and keep advancing while I shoot a weapon (ssg is easy to see this on). The weapon animation is not properly synced.

EDIT: the attached win7test.cld demo is on dwango5.wad.
(0016027)
Torr Samaho   
2016-10-16 19:41   
This should allow key binding.
(0016127)
WaTaKiD   
2016-10-30 20:50   
'https://bitbucket.org/Torr_Samaho/zandronum/commits/a7fde8440b08f3ccfaab1c1084191d43686c8e73 [^]'
and
'https://bitbucket.org/Torr_Samaho/zandronum/commits/cbc5f23465355dcff614ef1fa4d8768e456d7342 [^]'
were added for winxp demo playback

while 'https://bitbucket.org/Torr_Samaho/zandronum/commits/666d1e3198fb8bb241b40ef32a2243a5e0fb94c6 [^]' allows binds to be used during demo playback
(0016557)
Combinebobnt   
2016-12-28 00:15   
Tested in a lan server, demo_pause seemed to work as intended. I used it normally, spammed it, and even paused in intermission and everything worked. Binding a key to demo_skiptics 1 while it was paused worked well too, as the demo played tic by tic.