MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000282Zandronum[All Projects] Suggestionpublic2011-02-06 22:092018-09-30 19:51
ReporterDevilHunter 
Assigned ToDusk 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version98d 
Target VersionFixed in Version1.0 
Summary0000282: Have Delmap into Console/Rcon Commands
DescriptionShould have the option, for some wads that have huge maplists, and you need to remove just one. Would be better then Shutting down the server, and starting it back up, or for people who only have rcon, and no way to know what server config to re-exec on the server.
Steps To ReproduceN/A
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-02-06 22:09DevilHunterNew Issue
2012-02-13 18:26DuskNote Added: 0002598
2012-02-13 20:41DuskNote Edited: 0002598bug_revision_view_page.php?bugnote_id=2598#r1302
2012-02-13 22:41DuskNote Edited: 0002598bug_revision_view_page.php?bugnote_id=2598#r1303
2012-02-14 16:13DuskNote Edited: 0002598bug_revision_view_page.php?bugnote_id=2598#r1304
2012-04-05 16:12DevilHunterNote Added: 0003139
2012-04-07 14:33Torr SamahoNote Added: 0003168
2012-04-07 14:33Torr SamahoAssigned To => Dusk
2012-04-07 14:33Torr SamahoStatusnew => feedback
2012-04-07 15:50DuskNote Added: 0003173
2012-04-07 15:50DuskNote Edited: 0003173bug_revision_view_page.php?bugnote_id=3173#r1662
2012-04-07 15:52DuskNote Edited: 0003173bug_revision_view_page.php?bugnote_id=3173#r1663
2012-04-07 16:02DuskNote Edited: 0003173bug_revision_view_page.php?bugnote_id=3173#r1664
2012-04-15 18:18Torr SamahoNote Added: 0003291
2012-04-30 07:57DevilHunterNote Added: 0003509
2012-04-30 07:57DevilHunterStatusfeedback => assigned
2012-05-01 02:00Torr SamahoStatusassigned => resolved
2012-05-01 02:00Torr SamahoFixed in Version => 1.0
2012-05-01 02:00Torr SamahoResolutionopen => fixed
2018-09-30 19:51Blzut3Statusresolved => closed

Notes
(0002598)
Dusk   
2012-02-13 18:26   
(edited on: 2012-02-14 16:13)
I got a sample implementation working in Not Ebola:
'https://bitbucket.org/CrimsonDusk/notebola/changeset/19fe066aad1f [^]'

EDIT:'https://bitbucket.org/CrimsonDusk/notebola/changeset/1f5895cb0f21 [^]' adds delmap_idx, which allows deletion of a map based on index number. Becomes useful when there's multiple entries of the same map in map rotation. Uses the same indices as what `maplist` prints out - though is this a good idea since `maplist` starts at 1 and not at 0?

EDIT 2: Updated links in light of the actual naming of the fork..
(0003139)
DevilHunter   
2012-04-05 16:12   
Just wondering, since your a Dev now Dusk, has anything been done wih this in Skulltag?
(0003168)
Torr Samaho   
2012-04-07 14:33   
Please don't post notes that essentially just say "When will this be added/fixed?" or "Will this be added/fixed?". This just pollutes the ticket and makes it more difficult to see the essential information.

Anyway, I added the patch and made a small fix to delmap_idx.

But don't feel encouraged by this to post more notes that are just intended to promote your favorite suggestion.
(0003173)
Dusk   
2012-04-07 15:50   
(edited on: 2012-04-07 16:02)
[17:26:47] <+Dusk> actually... wait, what?
[17:26:47] <+CIA-1> Skulltag: Benjamin Berkels <> * f81e00233235 r3310 /src/maprotation.cpp: Fixed: delmap_idx removed the first map with the name of the map with the given index, not necessarily the map with the index. This makes a difference if one map is in the rotation more than once.

I like your timing. :)

Here is insertmap, too:'https://bitbucket.org/CrimsonDusk/notebola/changeset/d7da1d18f8ac [^]'
Allows adding maps into other positions rather than just at the end. To avoid code duplication, I extended the functionality of MAPROTATION_AddMap and gave it a third, optional parameter for position. 0, the default, means the end of the rotation. Said function also prints out the position the map was added at, as well. I figured it'd be useful for server admins.

Should it be called insmap, though, for consistency?
(0003291)
Torr Samaho   
2012-04-15 18:18   
I think insertmap is fine and added your patch.
(0003509)
DevilHunter   
2012-04-30 07:57   
Just tested this on Armada.. Due to my laggy connection, it didn't show up in Rcon, but in Screen, it did (linux). Have yet to test this on Windows, but so far looks good, and works.

Thanks Dusk, and Torr :p