MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002796Zandronum[All Projects] Bugpublic2016-07-30 08:142018-09-30 21:53
ReporterAtomicLugia 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002796: Corpses of hi-res skins have no scaling
DescriptionI have hi-res skins (which are scaled down to match the doom marine). If a player/bot die with this skin, the last frames of their death animation have no scaling anymore and are either really huge or small (skins with low-res sprites). This happens in version 3.0-alpha-r160519-2047.
Steps To ReproduceAs Self:
 - Add a hi-res skin to Zandronum.
 - Change your skin to this skin.
 - Start a game.
 - Kill yourself and watch your corpse.

As Bot:
 - Add a hi-res skin and it's bot to Zandronum.
 - Start a new game.
 - Add the bot in the game.
 - Kill this bot/let it die.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesjpg skinglitch.JPG (483,950) 2016-07-30 08:14
/tracker/file_download.php?file_id=1871&type=bug
zip LopunnySkin.zip (548,442) 2016-07-30 08:59
/tracker/file_download.php?file_id=1872&type=bug
? ZDoomLopunnySkin.wad (2,217,778) 2016-10-02 08:02
/tracker/file_download.php?file_id=1892&type=bug
png Screenshot_Doom_20161002_095818.png (252,954) 2016-10-02 08:04
/tracker/file_download.php?file_id=1893&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-07-30 08:14AtomicLugiaNew Issue
2016-07-30 08:14AtomicLugiaFile Added: skinglitch.JPG
2016-07-30 08:37WaTaKiDNote Added: 0015414
2016-07-30 08:59AtomicLugiaFile Added: LopunnySkin.zip
2016-07-30 09:01AtomicLugiaNote Added: 0015415
2016-08-13 15:08Torr SamahoNote Added: 0015443
2016-10-02 08:02AtomicLugiaFile Added: ZDoomLopunnySkin.wad
2016-10-02 08:03AtomicLugiaNote Added: 0015722
2016-10-02 08:04AtomicLugiaFile Added: Screenshot_Doom_20161002_095818.png
2016-11-27 16:30Torr SamahoNote Added: 0016357
2016-11-27 16:31Torr SamahoTarget Version => 3.0
2016-11-29 20:32Torr SamahoStatusnew => feedback
2016-11-29 20:56Edward-sanNote Added: 0016379
2016-11-29 21:03Torr SamahoNote Added: 0016380
2016-11-29 21:15Edward-sanNote Added: 0016381
2016-11-29 21:16Edward-sanNote Edited: 0016381bug_revision_view_page.php?bugnote_id=16381#r9927
2016-11-29 21:23Edward-sanNote Edited: 0016381bug_revision_view_page.php?bugnote_id=16381#r9928
2016-11-29 21:29Edward-sanNote Added: 0016382
2016-11-29 21:32Torr SamahoNote Added: 0016383
2016-11-29 21:37Torr SamahoNote Edited: 0016383bug_revision_view_page.php?bugnote_id=16383#r9930
2016-11-29 21:46Torr SamahoNote Edited: 0016383bug_revision_view_page.php?bugnote_id=16383#r9931
2016-11-29 22:01Edward-sanNote Added: 0016384
2016-11-29 22:02Edward-sanNote Edited: 0016384bug_revision_view_page.php?bugnote_id=16384#r9933
2016-11-29 22:06Torr SamahoNote Added: 0016385
2016-11-29 22:06Torr SamahoAssigned To => Torr Samaho
2016-11-29 22:06Torr SamahoStatusfeedback => needs testing
2016-11-29 22:13Edward-sanNote Added: 0016386
2016-11-29 22:13Torr SamahoNote Added: 0016387
2016-11-29 22:16Edward-sanNote Edited: 0016386bug_revision_view_page.php?bugnote_id=16386#r9935
2016-11-29 22:26Edward-sanNote Edited: 0016386bug_revision_view_page.php?bugnote_id=16386#r9936
2016-11-29 22:27Edward-sanNote Added: 0016388
2016-11-29 22:31Edward-sanNote Edited: 0016388bug_revision_view_page.php?bugnote_id=16388#r9938
2016-11-29 22:32Edward-sanNote Edited: 0016388bug_revision_view_page.php?bugnote_id=16388#r9939
2016-11-29 22:32Torr SamahoNote Added: 0016389
2016-11-29 22:37Edward-sanNote Added: 0016390
2016-11-29 22:40Edward-sanNote Edited: 0016390bug_revision_view_page.php?bugnote_id=16390#r9941
2016-11-29 22:52Edward-sanNote Edited: 0016390bug_revision_view_page.php?bugnote_id=16390#r9942
2016-11-30 19:25Torr SamahoNote Added: 0016399
2016-12-16 07:43Ru5tK1ngNote Added: 0016501
2016-12-16 07:43Ru5tK1ngStatusneeds testing => resolved
2016-12-16 07:43Ru5tK1ngResolutionopen => fixed
2016-12-16 07:43Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:53Blzut3Statusresolved => closed

Notes
(0015414)
WaTaKiD   
2016-07-30 08:37   
please provide an example wad
(0015415)
AtomicLugia   
2016-07-30 09:01   
Added a hi-res skin of Lopunny which also has a bot. Perfect for testing this issue in version 3.0-alpha-r160519-2047.
(0015443)
Torr Samaho   
2016-08-13 15:08   
This doesn't seem to work properly in GZDoom 1.8.6 either. Can somebody confirm this? If so, does it work in the latest GZDoom version?
(0015722)
AtomicLugia   
2016-10-02 08:03   
I uploaded a ZDoom/GZDoom compatible version of the hi-res skin of Lopunny.

I tested it in the newest version of GZDoom (2.2.0 64-bit) and there's no problem.
(0016357)
Torr Samaho   
2016-11-27 16:30   
Can somebody check when GZDoom fixed this?
(0016379)
Edward-san   
2016-11-29 20:56   
Uh, actually I tried ZDoomLopunnySkin.wad with gzdoom 1.8.6 and gzdoom git and I see no problem here.
(0016380)
Torr Samaho   
2016-11-29 21:03   
I tested LopunnySkin.zip with gzdoom 1.8.6, not ZDoomLopunnySkin.wad. The latter is newer than my note 0002796:0015443.
(0016381)
Edward-san   
2016-11-29 21:15   
(edited on: 2016-11-29 21:23)
I can't manage to reproduce the problem unless I try with the bot method (and I can't manage to add a bot with that skin in zdoom). What's supposed to happen with the consoleplayer?

[edit] Now I understood. I need to respawn and see the corpse (only if I'm in multiplayer mode).
(0016382)
Edward-san   
2016-11-29 21:29   
I found this commit which may help:'https://bitbucket.org/Torr_Samaho/zandronum-zdoom-sync/commits/c6667f18f9e3d8fd953b49d2abf1dbe81263354a [^]' . Also I found this change, but I don't know if it's useful for us:'https://bitbucket.org/Torr_Samaho/zandronum-zdoom-sync/commits/3fef7231f0a296b99504dbb0e9328ae1845d47d8 [^]' .
(0016383)
Torr Samaho   
2016-11-29 21:32   
(edited on: 2016-11-29 21:46)
Quote from Edward-san

I can't manage to reproduce the problem unless I try with the bot method (and I can't manage to add a bot with that skin in zdoom). What's supposed to happen with the consoleplayer?

[edit] Now I understood. I need to respawn and see the corpse (only if I'm in multiplayer mode).

When using chase cam in single player, the player sprite is huge. Also the sprite size in the player setup menu is much too big.

EDIT: The commit you found sounds good. I'll check if this fixes the problem.
EDIT2: Needs more fixes.
(0016384)
Edward-san   
2016-11-29 22:01   
(edited on: 2016-11-29 22:02)
Btw, LopunnySkin.zip is not compatible with zdoom. This message in console should help why:


Bad format for skin 1: {


If you try the zdoom version it works fine with zdoom git and it's buggy in gzdoom 1.8.6 as expected.
(0016385)
Torr Samaho   
2016-11-29 22:06   
I think I fixed the problems with LopunnySkin.zip in Zandronum now. In addition to the ZDoom bug fix you found, this also needed fixes in the Zandronum's code. Can you check if this also fixes ZDoomLopunnySkin.wad?
(0016386)
Edward-san   
2016-11-29 22:13   
(edited on: 2016-11-29 22:26)
Confirmed to work with both the skin wads.
(0016387)
Torr Samaho   
2016-11-29 22:13   
Thanks for checking!
(0016388)
Edward-san   
2016-11-29 22:27   
(edited on: 2016-11-29 22:32)
I found a problem with online: if you host your server with at least 1 player and the lopunny bot, the bot too tiny (as if it was scaled down twice).
(0016389)
Torr Samaho   
2016-11-29 22:32   
So just the bot is affected and it only happens online?
(0016390)
Edward-san   
2016-11-29 22:37   
(edited on: 2016-11-29 22:52)
Hm, exactly, but actually I managed to reproduce also with the changeset before this fix. I didn't investigate when it broke.

[edit] more info: if the tiny bot is killed, the respawned bot appears okay again.

[edit2]'https://bitbucket.org/zandronum/zandronum-sandbox/commits/0715ab3aa5764ca57dc0d5f120a8c0f4cfb64a30 [^]' fixes the issue for me.
(0016399)
Torr Samaho   
2016-11-30 19:25   
Looks good! Added.
(0016501)
Ru5tK1ng   
2016-12-16 07:43   
With the 12/6 changes I didn't see any issue with both wads online as a player vs a bot.