MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002791Zandronum[All Projects] Bugpublic2016-07-19 17:172016-10-15 16:32
ReporterRu5tK1ng 
Assigned To 
PrioritynormalSeverityminorReproducibilitysometimes
StatusconfirmedResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target VersionFixed in Version 
Summary0002791: Moving slightly off a spawn makes you vunerable to join/defect telefrag in team games
DescriptionIn CTF, if you gently nudge yourself off a spawn, you open yourself up to being telefragged by a joining teammate or by a defecting enemy, despite there being available team spawns.
Steps To ReproduceDownload a CTF pack such as: 'http://allfearthesentinel.net/download?file=idl201x_b.pk3 [^]'

1. Host a server locally in CTF mode
2. Connect 4 clients
3. Join all of them to the same team
4. Move 1 client a bit off his spawn
5. Use another client to repeatedly spectate and join until telefrag occurs.
Additional Information
TagsNo tags attached.
Relationships
related to 0001253closed  Team telefrag issue: G_CheckSpot always returns true if the spawn spot is > player height for the sector it's in 
related to 0001499closed  Slight chance that players will spawn on each other (same spawnpoint) 
related to 0001634closed Edward-san Weird spawn telefragging behavior on Duel32 + Transfer Heights 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-07-19 17:17Ru5tK1ngNew Issue
2016-07-19 17:19Ru5tK1ngRelationship addedrelated to 0001253
2016-07-19 17:21Ru5tK1ngRelationship addedrelated to 0001499
2016-07-19 17:30Edward-sanNote Added: 0015398
2016-07-19 17:30Edward-sanStatusnew => confirmed
2016-07-20 16:45Edward-sanNote Added: 0015403
2016-07-20 16:45Edward-sanAssigned To => Edward-san
2016-07-20 16:45Edward-sanStatusconfirmed => feedback
2016-07-20 16:46Edward-sanNote Edited: 0015403bug_revision_view_page.php?bugnote_id=15403#r9364
2016-07-20 18:09WaTaKiDNote Added: 0015404
2016-08-17 08:45Edward-sanNote Added: 0015454
2016-08-17 22:40WaTaKiDNote Added: 0015462
2016-08-18 08:47Edward-sanNote Added: 0015472
2016-08-18 08:49Edward-sanNote Edited: 0015472bug_revision_view_page.php?bugnote_id=15472#r9410
2016-08-18 08:53Edward-sanAssigned ToEdward-san =>
2016-08-18 08:53Edward-sanStatusfeedback => confirmed
2016-08-18 08:53Edward-sanSummaryMoving slightly off a spawn makes you vunerable to telefrag in team games => Moving slightly off a spawn makes you vunerable to join telefrag in team games
2016-08-18 08:53Edward-sanDescription Updatedbug_revision_view_page.php?rev_id=9412#r9412
2016-08-18 08:54Edward-sanSummaryMoving slightly off a spawn makes you vunerable to join telefrag in team games => Moving slightly off a spawn makes you vunerable to join/defect telefrag in team games
2016-10-15 16:32Ru5tK1ngRelationship addedrelated to 0001634

Notes
(0015398)
Edward-san   
2016-07-19 17:30   
This is caused by G_CheckSpot being called for the joining spectator having no body.

This happens because selecting the team makes the server destroy the currently available spectator body.

When the player's body is not present, the in-game players position is checked with the spawn spot with exact match, i.e. no bounds checking at all.

The fix would be avoiding the body removal under these circumstances, but this must be discussed first.
(0015403)
Edward-san   
2016-07-20 16:45   
(edited on: 2016-07-20 16:46)
Please check if this changeset:'https://bitbucket.org/zandronum/zandronum-sandbox/commits/49b6b1d75a0189c34dae8019750e3db2d7f4a526 [^]' fixes the issue and introduces no regressions in team gaming.
(0015404)
WaTaKiD   
2016-07-20 18:09   
this 3.0 build contains the above commit: 'https://www.dropbox.com/s/0px3gg0ga5nqrb8/zandronum-3.0-r160720-1643-49b6b1d-windows.zip?dl=0 [^]'
(0015454)
Edward-san   
2016-08-17 08:45   
I'm thinking there's a major problem, but I need some info: does the telefrag happen also when the victim moved a bit and then an enemy defects their team to join the victim's?
(0015462)
WaTaKiD   
2016-08-17 22:40   
if the victim moves, then yes a defection has a chance to telefrag
(0015472)
Edward-san   
2016-08-18 08:47   
(edited on: 2016-08-18 08:49)
Damn it, that's caused by the same issue as the spectator joining: the code in server_ChangeTeam destroys the player's body before the team spot selection. The fix has to be different.

Sadly the fix must be postponed for after 3.0 release, because of possible side effects which should be avoided for now.