MantisBT - Zandronum
View Issue Details
0002785Zandronum[All Projects] Bugpublic2016-07-15 05:282018-09-30 21:56
Tiger 
Dusk 
normalminoralways
closedfixed 
Microsoft WindowsWindows 106.3
3.0-beta 
3.03.0 
0002785: UDMF Scaling Incorrect NetGames
Having a UDMF map that contains flats being scaled less than '1.0' (for example, 0.9 or less), the flat will not render correctly on a NetGame (Server\Client) while Single Player environment works perfectly fine.


Using: Zandronum 3.0-alpha-r160703-1614 (NOTE: This also occurs in 4.0 too)
File Attached: 7Zip using PPMd algorithm
I have attached a test file which can be used to see the effect. Making a similar test map is simple: Create a parent sector, edit the flat scaling to '0.6' or anything less than '1.0' then:

* Invoke the zandronum binary with the '-host' switch via CLI
* With the game server started, join said game server.
* Look for the sector references that contains the scaling properties.

Single player does not contain this odd behavior.
No tags attached.
7z UDMF_Scaling.7z (1,455) 2016-07-15 05:28
https://zandronum.com/tracker/file_download.php?file_id=1865&type=bug
png UDMF_Scaling.png (1,665,260) 2016-07-15 05:28
https://zandronum.com/tracker/file_download.php?file_id=1866&type=bug
Issue History
2016-07-15 05:28TigerNew Issue
2016-07-15 05:28TigerFile Added: UDMF_Scaling.7z
2016-07-15 05:28TigerFile Added: UDMF_Scaling.png
2016-07-15 20:20DuskNote Added: 0015319
2016-07-15 22:29DuskNote Added: 0015321
2016-07-15 22:51TigerNote Added: 0015322
2016-07-15 22:58DuskNote Added: 0015323
2016-07-15 22:59DuskAssigned To => Dusk
2016-07-15 22:59DuskStatusnew => assigned
2016-07-15 23:07DuskNote Added: 0015324
2016-07-15 23:07DuskStatusassigned => needs review
2016-10-18 20:54Ru5tK1ngNote Added: 0016053
2016-10-18 20:54Ru5tK1ngStatusneeds review => needs testing
2016-10-18 20:54Ru5tK1ngTarget Version => 3.0
2016-12-08 02:56Ru5tK1ngNote Added: 0016440
2016-12-08 02:56Ru5tK1ngStatusneeds testing => resolved
2016-12-08 02:56Ru5tK1ngResolutionopen => fixed
2016-12-08 02:56Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:56Blzut3Statusresolved => closed

Notes
(0015319)
Dusk   
2016-07-15 20:20   
This is because the scale is only transmitted at integer precision, without the fractional part.
(0015321)
Dusk   
2016-07-15 22:29   
The example WAD appears to be broken.


$ 7zr x UDMF_Scaling.7z

7-Zip (A) [64] 9.20 Copyright (c) 1999-2010 Igor Pavlov 2010-11-18
p7zip Version 9.20 (locale=fi_FI.UTF-8,Utf16=on,HugeFiles=on,2 CPUs)

Processing archive: UDMF_Scaling.7z

Extracting UDMF_Scaling.wad Unsupported Method

Sub items Errors: 1
(0015322)
Tiger   
2016-07-15 22:51   
I used 7zip version 16.00 ['http://www.7-zip.org/ [^]' ] to generate that archive file.

Note: I hope this uses BBCode?

[Fri.15.Jul.2016 17:48:02.48] [C:\Users\Nicholas]
$ "C:\Program Files\7-Zip\7z.exe" t .\Desktop\UDMF_Scaling.7z

7-Zip [64] 16.00 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-10

Scanning the drive for archives:
1 file, 1455 bytes (2 KiB)

Testing archive: .\Desktop\UDMF_Scaling.7z
--
Path = .\Desktop\UDMF_Scaling.7z
Type = 7z
Physical Size = 1455
Headers Size = 138
Method = PPMD
Solid = -
Blocks = 1

Everything is Ok

Size: 6685
Compressed: 1455
(0015323)
Dusk   
2016-07-15 22:58   
Ah. I had to use 7za, not 7zr, which does not support the PPMD method. Let's see here…
(0015324)
Dusk   
2016-07-15 23:07   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/125 [^]'

I also needed to change the SetSectorPanning message similarly to have the textures align correctly.
(0016053)
Ru5tK1ng   
2016-10-18 20:54   
Code was merged:'https://bitbucket.org/Torr_Samaho/zandronum/commits/1a57bf607bd47617425d88c647717dadb7b7623f [^]'
(0016440)
Ru5tK1ng   
2016-12-08 02:56   
The water now seems to scale properly offline and online.