MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002748Zandronum[All Projects] Bugpublic2016-06-05 05:472018-04-20 07:09
ReporterStrikerMan780 
Assigned ToEdward-san 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.1Fixed in Version3.1 
Summary0002748: Changset 9556:54c5571372c0 Isn't supposed to affect A_GunFlash, but it does.
DescriptionZDoom introduced a change that makes the Muzzle Flashes for the stock weapons use 2 tics, to mimic vanilla Doom behavior, however, it wasn't supposed to affect A_GunFlash, which allows one to make 1-tic flashes.

When Zandronum introduced these changes, it got fucked up and affects A_GunFlash too, breaking some weapons in mods considerably. (No muzzle flash showing, or screwing up when codepointers fire.)

See this post and the reply:'http://forum.zdoom.org/viewtopic.php?p=898285#p898285 [^]'
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0002607resolved Edward-san Weapon sync regression in 3.0 
Attached Files? TestWad_BrokenFlash.wad (191,789) 2017-11-13 17:06
https://zandronum.com/tracker/file_download.php?file_id=2288&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-06-05 05:47StrikerMan780New Issue
2016-06-05 06:08WaTaKiDNote Added: 0015018
2016-06-05 06:09WaTaKiDNote Edited: 0015018bug_revision_view_page.php?bugnote_id=15018#r9056
2016-06-05 06:58StrikerMan780Note Added: 0015020
2016-06-05 10:31DuskRelationship addedchild of 0002607
2016-12-24 22:43DuskTarget Version => 3.0
2017-11-09 00:02LeonardStatusnew => assigned
2017-11-09 00:02LeonardAssigned To => Edward-san
2017-11-09 00:03LeonardTarget Version3.0 => 3.1
2017-11-13 16:43Edward-sanNote Added: 0018873
2017-11-13 16:43Edward-sanStatusassigned => feedback
2017-11-13 16:43Edward-sanNote Edited: 0018873bug_revision_view_page.php?bugnote_id=18873#r11332
2017-11-13 16:50StrikerMan780Note Added: 0018874
2017-11-13 16:50StrikerMan780Statusfeedback => assigned
2017-11-13 17:06StrikerMan780File Added: TestWad_BrokenFlash.wad
2017-11-13 17:07StrikerMan780Note Added: 0018875
2017-11-13 17:55Edward-sanNote Added: 0018876
2017-11-13 17:55Edward-sanStatusassigned => needs testing
2017-11-16 16:46LeonardNote Added: 0018886
2017-11-19 10:59Torr SamahoNote Added: 0018892
2018-04-16 20:17StrikerMan780Note Added: 0019166
2018-04-18 05:38StrikerMan780Note Added: 0019170
2018-04-20 07:09DuskStatusneeds testing => resolved
2018-04-20 07:09DuskFixed in Version => 3.1
2018-04-20 07:09DuskResolutionopen => fixed

Notes
(0015018)
WaTaKiD   
2016-06-05 06:08   
(edited on: 2016-06-05 06:09)
the 'repeated flash state' fix was disabled here:'https://bitbucket.org/Torr_Samaho/zandronum/commits/2ad9d0af90838a40076af4e7367f9954ab303d9c [^]'

due to causing a weapon sync regression, as seen here:'http://zandronum.com/tracker/view.php?id=2607 [^]'
(0015020)
StrikerMan780   
2016-06-05 06:58   
*sigh* Fuck me, always something.

Hopefully it can be fixed without disabling it soon. Quite a few recently created mods break because of this.
(0018873)
Edward-san   
2017-11-13 16:43   
Striker, could you upload an example with the A_GunFlash problem? I need to test the fix for ticket 0002607.
(0018874)
StrikerMan780   
2017-11-13 16:50   
Yeah, give me a little bit, and I'll put one together.
(0018875)
StrikerMan780   
2017-11-13 17:07   
Uploaded.
(0018876)
Edward-san   
2017-11-13 17:55   
Ok, the patch provided in 0002607:0018845 seems to work fine with the provided wad, both offline and online, but we need more tests to find out if anything else is broken.
(0018886)
Leonard   
2017-11-16 16:46   
I got to test this and even with the conditions mentioned in 0002607:0018833 the example wad clearly works with the fix (and doesn't without).
On that note, I don't think we should wait further before pulling these changes, the kind of testing Torr asks for here (i.e. real world/general testing) should ideally be provided by more frequent beta releases and not delay merges IMO.
(0018892)
Torr Samaho   
2017-11-19 10:59   
I added the patch.
Quote from Leonard

On that note, I don't think we should wait further before pulling these changes, the kind of testing Torr asks for here (i.e. real world/general testing) should ideally be provided by more frequent beta releases and not delay merges IMO.

Just to clarify: I was not asking for real world testing to be done before the patch can be pulled. I was merely asking whether such testing already has been done to get an impression on which kind of testing baseline I can rely on to decide whether to pull.
(0019166)
StrikerMan780   
2018-04-16 20:17   
If someone can link me a build with these changes, I can test them.
(0019170)
StrikerMan780   
2018-04-18 05:38   
I've got the latest build of 3.1 from here:'https://jenkins.csnxs.uk/job/zandronum-stable/ [^]'

I've stress-tested this pretty hard in a server with 15 bots, and I haven't had any weapon desyncs. Also, weapon flashes now behave properly both online and offline in my mods.