MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002691Zandronum[All Projects] Bugpublic2016-03-30 20:322018-05-09 09:54
ReporterWaTaKiD 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.1Fixed in Version3.1 
Summary0002691: items visually sink in swimmable sector
Descriptiondoes not happen in singleplayer, zan 2.1.2, or gzdoom 1.8.6
Steps To Reproducestart a server with the attached wad
notice the health bonuses slowly sink (in order to pick them up, u have to go where they spawned, not where u see them)

now go offline and notice the health bonuses stay put
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0003350closed  Sinking items in deep water desync 
Attached Files? test-swim.wad (9,332) 2016-03-30 20:32
https://zandronum.com/tracker/file_download.php?file_id=1775&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-03-30 20:32WaTaKiDNew Issue
2016-03-30 20:32WaTaKiDFile Added: test-swim.wad
2016-03-30 21:57WaTaKiDNote Added: 0014625
2016-03-30 23:45Edward-sanNote Added: 0014627
2016-03-30 23:45Edward-sanStatusnew => confirmed
2016-03-30 23:48Edward-sanNote Edited: 0014627bug_revision_view_page.php?bugnote_id=14627#r8862
2016-03-31 09:11Edward-sanAssigned To => Edward-san
2016-03-31 09:11Edward-sanStatusconfirmed => assigned
2016-03-31 10:08Edward-sanNote Added: 0014629
2016-03-31 10:08Edward-sanStatusassigned => feedback
2016-03-31 10:09Edward-sanNote Edited: 0014629bug_revision_view_page.php?bugnote_id=14629#r8864
2016-03-31 10:49Edward-sanNote Edited: 0014629bug_revision_view_page.php?bugnote_id=14629#r8865
2016-04-01 00:57WaTaKiDNote Added: 0014632
2016-04-01 00:57WaTaKiDStatusfeedback => assigned
2016-04-02 15:52Edward-sanNote Added: 0014641
2016-04-02 15:53Edward-sanStatusassigned => feedback
2016-04-03 21:06Edward-sanNote Added: 0014672
2016-04-03 21:06Edward-sanStatusfeedback => assigned
2016-04-17 20:26Edward-sanNote Added: 0014721
2016-04-17 20:26Edward-sanStatusassigned => needs review
2016-05-08 20:58Edward-sanNote Added: 0014842
2016-05-08 20:58Edward-sanStatusneeds review => needs testing
2016-08-18 01:41CombinebobntNote Added: 0015470
2016-08-18 09:09Edward-sanNote Added: 0015477
2016-08-18 09:09Edward-sanStatusneeds testing => resolved
2016-08-18 09:09Edward-sanFixed in Version => 3.0
2016-08-18 09:09Edward-sanResolutionopen => fixed
2017-12-03 11:51Edward-sanRelationship addedhas duplicate 0003350
2017-12-03 11:53Edward-sanNote Added: 0018933
2017-12-03 11:53Edward-sanStatusresolved => feedback
2017-12-03 11:53Edward-sanResolutionfixed => reopened
2017-12-03 11:53Edward-sanStatusfeedback => confirmed
2017-12-03 12:33Edward-sanNote Edited: 0018933bug_revision_view_page.php?bugnote_id=18933#r11346
2017-12-03 12:33Edward-sanStatusconfirmed => feedback
2017-12-17 22:11Edward-sanNote Added: 0018967
2017-12-17 22:11Edward-sanStatusfeedback => needs testing
2017-12-20 13:33LeonardFixed in Version3.0 =>
2017-12-20 13:33LeonardTarget Version => 3.1
2018-05-08 21:21StrikerMan780Note Added: 0019229
2018-05-09 09:54LeonardStatusneeds testing => resolved
2018-05-09 09:54LeonardResolutionreopened => fixed
2018-05-09 09:54LeonardFixed in Version => 3.1

Notes
(0014625)
WaTaKiD   
2016-03-30 21:57   
ive narrowed it down to this commit as the cause:'https://bitbucket.org/Torr_Samaho/zandronum/commits/f4f639847b4609f3cc3c6cb8d57d7855682d8d5c [^]'
(0014627)
Edward-san   
2016-03-30 23:45   
(edited on: 2016-03-30 23:48)
The new code checks for the 'DROPPED' flag to determine if the actor can sink or not. Sadly, for some reason the client thinks the items have the DROPPED flag, hence making them 'sink'. I don't know why, though.
(0014629)
Edward-san   
2016-03-31 10:08   
(edited on: 2016-03-31 10:49)
Should be fixed with this changeset + this one (handles also the survival resets, doesn't change the behavior if an item is summoned or dropped).

Since this change involves quite a good part of the client gameplay, please test it thoroughly (a testing build with this would be nice).
(0014632)
WaTaKiD   
2016-04-01 00:57   
this build contains both of the above mentioned commits:'https://www.dropbox.com/s/e587acmjtso7xv6/zandronum-3.0-r160331-1046-708bb7a-windows.zip?dl=0 [^]'

with a quick test, it seems the issue is fixed, but i will give it a more thorough test another time
(0014641)
Edward-san   
2016-04-02 15:52   
Keep in mind that this affects ALL the actor things, hence I would recommend testing this with any mod which relies on the item inventories behavior.
(0014672)
Edward-san   
2016-04-03 21:06   
this patch needs some adjustments, so the testing is not needed for now.
(0014721)
Edward-san   
2016-04-17 20:26   
Pull request ready:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/83/fixed-the-server-didnt-inform-the-clients/diff [^]' .
(0014842)
Edward-san   
2016-05-08 20:58   
Added with changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/44214c3791c1ff50d1301a914e6db4a4dc25cbf3 [^]' .
(0015470)
Combinebobnt   
2016-08-18 01:41   
tested online in 160814-2010 and they didn't sink
(0015477)
Edward-san   
2016-08-18 09:09   
Thanks for checking!
(0018933)
Edward-san   
2017-12-03 11:53   
(edited on: 2017-12-03 12:33)
Reopening this because I could reproduce this again in 3.0.

[edit] Should be fixed by this commit, though now I wonder if there are other 'fixed' issues which aren't fixed at all.

I didn't investigate the broken changeset, but I think it happened since this change.
(0018967)
Edward-san   
2017-12-17 22:11   
Merged the patch in 3.1 upstream:'https://bitbucket.org/Torr_Samaho/zandronum-stable/commits/e2f08ac1dfef [^]' .
(0019229)
StrikerMan780   
2018-05-08 21:21   
Grabbed test-swim.wad and ran a server. The bonuses do not sink, neither online or offline. Fixed.