MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002687Zandronum[All Projects] Bugpublic2016-03-30 18:052018-09-30 22:04
ReporterTiger 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformDesktop (x86_64)OSWindowsOS Version6.3
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002687: BotEpisode Does not Work
DescriptionWhen a Episode uses the 'BotEpisode' property, Zandronum 3.0 (160229-1221) will ignore the property and not prompt the end-user with a 'Bot Skill Level'. This works fine in Zandronum 2.1.2, however, it seems the issue occurred somewhere in Zandronum 3.0.

Attached to this ticket is a demonstration PWAD for this issue.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files7z BotEpisode.7z (5,357) 2016-03-30 18:05
/tracker/file_download.php?file_id=1768&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-03-30 18:05TigerNew Issue
2016-03-30 18:05TigerFile Added: BotEpisode.7z
2016-04-02 16:38Torr SamahoAssigned To => Torr Samaho
2016-04-02 16:38Torr SamahoStatusnew => assigned
2016-04-02 18:14cobaltStatusassigned => needs testing
2016-04-02 18:14cobaltTarget Version => 3.0
2016-04-02 18:14cobaltDescription Updatedbug_revision_view_page.php?rev_id=8867#r8867
2016-04-02 18:14cobaltNote Added: 0014645
2016-04-07 03:33TigerNote Added: 0014677
2016-04-08 19:11DuskNote Added: 0014678
2016-04-08 19:12DuskStatusneeds testing => assigned
2016-04-09 11:39Torr SamahoNote Added: 0014680
2016-04-09 11:44cobaltStatusassigned => needs testing
2016-04-09 11:44cobaltNote Added: 0014682
2016-04-15 03:28Ru5tK1ngNote Added: 0014715
2016-04-15 03:29Ru5tK1ngStatusneeds testing => resolved
2016-04-15 03:29Ru5tK1ngResolutionopen => fixed
2016-04-15 03:29Ru5tK1ngFixed in Version => 3.0
2016-04-15 03:29Ru5tK1ngDescription Updatedbug_revision_view_page.php?rev_id=8909#r8909
2018-09-30 22:04Blzut3Statusresolved => closed

Notes
(0014645)
cobalt   
2016-04-02 18:14   
Issue addressed by commit fb056f043a73: Restored support for Skulltag's bot episode menus (configured by the MAPINFO episode properties botepisode, botskillname and botskillpicname), addresses 2687.
Committed by Benjamin Berkels [Torr Samaho] on Wednesday 31 December 1969 23:59:57

Changes in files:

 src/g_level.h | 4 ++++
 src/g_mapinfo.cpp | 18 ++++--------------
 src/menu/menu.cpp | 43 ++++++++++++++++++++++++++++++++++++++++++-
 src/namedef.h | 3 +++
 wadsrc/static/menudef.za | 19 ++++++++++++++++++-
 5 files changed, 71 insertions(+), 16 deletions(-)
(0014677)
Tiger   
2016-04-07 03:33   
Using build 3.0-alpha @ 160403-1900 - Commit 96e0e5e40e46, (credit to WaTaKiD), this seems to be fixed for me. However, in contrast, when the user is already playing, the user can not start a new game. Instead, they'll receive this message "You can't start a new game while in a network game.". In order to start a new game while having the CMPGINF, the end-user must completely restart the zandronum engine.

For example, if at first the player was already playing with the Bot Skill set as 'Nightmare', but later changed their minds and tried to start a new game - it'll be impossible. The user must first restart Zandronum and then set the botskill accordingly to their preference.
(0014678)
Dusk   
2016-04-08 19:11   
The problem regarding that is in menu.cpp:465: the if statement tests network state against NETSTATE_SINGLE when it should be using NETWORK_InClientMode().
(0014680)
Torr Samaho   
2016-04-09 11:39   
I replaced the check you mentioned with
NETWORK_GetState( ) == NETSTATE_CLIENT

Using "New game" when playing a client side demo seemed to work fine at first glance, so I didn't use NETWORK_InClientMode(). Needs further testing if it's ok to keep it like it is now, or if starting a new game while playing a demo causes unforeseen side effects.
(0014682)
cobalt   
2016-04-09 11:44   
Issue addressed by commit 5947ceecd7d3: Fixed: It was not possible to start a new game with the menu while the fake multiplayer mode was active.
Committed by Benjamin Berkels [Torr Samaho] on Wednesday 31 December 1969 23:59:57

Changes in files:

 src/menu/menu.cpp | 4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(0014715)
Ru5tK1ng   
2016-04-15 03:28   
Tested this with r160410-1037. I played a demo and was able to bring up the bot episode menu without restarting the client.