MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002651Zandronum[All Projects] Bugpublic2016-03-01 17:202018-09-30 21:57
ReporterDusk 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002651: SVC_SPAWNPLAYER sends the player class with two bytes
DescriptionThe CurrentPlayerClass field in player_t is a BYTE. Which means the second byte is going to waste and we should just use one.


    BYTE CurrentPlayerClass; // class # for this player instance
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-01 17:20DuskNew Issue
2016-03-01 18:52Edward-sanAssigned To => Edward-san
2016-03-01 18:52Edward-sanStatusnew => assigned
2016-03-01 19:47Edward-sanNote Added: 0014521
2016-03-01 19:47Edward-sanStatusassigned => needs review
2016-03-06 13:07cobaltStatusneeds review => needs testing
2016-03-06 13:07cobaltTarget Version => 3.0
2016-03-06 13:07cobaltDescription Updatedbug_revision_view_page.php?rev_id=8821#r8821
2016-03-06 13:07cobaltNote Added: 0014559
2016-09-18 15:46Ru5tK1ngNote Added: 0015660
2016-09-18 15:46Ru5tK1ngStatusneeds testing => closed
2016-09-18 15:46Ru5tK1ngResolutionopen => no change required
2016-09-18 15:46Ru5tK1ngTarget Version3.0 =>
2016-09-18 15:46Ru5tK1ngDescription Updatedbug_revision_view_page.php?rev_id=9515#r9515
2016-09-18 21:05Edward-sanNote Added: 0015662
2016-09-18 21:05Edward-sanStatusclosed => resolved
2016-09-18 21:05Edward-sanResolutionno change required => fixed
2016-09-18 21:05Edward-sanFixed in Version => 3.0
2016-09-18 21:05Edward-sanTarget Version => 3.0
2016-11-27 00:24Edward-sanProduct Version2.2 => 2.1
2018-09-30 21:57Blzut3Statusresolved => closed

Notes
(0014521)
Edward-san   
2016-03-01 19:47   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/76/fixed-the-spawn-player-server-command-used/diff [^]'
(0014559)
cobalt   
2016-03-06 13:07   
Issue addressed by commit 7cad9115a2b0: - Fixed: the 'spawn player' server command used 1 more byte than needed (fixes 2651).
Committed by Edoardo Prezioso [edward-san] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 2 +-
 src/sv_commands.cpp | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
(0015660)
Ru5tK1ng   
2016-09-18 15:46   
This was overwritten by:

'https://bitbucket.org/Torr_Samaho/zandronum/commits/f3a66955c77b0ced59604d73117f4e6ab95080de?at=default#chg-src/sv_commands.cpp [^]'
(0015662)
Edward-san   
2016-09-18 21:05   
The code changed, sure, but the fix is still present, here.