MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002621Zandronum[All Projects] Bugpublic2016-02-06 08:372018-09-30 22:03
Reporterswordgrunt 
Assigned ToEdward-san 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002621: Morph flag MRF_FULLHEALTH does nothing online, works fine offline.
Description(MRF_FULLHEALTH) - The morphed player's maximum health is the MaxHealth of the morphed player class (instead of hardcoded to 30).

This flag serves its purpose perfectly offline, but does not function at all online.
Steps To ReproduceLaunch the wad offline and use "give testmorpher", you will be morphed into a class with a maximum health of 60. Damage yourself below 30 health (buddha; summon rocket) and then pick up medikits or other standard health items. You will be healed to up to 60 health.

Repeat the exact same thing online and you will notice health pickups never bring you above 30 health. However, they can still be picked up.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? morphfullhp_example.wad (1,237) 2016-02-06 08:37
/tracker/file_download.php?file_id=1728&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-06 08:37swordgruntNew Issue
2016-02-06 08:37swordgruntFile Added: morphfullhp_example.wad
2016-02-07 01:09swordgruntNote Added: 0014384
2016-02-07 01:17Edward-sanNote Added: 0014385
2016-02-07 01:18Edward-sanNote Deleted: 0014385
2016-02-14 08:01swordgruntNote Added: 0014437
2016-02-14 08:01swordgruntNote Edited: 0014437bug_revision_view_page.php?bugnote_id=14437#r8725
2016-02-14 08:01swordgruntNote Edited: 0014437bug_revision_view_page.php?bugnote_id=14437#r8726
2016-04-17 21:21Edward-sanAssigned To => Edward-san
2016-04-17 21:21Edward-sanStatusnew => assigned
2016-04-17 21:31Edward-sanNote Added: 0014723
2016-04-17 21:31Edward-sanStatusassigned => needs review
2016-05-08 20:55Edward-sanNote Added: 0014840
2016-05-08 20:55Edward-sanStatusneeds review => needs testing
2016-05-11 19:51Ru5tK1ngNote Added: 0014866
2016-05-11 19:52Ru5tK1ngStatusneeds testing => resolved
2016-05-11 19:52Ru5tK1ngResolutionopen => fixed
2016-05-11 19:52Ru5tK1ngFixed in Version => 3.0
2016-05-11 19:52Ru5tK1ngTarget Version => 3.0
2018-09-30 22:03Blzut3Statusresolved => closed

Notes
(0014384)
swordgrunt   
2016-02-07 01:09   
I will provide a better example wad within a few days as I'm unable to do that now. However, an important note I forgot to mention: HealThing will heal the morphed player up to his player.maxhealth property regardless of whether or not this flag is set. Only health items seem to be affected by this.
(0014437)
swordgrunt   
2016-02-14 08:01   
Update: the Regeneration rune will restore health up the morphed class player.maxhealth property if MRF_FULLHEALTH is used, even when online, the same way HealThing works fine. So the issue seems to be restricted to Health inventory items indeed.
(0014723)
Edward-san   
2016-04-17 21:31   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/86/fixed-clients-were-not-informed-correctly/diff [^]' .
(0014840)
Edward-san   
2016-05-08 20:55   
Added with changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/29f68bb8a82d459e862ae882f2b9c2f6607c77dd [^]' .
(0014866)
Ru5tK1ng   
2016-05-11 19:51   
Tested this online and offline with r160510-1827.

I was able to bring my health back up to 60 without problem from below 30.