MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002580Zandronum[All Projects] Bugpublic2016-01-16 21:452018-09-30 21:40
ReporterIvan 
Assigned ToEdward-san 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.1 
Target Version2.2Fixed in Version2.2 
Summary0002580: SetMugshotState crashes online game
DescriptionThis thing crashes all online games whereas in singleplayer no crashes occur.

Minimal example wad:'https://www.dropbox.com/s/1r1d123v0n6adq9/grintest.pk3?dl=0 [^]'
Steps To Reproduce- Join a local server, I think any game mode will cause crash.
- As soon as you join, you crash.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? grintestdelayed.pk3 (528) 2016-01-17 17:07
/tracker/file_download.php?file_id=1710&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-16 21:45IvanNew Issue
2016-01-17 00:50ArcoSeverityminor => crash
2016-01-17 00:50ArcoStatusnew => confirmed
2016-01-17 12:04Edward-sanNote Added: 0014101
2016-01-17 12:04Edward-sanAssigned To => Edward-san
2016-01-17 12:04Edward-sanStatusconfirmed => assigned
2016-01-17 12:04Edward-sanProduct Version3.0-beta => 2.1
2016-01-17 16:42Edward-sanNote Added: 0014106
2016-01-17 16:42Edward-sanStatusassigned => needs review
2016-01-17 17:05Edward-sanNote Added: 0014107
2016-01-17 17:07Edward-sanFile Added: grintestdelayed.pk3
2016-01-17 17:08Edward-sanNote Edited: 0014107bug_revision_view_page.php?bugnote_id=14107#r8442
2016-01-17 19:13IvanNote Added: 0014110
2016-01-17 20:53cobaltStatusneeds review => needs testing
2016-01-17 20:53cobaltTarget Version => 2.2
2016-01-17 20:53cobaltDescription Updatedbug_revision_view_page.php?rev_id=8447#r8447
2016-01-17 20:53cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8449#r8449
2016-01-17 20:53cobaltNote Added: 0014118
2016-01-18 07:03Torr SamahoNote Added: 0014128
2016-01-18 07:05Torr SamahoStatusneeds testing => feedback
2016-01-24 21:15Edward-sanStatusfeedback => needs testing
2016-01-31 23:19Ru5tK1ngNote Added: 0014272
2016-01-31 23:27DuskStatusneeds testing => resolved
2016-01-31 23:27DuskFixed in Version => 2.2
2016-01-31 23:27DuskResolutionopen => fixed
2018-09-30 21:40Blzut3Statusresolved => closed

Notes
(0014101)
Edward-san   
2016-01-17 12:04   
This happens also in zandronum 2.x.
(0014106)
Edward-san   
2016-01-17 16:42   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-requests/19 [^]'
(0014107)
Edward-san   
2016-01-17 17:05   
(edited on: 2016-01-17 17:08)
Keep in mind that ZDoom multiplayer changes the mugshot to all the players, so this fix respects that. If you want to change the mugshot only for specific players, you must ask the ZDoom forum as a suggestion (verified this using the attached pk3, which changes the mugshot 4 seconds after entering the map/joining the game).
(0014110)
Ivan   
2016-01-17 19:13   
Wait, so I can't just set the mugshot of the player that's running the script? That's totally useless in this case... My use case is the following:

- Replaced all weapons with custom inventories, and I made my own pickup stuff. The player's face doesn't change when he picks these items, so that's a problem. A minor one, but still, it's a use case.
(0014118)
cobalt   
2016-01-17 20:53   
Issue addressed by commit c4b9e45e68df: - Fixed: The ACS function SetMugshotState was not handled properly online (fixes 2580).
Committed by Edoardo Prezioso [edward-san] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 11 +++++++++++
 src/network_enums.h | 1 +
 src/p_acs.cpp | 11 ++++++++++-
 src/sv_commands.cpp | 9 +++++++++
 src/sv_commands.h | 1 +
 6 files changed, 33 insertions(+), 1 deletions(-)
(0014128)
Torr Samaho   
2016-01-18 07:03   
Edward-san, please see my comment in the commit:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/7b3ea27e9f961bad5ed3c102264d6446e34d9628?at=default [^]'

If I address this, then one could have (albeit somewhat hackish) per player mug shots with client side scripts and a ConsolePlayerNumber check.
(0014272)
Ru5tK1ng   
2016-01-31 23:19   
I couldn't get the client to crash with 160131-2023 like I could with 2.x. Seems to be fixed.