MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002565Zandronum[All Projects] Suggestionpublic2016-01-06 12:572018-09-30 22:12
ReporterFused 
Assigned ToDusk 
PrioritynormalSeveritytextReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002565: Merge a connecting player's name and IP together in one line
DescriptionCurrently the "Connection ..." and "... has connected/entered the game" lines are not one line and this can cause a messy log when multiple people are connecting at the same time.
Since there is a delay between these lines you won't be able to sort players with the corresponding ID when multiple people join.
Steps To Reproduce
Additional Informationsv_main.cpp
replace line 1589-1601 with
'http://pastebin.com/raw/mYTtVT5N [^]'
TagsNo tags attached.
Relationships
related to 0002562closed Dusk Include IP with player's disconnect message 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-06 12:57FusedNew Issue
2016-01-06 16:18DuskNote Added: 0014049
2016-01-06 16:19DuskNote Edited: 0014049bug_revision_view_page.php?bugnote_id=14049#r8399
2016-01-06 18:18WaTaKiDNote Added: 0014050
2016-01-06 22:15DuskNote Added: 0014051
2016-01-06 22:15DuskRelationship addedrelated to 0002562
2016-01-06 22:41DuskNote Edited: 0014051bug_revision_view_page.php?bugnote_id=14051#r8401
2016-01-06 22:41DuskNote Edited: 0014051bug_revision_view_page.php?bugnote_id=14051#r8402
2016-01-21 22:15DuskNote Added: 0014149
2016-01-21 22:15DuskAssigned To => Dusk
2016-01-21 22:15DuskStatusnew => needs review
2016-01-22 11:22FusedNote Added: 0014155
2016-01-24 13:22cobaltStatusneeds review => needs testing
2016-01-24 13:22cobaltTarget Version => 3.0
2016-01-24 13:22cobaltDescription Updatedbug_revision_view_page.php?rev_id=8514#r8514
2016-01-24 13:22cobaltAdditional Information Updatedbug_revision_view_page.php?rev_id=8516#r8516
2016-01-24 13:22cobaltNote Added: 0014174
2016-01-24 13:25DuskPrioritylow => normal
2016-01-24 13:25DuskSeveritytweak => text
2016-01-24 13:25DuskDescription Updatedbug_revision_view_page.php?rev_id=8517#r8517
2016-01-24 13:25DuskAdditional Information Updatedbug_revision_view_page.php?rev_id=8518#r8518
2016-01-24 22:04WaTaKiDNote Added: 0014192
2016-01-24 22:06WaTaKiDStatusneeds testing => resolved
2016-01-24 22:06WaTaKiDResolutionopen => fixed
2016-01-24 22:06WaTaKiDFixed in Version => 3.0
2018-09-30 22:12Blzut3Statusresolved => closed

Notes
(0014049)
Dusk   
2016-01-06 16:18   
(edited on: 2016-01-06 16:19)
I'm not convinced that we should merge these lines since connection is asynchronous. The first message (with the IP address) logs the initial connection and the "player has connected" line logs when the player is properly in the server.

I'm getting the vibe here that this request is for external RCON tools, judging by the proposal of adding a parseable connection line in the log. In such a case a protocol feature would probably be the way to go.
(0014050)
WaTaKiD   
2016-01-06 18:18   
it does feel kind of messy when multiple players connect at the same time or after a 'map' change, resulting in multiple lines of "connect: (ip)" followed by multiple lines of "player has connected"

BE logs always gave me the confidence that i knew exactly whos ip was whos upon connecting with this "CONNECTION (name) (ip)" line, whereas with NJ logs that lacked this, i would have to wait until certain users called votes under these circumstances (albeit rarely)

however i suppose theres also a part of me that just wants a little consistency to go with:'http://zandronum.com/tracker/view.php?id=2562 [^]'

as in if the disconnect message displays their name and ip on the same line (im only assuming it does this, please correct me if im wrong), why not on connect as well?

but as i give this more thought while rambling on, if this connect line is a no go, then as long as ticket 2562 is implemented i will be satisfied
(0014051)
Dusk   
2016-01-06 22:15   
(edited on: 2016-01-06 22:41)
We could add the IP address to the connect message as well as to the disconnect one. I remain unconvinced that we should add more of these kinds of print lines when the RCON protocol should be the go-to for 3rd party server administration tools.
(0014149)
Dusk   
2016-01-21 22:15   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/56 [^]'

The OP did not respond with feedback so I chose to address WaTaKiD's concern of being able to tell whose IP is whose in logfiles.
(0014155)
Fused   
2016-01-22 11:22   
Sorry. WaTaKiD's post elaborated everything I had in mind and I had nothing to add to it.
(0014174)
cobalt   
2016-01-24 13:22   
Issue addressed by commit 76fc208d08d4: Print the IP address in the server console on connection, addresses 2565
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 2 +-
 src/sv_main.cpp | 36 ++++++++++++++++++++++++------------
 2 files changed, 25 insertions(+), 13 deletions(-)
(0014192)
WaTaKiD   
2016-01-24 22:04   
using'https://www.dropbox.com/s/mqqtgjo6j3dys3r/zandronum-3.0-r150424-1455-1749f30-windows.zip?dl=0 [^]'

the ip is printed correctly, with and without cl_startasspectator

[13:58:44] Connect (v3.0-alpha): 192.168.1.119:10667
[13:58:45] WaTaKiD (192.168.1.119:10667) has connected. (from: LAN)

[13:58:54] Connect (v3.0-alpha): 192.168.1.119:10667
[13:58:54] WaTaKiD (192.168.1.119:10667) entered the game. (from: LAN)