MantisBT - Zandronum
View Issue Details
0002549Zandronum[All Projects] Bugpublic2015-12-12 23:112018-09-30 21:49
Dusk 
Dusk 
normalminorhave not tried
closedfixed 
3.0-beta 
3.03.0 
0002549: Merge error related to friendly fire in P_DamageMobj

    // [RH] Avoid friendly fire if enabled
    if (source != NULL &&
        ((player && player != source->player) || (!player && target != source)) &&
        target->IsTeammate (source))
    {
        // [BL] Some adjustments for Skulltag
        if (player && (( teamlms || survival ) && ( MeansOfDeath == NAME_SpawnTelefrag )) == false )
            FriendlyFire = true;
        if (damage < TELEFRAG_DAMAGE)
        { // Still allow telefragging :-(
            damage = (int)((float)damage * level.teamdamage);
            if (damage <= 0)
                return -1;
        }
    }

    // [RH] Avoid friendly fire if enabled
    if (!(flags & DMG_FORCED) && source != NULL &&
        ((player && player != source->player) || (!player && target != source)) &&
        target->IsTeammate (source))
    {
        if (player)
            FriendlyFire = true;
        if (damage < TELEFRAG_DAMAGE)
        { // Still allow telefragging :-(
            damage = (int)((float)damage * level.teamdamage);
            if (damage <= 0)
                return damage;
        }
    }
No tags attached.
child of 0002172closed Torr Samaho Upgrade GZDoom base to 1.8.6 
Issue History
2015-12-12 23:11DuskNew Issue
2015-12-12 23:11DuskSummaryMerge error in P_DamageMobj => Merge error related to friendly fire in P_DamageMobj
2015-12-12 23:11DuskDescription Updatedbug_revision_view_page.php?rev_id=8314#r8314
2015-12-20 17:59DuskAssigned To => Dusk
2015-12-20 17:59DuskStatusnew => assigned
2015-12-20 18:00DuskRelationship addedparent of 0002172
2015-12-20 18:00DuskRelationship replacedchild of 0002172
2015-12-20 18:07DuskNote Added: 0014001
2015-12-20 18:07DuskStatusassigned => needs review
2016-01-03 18:35cobaltStatusneeds review => needs testing
2016-01-03 18:35cobaltTarget Version => 3.0
2016-01-03 18:35cobaltDescription Updatedbug_revision_view_page.php?rev_id=8390#r8390
2016-01-03 18:35cobaltNote Added: 0014041
2017-02-06 19:19DuskStatusneeds testing => resolved
2017-02-06 19:19DuskFixed in Version => 3.0
2017-02-06 19:19DuskResolutionopen => fixed
2018-09-30 21:49Blzut3Statusresolved => closed

Notes
(0014001)
Dusk   
2015-12-20 18:07   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/46 [^]'
(0014041)
cobalt   
2016-01-03 18:35   
Issue addressed by commit fa7878558aa5: Fixed merge error in P_DamageMobj (fixes 2549)
Committed by Teemu Piippo [Dusk] on Sunday 20 December 2015 20:04:53

Changes in files:

 src/p_interaction.cpp | 17 +----------------
 1 files changed, 1 insertions(+), 16 deletions(-)