MantisBT - Zandronum
View Issue Details
0002515Zandronum[All Projects] Bugpublic2015-11-07 06:412018-09-30 22:15
StrikerMan780 
Torr Samaho 
normalmajorsometimes
closedfixed 
3.0-beta 
3.03.0 
0002515: Strange Skybox behavior online with multiple skyboxes. (Only on some maps it seems)
Attached is a test map that gets the issue. The skybox in the map looks like this online:'http://puu.sh/lcoMN/8c876546b7.jpg [^]'

When it should look like this:'http://puu.sh/lcoOz/5406c9c967.jpg [^]'

I tried making a test map with multiple skyboxes with different tags, but I couldn't reproduce it that way. So I replaced all the textures in the attached map to make it standalone. Ignore the unknown thing errors, I didn't want to change too much lest I stop being able to reproduce the error. Thankfully it still reproduces the error.

It's worth noting, this bug does not occur in 2.0. Nor does it occur in GZDoom 1.8.6, this is a Zandronum 3.0-only bug.
Host a server with the attached map, join it. Compare it against the screenshots I posted in the description.
No tags attached.
zip HQSkyBugTest.zip (2,342,749) 2015-11-07 06:41
/tracker/file_download.php?file_id=1677&type=bug
? ticket2515.wad (33,712) 2015-11-15 22:10
/tracker/file_download.php?file_id=1687&type=bug
Issue History
2015-11-07 06:41StrikerMan780New Issue
2015-11-07 06:41StrikerMan780File Added: HQSkyBugTest.zip
2015-11-15 10:03Torr SamahoNote Added: 0013795
2015-11-15 10:04Torr SamahoAssigned To => Torr Samaho
2015-11-15 10:04Torr SamahoStatusnew => feedback
2015-11-15 18:43StrikerMan780Note Added: 0013808
2015-11-15 18:43StrikerMan780Statusfeedback => assigned
2015-11-15 18:46Torr SamahoNote Added: 0013809
2015-11-15 19:21StrikerMan780Note Added: 0013810
2015-11-15 19:25Torr SamahoNote Added: 0013811
2015-11-15 22:10WaTaKiDFile Added: ticket2515.wad
2015-11-15 22:21WaTaKiDNote Added: 0013819
2015-11-16 18:33Torr SamahoNote Added: 0013826
2015-11-28 10:39Torr SamahoNote Added: 0013891
2015-11-28 10:39Torr SamahoStatusassigned => needs testing
2015-11-29 14:08cobaltTarget Version => 3.0
2015-11-29 14:08cobaltDescription Updatedbug_revision_view_page.php?rev_id=8273#r8273
2015-11-29 14:08cobaltNote Added: 0013904
2015-11-29 16:20StrikerMan780Note Added: 0013910
2015-11-29 20:13WaTaKiDNote Added: 0013915
2015-12-05 18:13Ru5tK1ngNote Added: 0013937
2015-12-05 18:14Ru5tK1ngStatusneeds testing => resolved
2015-12-05 18:14Ru5tK1ngResolutionopen => fixed
2015-12-05 18:14Ru5tK1ngFixed in Version => 3.0
2015-12-05 18:14Ru5tK1ngDescription Updatedbug_revision_view_page.php?rev_id=8284#r8284
2018-09-30 22:15Blzut3Statusresolved => closed

Notes
(0013795)
Torr Samaho   
2015-11-15 10:03   
Can you condense this to a minimal example wad? The smaller the better. At least the console shouldn't be flooded with errors.
(0013808)
StrikerMan780   
2015-11-15 18:43   
I cannot. I already tried, three times.
(0013809)
Torr Samaho   
2015-11-15 18:46   
Please elaborate. What's stopping you? Does the error go away if you reduce the size of the map?
(0013810)
StrikerMan780   
2015-11-15 19:21   
I tried reproducing the same environment in a test map, but it didn't produce the expected result. Some combination of conditions that I cannot narrow down results in this bug.
(0013811)
Torr Samaho   
2015-11-15 19:25   
Did you try removing things and sectors from the existing map to make it smaller?
(0013819)
WaTaKiD   
2015-11-15 22:21   
i have attached a minimal example wad (couple rooms taken and modified from striker's map) that can reproduce the issue online and behaves normally offline

it seems that its caused by the fix for this ticket:'http://zandronum.com/tracker/view.php?id=2350 [^]'

excerpt from irc:
<Torr_Samaho> If it really only happens on huge maps, it could be a problem similar to'https://zandronum.com/tracker/view.php?id=2520 [^]'
<WaTaKiD> actually, i was tinkering with that idea, i was removing stuff and making the map smaller and whatnot, along with using the latest changeset, no change in the sky
<WaTaKiD> however, i just tried a build from before ticket 2350's fix, and the sky appears as it should
<WaTaKiD> then i tried a build just after that fix, and the sky is doing its issue
(0013826)
Torr Samaho   
2015-11-16 18:33   
Thanks, that kind of example map was exactly what I was looking for!
(0013891)
Torr Samaho   
2015-11-28 10:39   
Hopefully fixed now.
(0013904)
cobalt   
2015-11-29 14:08   
Issue addressed by commit 6f5504681d42: Fixed: Clients possibly used a SkyViewpoint with TID != 0 as default sky box (fixes 2515).
Committed by Benjamin Berkels [Torr Samaho] on Saturday 28 November 2015 11:38:47

Changes in files:

 src/cl_main.cpp | 14 ++++++++++++++
 src/g_shared/a_skies.cpp | 4 +++-
 src/network_enums.h | 1 +
 src/sv_commands.cpp | 8 ++++++++
 src/sv_commands.h | 1 +
 src/sv_main.cpp | 3 +++
 6 files changed, 30 insertions(+), 1 deletions(-)

(0013910)
StrikerMan780   
2015-11-29 16:20   
Seems to be working now.
(0013915)
WaTaKiD   
2015-11-29 20:13   
using'https://www.dropbox.com/s/obffhny5vh06g6e/zandronum-3.0-r150809-0703-83ceae7-windows.zip?dl=0 [^]'

and ticket2515.wad, it seems the issue is fixed

also just in case, i tested portaltest.wad from ticket 2350, and that issue remains resolved
(0013937)
Ru5tK1ng   
2015-12-05 18:13   
Both worked for me as as well with the above build.