MantisBT - Zandronum
View Issue Details
0002504Zandronum[All Projects] Bugpublic2015-10-26 03:082018-09-30 22:12
StrikerMan780 
Torr Samaho 
normalmajoralways
closedfixed 
3.0-beta 
3.03.0 
0002504: SkyPicker with 0 for TID doesn't use default sky.
Setting the tag for SkyPicker to 0 is supposed to make the sky for that sector use the map default, and not use any SkyBox things. See:'http://zdoom.org/wiki/Classes:SkyPicker [^]'

Unfortunately, in 3.0, this broke. Now, it uses the first skybox thing with an ID of 0.
Make a map, give it a skybox with a skybox viewpoint of TID 0.

Make one sector with F_SKY1 as the ceiling, no special tags or skypicker objects in it. This will use the skybox as intended.

Now, make another sector, with F_SKY1 as the ceiling, and a Skybox Picker in it with the first Arg set to 0. Make sure it is set to apply to the ceiling.

The 2nd sky sector will use the skybox, when it shouldn't.
No tags attached.
? SkyTest.wad (6,172) 2015-11-01 13:58
/tracker/file_download.php?file_id=1674&type=bug
Issue History
2015-10-26 03:08StrikerMan780New Issue
2015-10-26 05:28StrikerMan780Note Added: 0013689
2015-11-01 13:58Torr SamahoFile Added: SkyTest.wad
2015-11-01 14:04Torr SamahoNote Added: 0013717
2015-11-01 14:04Torr SamahoAssigned To => Torr Samaho
2015-11-01 14:04Torr SamahoStatusnew => feedback
2015-11-01 19:28StrikerMan780Note Added: 0013728
2015-11-01 19:28StrikerMan780Statusfeedback => assigned
2015-11-01 19:36WaTaKiDNote Added: 0013729
2015-11-04 22:43StrikerMan780Note Added: 0013742
2015-11-07 16:52Torr SamahoNote Added: 0013747
2015-11-07 16:52Torr SamahoStatusassigned => feedback
2015-11-08 00:55StrikerMan780Note Added: 0013749
2015-11-08 00:55StrikerMan780Statusfeedback => assigned
2015-11-08 11:10Torr SamahoNote Added: 0013752
2015-11-08 11:10Torr SamahoStatusassigned => feedback
2015-11-25 13:09StrikerMan780Note Added: 0013878
2015-11-25 13:09StrikerMan780Statusfeedback => assigned
2015-11-25 20:32Torr SamahoNote Added: 0013879
2015-11-28 09:52Torr SamahoNote Added: 0013890
2015-11-28 09:52Torr SamahoStatusassigned => needs testing
2015-11-29 20:16WaTaKiDNote Added: 0013916
2016-01-31 23:51Ru5tK1ngStatusneeds testing => resolved
2016-01-31 23:51Ru5tK1ngResolutionopen => fixed
2016-01-31 23:51Ru5tK1ngFixed in Version => 3.0
2016-01-31 23:51Ru5tK1ngTarget Version => 3.0
2018-09-30 22:12Blzut3Statusresolved => closed

Notes
(0013689)
StrikerMan780   
2015-10-26 05:28   
Test wad:'http://shadowmavericks.com/files/Doom/SkyTest.wad [^]'

In 2.0, both skies are different. (Intended behavior).

In 3.0, both skies are the same. (Incorrect.)
(0013717)
Torr Samaho   
2015-11-01 14:04   
3.0 seems to work exactly like GZDoom 1.8.6 and the latest GZDoom git version, so it's (G)ZDoom bug. Can you confirm this?
(0013728)
StrikerMan780   
2015-11-01 19:28   
Where can I obtain a copy of 1.8.6?
(0013729)
WaTaKiD   
2015-11-01 19:36   
'http://forum.drdteam.org/viewtopic.php?f=23&t=6302 [^]'
(0013742)
StrikerMan780   
2015-11-04 22:43   
GZDoom 1.8.6 = Broken
GZDoom 1.8.0 = Broken
GZDoom 1.7.1 = Works
(0013747)
Torr Samaho   
2015-11-07 16:52   
As I said above, for me even the latest GZDoom git version is affected. If this is the same for you, please report the bug at the ZDoom or GZDoom forum (depending on whether this also happens in ZDoom).
(0013749)
StrikerMan780   
2015-11-08 00:55   
'http://forum.zdoom.org/viewtopic.php?f=2&t=49899 [^]'
(0013752)
Torr Samaho   
2015-11-08 11:10   
Thanks! Please leave a note when ZDoom has a fix for this.
(0013878)
StrikerMan780   
2015-11-25 13:09   
ZDoom fixed it.'http://forum.zdoom.org/viewtopic.php?f=7&t=49899&sid=89e6652590526580d48e90fbbda90362&p=869347#p869347 [^]'
(0013879)
Torr Samaho   
2015-11-25 20:32   
I backported the fixes from the GZDoom repo, but looks like the GCC fix for the fix is not in the GZDoom repo yet.
(0013890)
Torr Samaho   
2015-11-28 09:52   
The GCC fix for the fix is now also in the GZDoom repo and I backported it.
(0013916)
WaTaKiD   
2015-11-29 20:16   
using'https://www.dropbox.com/s/obffhny5vh06g6e/zandronum-3.0-r150809-0703-83ceae7-windows.zip?dl=0 [^]'

and skytest.wad, it seems the issue is fixed both offline and online