MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002494Zandronum[All Projects] Bugpublic2015-10-16 15:442018-09-30 22:02
Reportercruduxy 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002494: A_SetPitch is unfriendly to spectators
DescriptionA_SetPitch works correctly for the player but anyone f12ing the player will notice the screen repeatedly centering then snapping back to the player's view. This is extremely annoying to the spectators.
Steps To ReproduceHave any player f12 another that is using a weapon with a_setpitch somewhere. Preferably a chaingun. The player being spectated then changes view pitch (look up or down) while still shooting. The spectator enjoys the experience of a crazy rock fan.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? a_setpitch.wad (605) 2015-11-03 09:02
/tracker/file_download.php?file_id=1676&type=bug
? a_setpitch2.wad (583) 2015-11-07 17:52
/tracker/file_download.php?file_id=1678&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-10-16 15:44cruduxyNew Issue
2015-11-01 15:23Torr SamahoNote Added: 0013721
2015-11-01 15:23Torr SamahoStatusnew => feedback
2015-11-03 07:15DaedalusNote Added: 0013740
2015-11-03 09:02DuskFile Added: a_setpitch.wad
2015-11-06 18:34WaTaKiDNote Added: 0013745
2015-11-07 11:13DaedalusNote Added: 0013746
2015-11-07 11:20DaedalusNote Edited: 0013746bug_revision_view_page.php?bugnote_id=13746#r8196
2015-11-07 17:52WaTaKiDFile Added: a_setpitch2.wad
2015-11-07 17:58WaTaKiDNote Added: 0013748
2016-05-01 22:24WaTaKiDNote Added: 0014790
2016-05-17 05:56Torr SamahoTarget Version => 3.0
2016-05-17 06:21Torr SamahoNote Added: 0014940
2016-05-17 06:21Torr SamahoAssigned To => Torr Samaho
2016-05-17 06:21Torr SamahoStatusfeedback => needs testing
2016-05-17 07:32WaTaKiDNote Added: 0014941
2016-05-21 18:27WaTaKiDNote Added: 0014965
2016-05-24 00:48Ru5tK1ngNote Added: 0014976
2016-05-24 00:50Ru5tK1ngStatusneeds testing => resolved
2016-05-24 00:50Ru5tK1ngResolutionopen => fixed
2016-05-24 00:50Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:02Blzut3Statusresolved => closed

Notes
(0013721)
Torr Samaho   
2015-11-01 15:23   
Please supply a minimal example wad.
(0013740)
Daedalus   
2015-11-03 07:15   
^'http://www.best-ever.org/download?file=a_setpitch.wad [^]'

Follow the steps above using either the Shotgun or the Chaingun.
(0013745)
WaTaKiD   
2015-11-06 18:34   
while i have not tested this example wad with another person, i will point out that holding fire with the chaingun online results in it firing straight ahead as if i have freelook disabled, while doing so with the shotgun acts normal and the pellets go where im actually aiming
(0013746)
Daedalus   
2015-11-07 11:13   
(edited on: 2015-11-07 11:20)
^ That's an overlook on my behalf, the Shotgun still provides the example to this ticket though.

An easy way to test this without another player (though you likely knew this), just connect twice to the same server, have one hold fire and press the chat key so you will continuously fire then alt-tab to the other and F12.

Fixed the Chaingun example here if needed:'http://www.best-ever.org/download?file=a_setpitch2.wad [^]'
(0013748)
WaTaKiD   
2015-11-07 17:58   
first: i can indeed confirm this ticket's issue with both weapons from both example wads, using Daedalus' method (its been so long ive forgotten about that heh)

second: the issue i mentioned about the chaingun shooting forward with the first example wad is actually something i came across when i tried playing'http://forum.zdoom.org/viewtopic.php?f=19&t=48074 [^]' online, where almost every weapon and alt fire ignore my freelook and shoot straight ahead, and the "crazy rock fan experience™" can be reproduced there as well

so i actually feel the first example wad would be the best to work with here, unless this other side effect is deemed a separate issue for a separate ticket
(0014790)
WaTaKiD   
2016-05-01 22:24   
ive found this commit to be the culprit:'https://bitbucket.org/Torr_Samaho/zandronum/commits/bf582920f6d769e5aff71b8be86df2db283230ec [^]'

also:

<WaTaKiD>so basically its like this
<WaTaKiD>multiple a_setpitch issues have arisen due to'https://bitbucket.org/Torr_Samaho/zandronum/commits/bf582920f6d769e5aff71b8be86df2db283230ec [^]'
<WaTaKiD>however, only 1 of them was noticed and reported way back when:'http://zandronum.com/tracker/view.php?id=2229 [^]'
<WaTaKiD>and this is the fix for that 1 issue:'https://bitbucket.org/Torr_Samaho/zandronum/commits/679f73f3ff7bf85070c77c7ad9600ee8748065d3 [^]'
<WaTaKiD>and issues mentioned here are wut went unnoticed for some time:'http://zandronum.com/tracker/view.php?id=2494 [^]'
(0014940)
Torr Samaho   
2016-05-17 06:21   
Can you check whether this works any better?
(0014941)
WaTaKiD   
2016-05-17 07:32   
ZandroDev3.0-PitchFixTest does indeed seem to fix the issue of not only the spectating player's view being constantly centered, but also the issue i mentioned about the chaingun shooting straight ahead

of all the wads i tested (the provided example wads, hxrtc, and project brutality, to name a few), the a_setpitch issues seem fixed in them all
(0014965)
WaTaKiD   
2016-05-21 18:27   
fix added to 3.0 with:'https://bitbucket.org/Torr_Samaho/zandronum/commits/4e9e5759d32fbef5d53443fbffd594b6bee42bd7 [^]'
(0014976)
Ru5tK1ng   
2016-05-24 00:48   
Tested this with r160519-2047 online and didn't see any head banging as a spectator. The bobbing with the CG was consistent between player and spectator.