MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002480Doomseeker[All Projects] Bugpublic2015-10-06 16:292018-09-29 14:37
ReporterWaTaKiD 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version 
Target Version1.1Fixed in Version1.1 
Summary0002480: doomseeker adds unnecessary "" to blank commands
Descriptionsorry im terrible at naming these things, anyways:

when hosting a zan 3.0 server and for example leaving the MOTD field blank, rcon sv_motd will show """" instead of "" like in 2.1.2

so upon joining the server the motd of "" will display

so far ive found doomseeker will do this for: sv_hostname and everything under the "misc." tab, if anything else is affected then im unaware of it
Steps To Reproducehost a zan 3.0 server with doomseeker's MOTD field blank
sv_motd in rcon, notice it displays """"
connect to the server, notice the motd displays ""

repeat with a zan 2.1.2 server, notice this doesnt happen
Additional Informationat first i thought this was a zan issue, so if its of any help, here is the commit that introduced this behavior:'https://bitbucket.org/Torr_Samaho/zandronum/commits/0229459693ec6aa189cc0d5cb0158899b1db9f49 [^]'
TagsNo tags attached.
Relationships
related to 0002482closed Torr Samaho Zandronum How can I blank a CVAR from command line? 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-06 16:29WaTaKiDNew Issue
2015-10-07 13:37ZalewaNote Added: 0013623
2015-10-07 13:46ZalewaRelationship addedrelated to 0002482
2017-01-15 13:10ZalewaNote Added: 0016644
2017-01-15 13:10ZalewaAssigned To => Zalewa
2017-01-15 13:10ZalewaStatusnew => needs review
2017-01-15 13:11ZalewaNote Edited: 0016644bug_revision_view_page.php?bugnote_id=16644#r10052
2017-02-06 19:56ZalewaNote Added: 0016792
2017-02-06 19:56ZalewaStatusneeds review => needs testing
2017-07-03 17:37ZalewaStatusneeds testing => resolved
2017-07-03 17:37ZalewaFixed in Version => 1.1
2017-07-03 17:37ZalewaResolutionopen => fixed
2018-09-29 14:24WubTheCaptainStatusresolved => closed
2018-09-29 14:37WubTheCaptainTarget Version => 1.1

Notes
(0013623)
Zalewa   
2015-10-07 13:37   
Fix pointed out here is the root cause for the issue:
'http://forum.zdoom.org/viewtopic.php?f=7&t=33763 [^]'

To be precise, the game behavior is 100% correct. However, I have no friggin idea how to clear the value of a CVAR now.

Passing a blank string: `+sv_motd ""` won't do. The game will load sv_motd from config.

Passing \0 in the string sort of works: `+sv_motd "\0"`. It was working quite nicely until I discovered that it crashes connecting clients:
'http://zandronum.com/tracker/view.php?id=2462 [^]'

Right now I have no idea how to make the game interpret a blank field in the way the user would expect to. I want a blank field to blank the in game variable too, but the game is highly uncooperative here.
(0016644)
Zalewa   
2017-01-15 13:10   
(edited on: 2017-01-15 13:11)
Thanks to this GZDoom/Zandronum fix I was able to handle both Zandronum 2 and Zandronum 3 in Doomseeker properly. User will need to take care to pick the proper game version in the "Zandronum" tab when creating new game.

Doomseeker commit:
'https://bitbucket.org/Doomseeker/doomseeker/commits/73b491b5b290cb7bf80727856a8779fdf94e4d32 [^]'

I will wait for the next Zandronum beta before marking this as "needs testing".
(0016792)
Zalewa   
2017-02-06 19:56   
Can be tested on beta update channel. This will only work properly with Zandronum 3.0-alpha-170205-2117 or later. Zandronum version must be set to "Zandronum 3 (beta)" in the "Create Game" box.

'https://zandronum.com/forum/viewtopic.php?p=103736 [^]'