MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002479Zandronum[All Projects] Suggestionpublic2015-10-05 15:332018-09-30 22:15
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0002479: Make sv_nodrop a dmflag
DescriptionIt looks like a dmflag, it acts like one but isn't actually one. IMO we should change this, put it into zadmflags and put the cvar into gameplay options.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0002484resolved  Server setup menu 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-05 15:33DuskNew Issue
2015-10-05 17:05Torr SamahoNote Added: 0013609
2015-10-09 07:19DuskAssigned To => Dusk
2015-10-09 07:19DuskStatusnew => assigned
2015-10-09 07:22DuskRelationship addedchild of 0002484
2015-10-09 07:41DuskNote Added: 0013632
2015-10-09 07:41DuskStatusassigned => needs review
2015-10-09 07:41DuskNote Edited: 0013632bug_revision_view_page.php?bugnote_id=13632#r8114
2015-10-10 09:10Torr SamahoStatusneeds review => needs testing
2015-10-10 10:40cobaltTarget Version => 3.0
2015-10-10 10:40cobaltNote Added: 0013640
2015-12-06 21:22Ru5tK1ngNote Added: 0013943
2015-12-06 21:23Ru5tK1ngStatusneeds testing => resolved
2015-12-06 21:23Ru5tK1ngResolutionopen => fixed
2015-12-06 21:23Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:15Blzut3Statusresolved => closed

Notes
(0013609)
Torr Samaho   
2015-10-05 17:05   
The reason why sv_nodrop is not a dmflag is that its implementation is purely server-side, so clients don't need to know about it. I wouldn't mind if it's transformed to a dmflag though. So feel free to change this.
(0013632)
Dusk   
2015-10-09 07:41   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/30 [^]'

I added client-side checking while at it so no bw is used if dropping is disabled
(0013640)
cobalt   
2015-10-10 10:40   
Issue addressed by commit bbae6882de3c: Made sv_nodrop a dmflag (addresses 2479)
Committed by Teemu Piippo [Dusk] on Friday 09 October 2015 10:39:14

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/cl_commands.cpp | 7 +++++++
 src/d_main.cpp | 1 +
 src/doomdef.h | 3 +++
 src/sv_main.cpp | 6 +-----
 wadsrc/static/menudef.txt | 3 ++-
 6 files changed, 15 insertions(+), 6 deletions(-)
(0013943)
Ru5tK1ng   
2015-12-06 21:22   
Checked out with:'https://www.dropbox.com/s/obffhny5vh06g6e/zandronum-3.0-r150809-0703-83ceae7-windows.zip?dl=0 [^]'

I was able to toggle nodrop from the console and gameplay options without issue.