MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002462Zandronum[All Projects] Bugpublic2015-09-18 17:022018-09-30 21:39
ReporterZalewa 
Assigned ToTorr Samaho 
PrioritynormalSeveritycrashReproducibilityrandom
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version2.2Fixed in Version2.2 
Summary0002462: Joining a server with MOTD set to \0 will randomly crash the client.
DescriptionJoining a server with MOTD set to \0 will randomly crash the client.
Unfortunately I'm only able to reproduce it by running the game from a modified version of Doomseeker that passes "+sv_motd" \0 argument pair when MOTD is empty. I have attached a crash report, though.
Steps To Reproduce
Additional InformationBuild: 3.0-alpha-r150831-1814
TagsNo tags attached.
Relationships
Attached Fileszip CrashReport-nullmotd.zip (23,728) 2015-09-18 17:02
https://zandronum.com/tracker/file_download.php?file_id=1655&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-09-18 17:02ZalewaNew Issue
2015-09-18 17:02ZalewaFile Added: CrashReport-nullmotd.zip
2015-10-04 13:32Torr SamahoNote Added: 0013588
2015-10-04 13:35Torr SamahoAssigned To => Torr Samaho
2015-10-04 13:35Torr SamahoStatusnew => needs testing
2015-10-04 13:40cobaltTarget Version => 2.2
2015-10-04 13:40cobaltDescription Updatedbug_revision_view_page.php?rev_id=8091#r8091
2015-10-04 13:40cobaltNote Added: 0013589
2015-12-10 04:33CombinebobntNote Added: 0013956
2015-12-10 04:53CombinebobntNote View State: 0013956: private
2015-12-14 03:33Ru5tK1ngStatusneeds testing => resolved
2015-12-14 03:33Ru5tK1ngResolutionopen => fixed
2015-12-14 03:33Ru5tK1ngFixed in Version => 2.2
2015-12-14 03:33Ru5tK1ngDescription Updatedbug_revision_view_page.php?rev_id=8327#r8327
2015-12-19 11:32ZalewaNote View State: 0013956: public
2016-11-20 21:32Edward-sanProduct Version3.0 => 3.0-beta
2018-09-30 21:39Blzut3Statusresolved => closed

Notes
(0013588)
Torr Samaho   
2015-10-04 13:32   
The crash log doesn't show any relation to the MOTD string and I couldn't reproduce the crash. Nevertheless, I added some string cleaning on the client, so "\0" as MOTD should cause no problems anymore.
(0013589)
cobalt   
2015-10-04 13:40   
Issue addressed by commit 7a2836d4d328: Fixed display problems of the MOTD on the clients when the server sent an invalid string (addresses 2462).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 04 October 2015 15:30:48

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 2 ++
 src/v_text.cpp | 6 ++++++
 3 files changed, 9 insertions(+), 0 deletions(-)
(0013956)
Combinebobnt   
2015-12-10 04:33   
Tested with r151206-2117 on a local server, tried setting sv_motd to "\0" with the server and through RCON and nothing happened on reconnect.