MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002446Zandronum[All Projects] Bugpublic2015-09-07 17:542018-09-30 21:51
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0002446: Urban Brawl: Dead of Winter is crashing when you look up on the sky at end of the road under OpenGL on Winter1 map
DescriptionUrban Brawl: Dead of Winter is crashing when you look up on the sky at end of the road under OpenGL on Winter1 map

Doesn't crash under software render.
Doesn't crash under GZdoom 1.8.x - 2.0.05

Crash under ANY Zandronum 2.x - 3.x OGL mode.
Steps To Reproduce1)

Download WADs

'http://action.mancubus.net/files/action2.zip [^]'
'http://action.mancubus.net/files/ad2dow.zip [^]'

2)

zandronum.exe -file action2.zip ad2dow.zip +map winter1
Press space to skip cutscene.

Walk to the end of the road, look up on the sky, CRASH.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-07 17:54ZalewaNew Issue
2015-09-07 18:05ZalewaSeverityminor => crash
2015-09-11 18:59DuskStatusnew => acknowledged
2015-09-11 18:59DuskStatusacknowledged => assigned
2015-09-11 18:59DuskAssigned To => Dusk
2015-09-11 18:59DuskStatusassigned => acknowledged
2016-03-21 18:52throwawayNote Added: 0014601
2016-03-21 18:53throwawayNote Edited: 0014601bug_revision_view_page.php?bugnote_id=14601#r8842
2016-12-18 21:50ZalewaNote Added: 0016533
2016-12-18 21:50ZalewaAssigned ToDusk => Zalewa
2016-12-18 21:50ZalewaStatusacknowledged => needs review
2016-12-18 23:03ZalewaNote Edited: 0016533bug_revision_view_page.php?bugnote_id=16533#r9991
2016-12-18 23:14Edward-sanNote Added: 0016536
2016-12-22 19:44Torr SamahoNote Added: 0016540
2016-12-22 19:44Torr SamahoStatusneeds review => needs testing
2016-12-22 19:44Torr SamahoTarget Version => 3.0
2017-01-04 03:13Ru5tK1ngNote Added: 0016597
2017-01-04 03:13Ru5tK1ngStatusneeds testing => resolved
2017-01-04 03:13Ru5tK1ngResolutionopen => fixed
2017-01-04 03:13Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:51Blzut3Statusresolved => closed

Notes
(0014601)
throwaway   
2016-03-21 18:52   
(edited on: 2016-03-21 18:53)
Does not happen on Linux. FPS is halved, but no crash.
(0016533)
Zalewa   
2016-12-18 21:50   
(edited on: 2016-12-18 23:03)
Fixed in this pull request:
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/180/fix-urban-brawl-dead-of-winter-opengl/ [^]'

For the sake of completness I'll quote here what I wrote in the PR as a comment:
Quote

I transplanted code from current GZDoom's origin/master HEAD (commit b709db3fd38b89211577193983be3dbf61fa56b0). GZDoom uses the unit-global "temporary" variable (fakesec) to reduce the memory consumed by the stack instead of a stack variable (duh).

I also measured the depth of the recurrency and it goes up to about 970 levels when you follow instructions from 2446 in both Zandronum and GZDoom. It's worth noting that GZDoom will survive this depth even if you reintroduce the sector_t fake stack variable because the sizeof of sector_t in GZDoom is about a half of what's currently in Zandronum (GZDoom - about 550 bytes, Zandronum - about 1100 bytes)
(0016536)
Edward-san   
2016-12-18 23:14   
Just to note that the gzdoom fixed this problem with this changeset:'https://bitbucket.org/Torr_Samaho/zandronum-zdoom-sync/commits/694b4bfdd7cb6283ac8cf808dc2eee98dfdb1ab7 [^]' . This was reported in gzdoom forum, here to fix a related problem.
(0016540)
Torr Samaho   
2016-12-22 19:44   
The backport is in our main repo now.
(0016597)
Ru5tK1ng   
2017-01-04 03:13   
With the fix, I wasn't able to crash while in ogl.