MantisBT - Zandronum
View Issue Details
0002432Zandronum[All Projects] Bugpublic2015-09-03 20:532018-09-30 21:49
Dusk 
Dusk 
lowtextN/A
closedfixed 
3.0-beta 
3.03.0 
0002432: Clang warnings in bots.cpp
/home/crimson/dev/zandronum-sandbox/src/bots.cpp:1722:34: warning: address of array 'g_BotInfo[this->m_ulBotInfoIdx]->szSkinName' will
      always evaluate to 'true' [-Wpointer-bool-conversion]
        if ( g_BotInfo[m_ulBotInfoIdx]->szSkinName )
        ~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/home/crimson/dev/zandronum-sandbox/src/bots.cpp:1742:34: warning: address of array 'g_BotInfo[this->m_ulBotInfoIdx]->szClassName'
      will always evaluate to 'true' [-Wpointer-bool-conversion]
        if ( g_BotInfo[m_ulBotInfoIdx]->szClassName )
        ~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
No tags attached.
Issue History
2015-09-03 20:53DuskNew Issue
2015-09-03 20:53DuskProduct Version => 3.0-beta
2015-09-03 20:54DuskDescription Updatedbug_revision_view_page.php?rev_id=8005#r8005
2015-09-03 20:54DuskDescription Updatedbug_revision_view_page.php?rev_id=8006#r8006
2015-09-04 14:51DuskNote Added: 0013393
2015-09-04 14:51DuskAssigned To => Dusk
2015-09-04 14:51DuskStatusnew => needs review
2015-09-05 09:35cobaltStatusneeds review => needs testing
2015-09-05 09:35cobaltTarget Version => 3.0
2015-09-05 09:35cobaltDescription Updatedbug_revision_view_page.php?rev_id=8024#r8024
2015-09-05 09:35cobaltNote Added: 0013411
2017-02-07 18:07DuskStatusneeds testing => resolved
2017-02-07 18:07DuskFixed in Version => 3.0
2017-02-07 18:07DuskResolutionopen => fixed
2018-09-30 21:49Blzut3Statusresolved => closed

Notes
(0013393)
Dusk   
2015-09-04 14:51   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/16 [^]'
(0013411)
cobalt   
2015-09-05 09:35   
Issue addressed by commit 815c49a3cd98: Remove tautological checks pointed out by clang (fixes 2432)
Committed by Teemu Piippo [Dusk] on Friday 04 September 2015 17:50:29

Changes in files:

 src/bots.cpp | 49 +++++++++++++++++++++----------------------------
 1 files changed, 21 insertions(+), 28 deletions(-)