MantisBT - Zandronum
View Issue Details
0002384Zandronum[All Projects] Bugpublic2015-08-09 13:202018-09-30 22:17
unknownna 
Edward-san 
lowtextalways
closedfixed 
2.1 
2.23.0 
0002384: "spectating - waiting to respawn" says "spectating - space to join" when coop spying
See attached screenshot.
No tags attached.
related to 0002391closed Edward-san "1 ally left" message turns into "last player alive" during death state even when more players are alive 
png Screenshot_Doom_20150809_151625.png (156,357) 2015-08-09 13:20
/tracker/file_download.php?file_id=1608&type=bug
png
Issue History
2015-08-09 13:20unknownnaNew Issue
2015-08-09 13:20unknownnaFile Added: Screenshot_Doom_20150809_151625.png
2015-08-09 13:20unknownnaStatusnew => confirmed
2015-08-09 14:07Edward-sanNote Added: 0013155
2015-08-09 14:07Edward-sanAssigned To => Edward-san
2015-08-09 14:07Edward-sanStatusconfirmed => feedback
2015-08-09 16:55unknownnaNote Added: 0013159
2015-08-09 16:55unknownnaStatusfeedback => assigned
2015-08-09 17:10unknownnaRelationship addedrelated to 0002391
2015-08-09 19:35unknownnaNote Edited: 0013159bug_revision_view_page.php?bugnote_id=13159#r7858
2015-08-09 19:42unknownnaNote Edited: 0013159bug_revision_view_page.php?bugnote_id=13159#r7859
2015-08-22 11:22Edward-sanNote Added: 0013244
2015-08-22 11:22Edward-sanStatusassigned => needs review
2015-10-04 09:35cobaltStatusneeds review => needs testing
2015-10-04 09:35cobaltTarget Version => 2.2
2015-10-04 09:35cobaltNote Added: 0013577
2015-10-09 23:54Ru5tK1ngNote Added: 0013634
2015-10-09 23:57Ru5tK1ngStatusneeds testing => resolved
2015-10-09 23:57Ru5tK1ngResolutionopen => fixed
2015-10-09 23:57Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:17Blzut3Statusresolved => closed

Notes
(0013155)
Edward-san   
2015-08-09 14:07   
'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/7056ee627624ca604da3619986bfb22b32e7549b [^]' fixes the inconsistent message, but there's a text misalignment inconsistency when coop-spying the player.

I have no idea of why, though. I did some debugging, and g_BottomString has the following string without and with coop-spying:


(gdb) p g_BottomString
$2 = {Chars = 0x271047c "\n\034dSPECTATING - WAITING TO RESPAWN",
  static NullString = {Len = 0, AllocLen = 2, RefCount = 57354,
    Nothing = "\000"}}



(gdb) p g_BottomString
$1 = {
  Chars = 0x2674efc "\034gFOLLOWING - player\034g - \034gLAST PLAYER ALIVE\n\034dSPECTATING - WAITING TO RESPAWN", static NullString = {Len = 0, AllocLen = 2,
    RefCount = 57104, Nothing = "\000"}}


I don't see anything odd in that.
(0013159)
unknownna   
2015-08-09 16:55   
(edited on: 2015-08-09 19:42)
That fix took care of it (thanks for the build, WaTaKiD!).

Quote from Edward-san
[...] but there's a text misalignment inconsistency when coop-spying the player.

The misaligned text was also there before. Interestingly, if the message displays "waiting to play - 1st in line", there's no misaligned text present. And for some reason the text isn't misaligned in survival invasion. Actually, sometimes it's misaligned and other times it's not. It seems to depend on how long the player name is.

(0013244)
Edward-san   
2015-08-22 11:22   
I think I can't do much for the misalignment, so I'll leave it as is, with the mentioned patch ready for the text fix.
(0013577)
cobalt   
2015-10-04 09:35   
Issue addressed by commit 33b7d035acaa: - Fixed inconsistent 'spectating' text draw when a dead spectator coop spies another player (addresses 2384).
Committed by Edoardo Prezioso [edward-san] on Sunday 09 August 2015 16:01:44

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/scoreboard.cpp | 2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

(0013634)
Ru5tK1ng   
2015-10-09 23:54   
Tested out with latests 3.0 beta and the 'waiting to respawn/play' strings seemed to work properly.