MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002345Zandronum[All Projects] Suggestionpublic2015-07-12 15:122021-11-29 13:43
ReporterHypnotoad 
Assigned ToDrinkyBird 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version 
Target Version3.1Fixed in Version3.1 
Summary0002345: Callvote Nextmap
DescriptionThis would be enormously helpful for servers that have large maplists with sv_randommaprotation on. Often times the players want to skip a map, but don't want to go out of sequence of the randomly selected map-rotation (and are unaware what the next map in the sequence will be), or simply cannot agree which map to go to next meaning a vote to that map will not necessarily be successful even though they all definitely want to skip the map they are currently playing.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0001420resolved Dusk Custom vote definitions, aka VOTEINFO 
Attached Filespatch 2345.patch (16,892) 2021-11-02 22:25
/tracker/file_download.php?file_id=2674&type=bug
patch 2345_v2.patch (17,606) 2021-11-03 01:29
/tracker/file_download.php?file_id=2675&type=bug
patch 2345_v3.patch (17,569) 2021-11-03 01:30
/tracker/file_download.php?file_id=2676&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-07-12 15:12HypnotoadNew Issue
2015-07-15 15:00DuskNote Added: 0012944
2015-07-15 15:00DuskRelationship addedchild of 0001420
2015-07-15 22:28DuskAssigned To => Dusk
2015-07-15 22:28DuskStatusnew => needs testing
2016-06-08 15:43KondaNote Added: 0015058
2021-11-02 22:25DrinkyBirdNote Added: 0021817
2021-11-02 22:25DrinkyBirdFile Added: 2345.patch
2021-11-02 22:25DrinkyBirdAssigned ToDusk =>
2021-11-02 22:26DrinkyBirdStatusneeds testing => needs review
2021-11-02 22:43DrinkyBirdNote Edited: 0021817bug_revision_view_page.php?bugnote_id=21817#r13378
2021-11-02 22:47DrinkyBirdNote Edited: 0021817bug_revision_view_page.php?bugnote_id=21817#r13379
2021-11-03 00:27DrinkyBirdNote Edited: 0021817bug_revision_view_page.php?bugnote_id=21817#r13380
2021-11-03 01:29DrinkyBirdFile Added: 2345_v2.patch
2021-11-03 01:30DrinkyBirdNote Added: 0021818
2021-11-03 01:30DrinkyBirdNote Edited: 0021818bug_revision_view_page.php?bugnote_id=21818#r13382
2021-11-03 01:30DrinkyBirdFile Added: 2345_v3.patch
2021-11-07 20:26DrinkyBirdStatusneeds review => needs testing
2021-11-07 20:26DrinkyBirdFixed in Version => 3.1
2021-11-07 20:26DrinkyBirdTarget Version => 3.1
2021-11-07 20:26DrinkyBirdNote Added: 0021824
2021-11-29 13:43DrinkyBirdStatusneeds testing => resolved
2021-11-29 13:43DrinkyBirdResolutionopen => fixed
2021-11-29 13:43DrinkyBirdAssigned To => DrinkyBird

Notes
(0012944)
Dusk   
2015-07-15 15:00   
Added in the votedef branch:'http://bit.ly/1fJcyIy [^]'
(0015058)
Konda   
2016-06-08 15:43   
I tested this using WaTaKiD's windows build that was provided here:'https://zandronum.com/tracker/view.php?id=1420#c12949 [^]'

Couldn't test this offline, so I had to make a server using Doomseeker. It works fine if the server has no map rotation, but as soon as I try to host with a map rotation the server crashes right after startup:'http://i.imgur.com/wWkl194.png [^]'

If I keep the same host settings and change the executable to Zandronum 2.1.2, the server starts without crashing.
(0021817)
DrinkyBird   
2021-11-02 22:25   
(edited on: 2021-11-03 00:27)
Given that VOTEDEF won't be happening any time soon, since the source code is old and - most importantly - likely lost, I've implemented this using the existing vote system. An initial patch is attached, feedback appreciated before I turn this into an actual commit.

edit: I might have to change when the lump and map name is displayed in the vote message. G_GetExitMap behaves oddly clientside with map rotations as it always returns the next map defined in MAPINFO. If I remove the ( NETWORK_GetState( ) == NETSTATE_SERVER ) check in that function (as the client is aware of the map rotation in 3.1), it always returns the same map.

Also just realised that CALLVOTE_BeginVote doesn't check if G_GetExitMap and G_GetSecretExitMap returned NULL, so there's a possible bug...
Then again - this is already validated in callvote_CheckValidity - but I fixed it anyway.
(0021818)
DrinkyBird   
2021-11-03 01:30   
Decided to ditch the idea of showing the map lump and name in the vote message, due to its weirdness with rotations...

edit: and I accidentally left a debug print in...
(0021824)
DrinkyBird   
2021-11-07 20:26   
'https://osdn.net/projects/zandronum/scm/hg/zandronum-stable/commits/a040fb4c3bf1dd475ca5310286903a8ff69af6f0 [^]'

I've already tested it and everything seems to work fine, but I'm leaving this as needs testing for a bit just in case anyone else wants to have look.