MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002287Zandronum[All Projects] Bugpublic2015-06-07 18:472018-09-30 21:57
Reporterunknownna 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0 
Target Version3.0Fixed in Version3.0 
Summary0002287: Monster count issue with A_Respawn online
DescriptionMonsters will sometimes respawn twice when using A_Respawn online.
Steps To Reproduce1. zandronum -file dropitem_01.wad -host
2. zandronum -file dropitem_01.wad -connect localhost
3. kill the zombieman a few times while watching the scoreboard.
Additional Informationdropitem_01.wad
TagsNo tags attached.
Relationships
related to 0002811closed Edward-san monsters face east when respawning with a_respawn online 
Attached Filespng Screenshot_Doom_20150607_204213.png (77,263) 2015-06-07 18:47
https://zandronum.com/tracker/file_download.php?file_id=1532&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-06-07 18:47unknownnaNew Issue
2015-06-07 18:47unknownnaFile Added: Screenshot_Doom_20150607_204213.png
2015-06-07 18:48unknownnaStatusnew => confirmed
2015-07-25 23:00Edward-sanNote Added: 0013003
2015-07-25 23:00Edward-sanAssigned To => Edward-san
2015-07-25 23:00Edward-sanStatusconfirmed => assigned
2015-07-25 23:00Edward-sanStatusassigned => feedback
2015-07-26 01:30DuskNote Added: 0013005
2015-07-26 07:49WaTaKiDNote Added: 0013006
2015-08-09 19:28unknownnaNote Added: 0013173
2015-08-09 19:28unknownnaStatusfeedback => assigned
2016-08-19 04:45WaTaKiDNote Added: 0015494
2016-08-19 05:12WaTaKiDRelationship addedrelated to 0002811
2016-08-19 08:39Edward-sanNote Added: 0015495
2016-08-19 08:48WaTaKiDNote Added: 0015496
2016-08-19 08:49WaTaKiDNote Edited: 0015496bug_revision_view_page.php?bugnote_id=15496#r9418
2016-08-19 20:08IvanNote Added: 0015500
2016-09-02 02:54IvanNote Edited: 0015500bug_revision_view_page.php?bugnote_id=15500#r9463
2016-09-02 18:01Edward-sanNote Added: 0015560
2016-09-02 18:18Edward-sanNote Edited: 0015560bug_revision_view_page.php?bugnote_id=15560#r9465
2016-09-02 20:02IvanNote Added: 0015565
2016-09-02 21:10Edward-sanNote Added: 0015567
2016-09-02 22:17Edward-sanNote Added: 0015568
2016-09-02 22:17Edward-sanStatusassigned => feedback
2016-09-04 02:28WaTaKiDNote Added: 0015579
2016-09-04 22:08Ru5tK1ngNote Added: 0015587
2016-09-05 09:01Edward-sanNote Added: 0015593
2016-09-05 09:01Edward-sanStatusfeedback => needs review
2016-09-05 12:12IvanNote Added: 0015595
2016-09-05 12:15Edward-sanNote Added: 0015597
2016-09-11 15:41Torr SamahoNote Added: 0015614
2016-09-11 15:41Torr SamahoStatusneeds review => needs testing
2016-11-23 02:02Ru5tK1ngNote Added: 0016293
2016-11-23 02:02Ru5tK1ngStatusneeds testing => resolved
2016-11-23 02:02Ru5tK1ngResolutionopen => fixed
2016-11-23 02:02Ru5tK1ngFixed in Version => 3.0
2016-11-23 02:02Ru5tK1ngTarget Version => 3.0
2018-09-30 21:57Blzut3Statusresolved => closed

Notes
(0013003)
Edward-san   
2015-07-25 23:00   
This should fix the issue:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/6670571068f045f409449886a22a56d26a2431f9 [^]' . When you get a build, please test and see if this causes regressions.
(0013005)
Dusk   
2015-07-26 01:30   
It's one bug with two symptoms. I don't think we should have two changelog entries for it.
(0013006)
WaTaKiD   
2015-07-26 07:49   
this build contains the above commit:'https://www.dropbox.com/s/ng1ipozac5qpi4r/zandronum-2.1.2-r150725-2257-6670571-windows.zip?dl=0 [^]'
(0013173)
unknownna   
2015-08-09 19:28   
The build seems to have taken care of the teleportfog and count issue. But the zombie still always faces east (another target issue?) when respawning. I can make a separate ticket for this if you wish.
(0015494)
WaTaKiD   
2016-08-19 04:45   
using the above build and dropitem_01.wad, the teleport fog and monster count issues seem fixed

since Edward-san's link in his note is dead, the fix can be found here instead: 'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable-old/commits/6670571068f045f409449886a22a56d26a2431f9 [^]'

and finally, ive reported the 'monster facing east when respawning' issue here: 'http://zandronum.com/tracker/view.php?id=2811 [^]'
(0015495)
Edward-san   
2016-08-19 08:39   
Before rebasing and submitting as a pull request, can you check with this fix and ping emulators/etc if it's possible ever to get wrong monster counts after a certain time?


[wonkish] I'm starting to think it's a better idea to add a specific server commands which increases or decreases the stats, so that there's never a chance that an old updated value would come after a new updated value and then making clients print a value not matching the current situation...
(0015496)
WaTaKiD   
2016-08-19 08:48   
(edited on: 2016-08-19 08:49)
with an emulated ping of 300, the monster count did not desync even after killing 100 consecutive zombiemen over the course of 3 minutes, but if thats not enuff lemme know and ill test again with higher ping and more kills
(0015500)
Ivan   
2016-08-19 20:08   
(edited on: 2016-09-02 02:54)
This can also be produced by Thing_Raise(0) I'd say. Please update the test file to have a case using that as well.

EDIT: Summon Zombieman_03 to test with thing_raise. Link:'https://www.dropbox.com/s/2t8qihr1nd07m43/drop_item2.wad?dl=0 [^]'
(0015560)
Edward-san   
2016-09-02 18:01   
(edited on: 2016-09-02 18:18)
The decorate file is wrong:


Script error, "drop_item2_thing_raise.wad:DECORATE" line 22:
Invalid state assignment
Script error, "drop_item2_thing_raise.wad:DECORATE" line 23:
Invalid state assignment
Script error, "drop_item2_thing_raise.wad:DECORATE" line 24:
"poss" is an unknown actor property


which is because you forgot to add `States {` in Zombieman_03 actor definition. I'll try fixing the Thing_Raise issue anyways.

[edit]It doesn't resurrect at all, so the example wad is totally broken...
(0015565)
Ivan   
2016-09-02 20:02   
I have fixed the file, try now. You will also see some weird new behavior that is due to the Thing_Raise, the monster is desyncing :)
(0015567)
Edward-san   
2016-09-02 21:10   
I can't seem to reproduce the stat desync with Thing_Raise...
(0015568)
Edward-san   
2016-09-02 22:17   
Rebased. Please check again with this commit:'https://bitbucket.org/zandronum/zandronum-sandbox/commits/aee46e01cab799e51bf654d6bd5547cec1d397d2 [^]'
(0015579)
WaTaKiD   
2016-09-04 02:28   
this 3.0 build contains the above commit: 'https://www.dropbox.com/s/0mydn51bamhddgz/zandronum-3.0-r160902-2215-aee46e0-windows.zip?dl=0 [^]'
(0015587)
Ru5tK1ng   
2016-09-04 22:08   
With that build, all the counters on the scoreboard regarding the monster were correct.
(0015593)
Edward-san   
2016-09-05 09:01   
Thanks for checking!
(0015595)
Ivan   
2016-09-05 12:12   
Should I make a seperate ticket about how the monster desyncs when using Thing_Raise? (Monster position is not predicted properly)
(0015597)
Edward-san   
2016-09-05 12:15   
Yeah, go ahead.
(0015614)
Torr Samaho   
2016-09-11 15:41   
I added the patch.
(0016293)
Ru5tK1ng   
2016-11-23 02:02   
The monster counter had no issues with 161030-2038.