MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002280Doomseeker[All Projects] Suggestionpublic2015-06-02 17:312018-09-29 14:37
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.1Fixed in Version1.1 
Summary0002280: Refactor entangled mess of server lists.
DescriptionHaving 3 different sources of Server objects starts to get difficult to maintain when they need to be registered with different parts of the program that previously assumed that servers can come only from the MasterClient instances. This grows into mess that produces strange behavior, such as incorrect numbers in game status widgets and weird behavior of server list. Server tracking code needs to be refactored.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-02 17:31ZalewaNew Issue
2015-06-04 14:24ZalewaAssigned To => Zalewa
2015-06-04 14:24ZalewaStatusnew => assigned
2015-06-04 14:26ZalewaNote Added: 0012510
2015-06-07 19:17ZalewaNote Added: 0012586
2015-06-07 19:17ZalewaStatusassigned => needs testing
2015-06-08 16:45DevilHunterNote Added: 0012596
2015-06-08 18:41ZalewaNote Added: 0012603
2015-06-08 18:41ZalewaNote Edited: 0012603bug_revision_view_page.php?bugnote_id=12603#r7318
2017-05-08 16:58ZalewaNote Added: 0017604
2017-05-08 16:58ZalewaStatusneeds testing => resolved
2017-05-08 16:58ZalewaFixed in Version => 1.1
2017-05-08 16:58ZalewaResolutionopen => fixed
2018-09-29 14:24WubTheCaptainStatusresolved => closed
2018-09-29 14:37WubTheCaptainTarget Version => 1.1

Notes
(0012510)
Zalewa   
2015-06-04 14:26   
I'm doing some fun fun fun refactoring on serverlist branch:'https://bitbucket.org/Blzut3/doomseeker/commits/branch/serverlist [^]'

A lot has been done, maybe it'd be even enough, but I'll have a look at what else can be centralized with ServerList.
(0012586)
Zalewa   
2015-06-07 19:17   
While changing this, I also touched server status widgets a bit. They will present more info now. Update is available on beta channel. Please test if nothing broke.
(0012596)
DevilHunter   
2015-06-08 16:45   
So far so Good. However, I watched Doomseeker when it refreshes in Task Manager. It seems to use up a lot of CPU Usage still. But it don't impact performance as much anymore.

Then again, I have an Old PC so.. someone with a beefier PC should say more. *looks at WaTaKiD*
(0012603)
Zalewa   
2015-06-08 18:41   
Quote

But it don't impact performance as much anymore.

You mean it's better now than before? Strange. I'd assume it'd be the other way around as now there's more stuff updated live while the server list refreshes.

I have AMD Phenom X6 1055T and refresh doesn't consume more than 1-3% of CPU according to task manager. I use "Moderate" query preset.
(0017604)
Zalewa   
2017-05-08 16:58   
I suppose this got tested enough over the 2 years it's been in the beta version.