MantisBT - Zandronum
View Issue Details
0002277Zandronum[All Projects] Bugpublic2015-05-31 01:302018-09-30 22:20
StrikerMan780 
Dusk 
normalminoralways
closedfixed 
MicrosoftWindowsXP/Vista/7
3.0-beta 
3.03.0 
0002277: Named scripts cannot be puked online & other strangeness.
I've tried several times already to try puking named scripts online using PukeName, and I can't get them to work. In fact, it seems named scripts are broken in several different ways online.

Puking by name doesn't work, and named OPEN, ENTER, RESPAWN, and sometimes even plain (void) scripts don't execute properly, or execute at inappropriate times. I've even seen some scripts get executed on the client that weren't supposed to trigger, as if the client was sent the wrong script ID.

The earlier tracker entry for named scripts was closed as "Resolved" before any good, extended testing was done, I think. Especially online.
Try making various named and unnamed ACS scripts with assorted actions, and make them pukeable. Some stuff will work correctly, some won't, and you'll find yourself unable to puke named scripts.
I'm unable to provide a test wad at this time, but I can make a video soon demonstrating the strange behavior.
No tags attached.
? TestNamedACS.wad (348) 2015-05-31 18:08
/tracker/file_download.php?file_id=1517&type=bug
Issue History
2015-05-31 01:30StrikerMan780New Issue
2015-05-31 11:57Torr SamahoNote Added: 0012470
2015-05-31 18:08StrikerMan780Note Added: 0012478
2015-05-31 18:08StrikerMan780File Added: TestNamedACS.wad
2015-06-01 05:56StrikerMan780Note Added: 0012488
2015-06-02 03:04StrikerMan780Note Edited: 0012488bug_revision_view_page.php?bugnote_id=12488#r7243
2015-06-27 13:34DuskAssigned To => Dusk
2015-06-27 13:34DuskStatusnew => assigned
2015-07-19 10:44cobaltStatusassigned => needs testing
2015-07-19 10:44cobaltTarget Version => 3.0
2015-07-19 10:44cobaltDescription Updatedbug_revision_view_page.php?rev_id=7739#r7739
2015-07-19 10:44cobaltNote Added: 0012971
2015-09-10 03:24Ru5tK1ngNote Added: 0013462
2015-09-10 07:10DuskStatusneeds testing => resolved
2015-09-10 07:10DuskFixed in Version => 3.0
2015-09-10 07:10DuskResolutionopen => fixed
2018-09-30 22:20Blzut3Statusresolved => closed

Notes
(0012470)
Torr Samaho   
2015-05-31 11:57   
Somebody please make a minimal example wad that shows (some of) the broken behavior.
(0012478)
StrikerMan780   
2015-05-31 18:08   
Now that I'm back home, I'm uploading a test WAD now. Just type "pukename pukeme" in the console while online. You can also type "pukename pukeme <value>" with value being any number, for further testing just in case. You should see the message "Value is: X" when puking the script.
(0012488)
StrikerMan780   
2015-06-01 05:56   
(edited on: 2015-06-02 03:04)
I also just realized that requestscriptpuke_named doesn't exist yet either.

(0012971)
cobalt   
2015-07-19 10:44   
Issue addressed by commit 492b0aee48: Improved script puke handling (addresses 2277): - `pukename` now works online - added `NamedRequestScriptPuke` which is like `RequestScriptPuke` except for named scripts - `RequestScriptPuke` and its new named variant now support 4 script arguments and these arguments are now optional.
Committed by Teemu Piippo [Dusk] on Saturday 18 July 2015 21:52:38

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/c_cmds.cpp | 84 +++++++++++++++++++++++----------------
 src/cl_commands.cpp | 15 +++---
 src/cl_commands.h | 2 +-
 src/p_acs.cpp | 94 ++++++++++++++++++++++++++++----------------
 src/p_acs.h | 3 +
 src/sv_main.cpp | 12 ++--
 7 files changed, 129 insertions(+), 82 deletions(-)

(0013462)
Ru5tK1ng   
2015-09-10 03:24   
I loaded up a local server with the test wad using 3.0-150831-1814 and I was able to puke the script with and without a value. I also modified the wad to test out named OPEN, RESPAWN, etc. script types. They all executed correctly.