MantisBT - Zandronum
View Issue Details
0002251Zandronum[All Projects] Bugpublic2015-05-24 18:372018-09-30 22:21
DrinkyBird 
Torr Samaho 
normalminoralways
closedfixed 
MicrosoftWindows7 SP1 x64
3.0-beta 
3.03.0 
0002251: Player Setup sliders are off-position and player preview is missing background
Summary is the best I can explain it. The sliders are off and the player preview is missing the swirly background. See attached screenshot.
No tags attached.
related to 0002326closed Torr Samaho Medals are bugged 
related to 0002403closed Torr Samaho scoreboard is not centered 
png player_setup_sliders.png (1,063,309) 2015-05-24 18:37
/tracker/file_download.php?file_id=1502&type=bug
jpg playersetup-sliders-2.jpg (377,374) 2015-05-24 20:54
/tracker/file_download.php?file_id=1504&type=bug
jpg playersetup-sliders-3.jpg (418,582) 2015-08-09 22:31
/tracker/file_download.php?file_id=1611&type=bug
Issue History
2015-05-24 18:37DrinkyBirdNew Issue
2015-05-24 18:37DrinkyBirdFile Added: player_setup_sliders.png
2015-05-24 18:45DuskProduct Version => 3.0
2015-05-24 18:45DuskSummary[3.0] Player Setup sliders are off-position and player preview is missing background => Player Setup sliders are off-position and player preview is missing background
2015-05-24 19:38DuskProduct Version3.0 => 3.0-beta
2015-05-24 20:23cobaltAssigned To => Torr Samaho
2015-05-24 20:23cobaltStatusnew => needs testing
2015-05-24 20:23cobaltTarget Version => 3.0
2015-05-24 20:23cobaltNote Added: 0012371
2015-05-24 20:54WaTaKiDFile Added: playersetup-sliders-2.jpg
2015-05-24 20:55WaTaKiDNote Added: 0012372
2015-05-31 19:10StrikerMan780Note Added: 0012479
2015-08-09 12:42Torr SamahoNote Added: 0013148
2015-08-09 12:45cobaltNote Added: 0013149
2015-08-09 22:31WaTaKiDFile Added: playersetup-sliders-3.jpg
2015-08-09 22:33WaTaKiDNote Added: 0013181
2015-08-16 20:18WaTaKiDRelationship addedrelated to 0002403
2015-08-16 20:19WaTaKiDRelationship addedrelated to 0002326
2015-08-29 20:30Ru5tK1ngNote Added: 0013315
2015-08-29 22:53Edward-sanNote Added: 0013318
2015-08-29 23:21DuskNote Added: 0013319
2015-08-29 23:22DuskNote Edited: 0013319bug_revision_view_page.php?bugnote_id=13319#r7969
2015-09-01 03:26Ru5tK1ngNote Added: 0013347
2015-09-05 15:05DuskStatusneeds testing => resolved
2015-09-05 15:05DuskFixed in Version => 3.0
2015-09-05 15:05DuskResolutionopen => fixed
2018-09-30 22:21Blzut3Statusresolved => closed

Notes
(0012371)
cobalt   
2015-05-24 20:23   
Issue addressed by commit 914f93f: Changed CleanXfac/CleanYfac back to int. Having them as floats was a constant source of problems with the ZDoom base. It will be better to change our code once (medals and scoreboard possibly need to be adjusted) than always adjusting the incoming ZDoom changes. This fixes most of 2251.
Committed by Benjamin Berkels [Torr Samaho] on Sunday 24 May 2015 21:46:42

Changes in files:

 src/g_shared/sbarinfo.cpp | 6 +-----
 src/menu/messagebox.cpp | 9 ++++-----
 src/menu/playermenu.cpp | 15 +++++++--------
 src/p_conversation.cpp | 7 +++----
 src/v_draw.cpp | 28 ++++------------------------
 src/v_text.cpp | 18 +++---------------
 src/v_video.cpp | 34 ++++++++++++----------------------
 src/v_video.h | 11 +++--------
 8 files changed, 37 insertions(+), 91 deletions(-)

(0012372)
WaTaKiD   
2015-05-24 20:55   
uploaded screenshot using the above commit, the swirly background is back, but the handicap slider still overlaps
(0012479)
StrikerMan780   
2015-05-31 19:10   
I can confirm what WaTaKiD said. The swirly background is back, and the RGB sliders for player color are in their rightful places, but the handicap slider overlaps still.
(0013148)
Torr Samaho   
2015-08-09 12:42   
I aligned the sliders in the player setup menu to the "Handicap" label.
(0013149)
cobalt   
2015-08-09 12:45   
Issue addressed by commit cd4af51bb9d9: Aligned the sliders in the player setup menu to the "Handicap" label (addresses 2251).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 09 August 2015 14:41:49

Changes in files:

 src/menu/playermenu.cpp | 3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

(0013181)
WaTaKiD   
2015-08-09 22:33   
attached a screenshot using'https://www.dropbox.com/s/sd5bqw0l7qfxovi/zandronum-3.0-r150809-1439-b7cf5f6-windows.zip?dl=0 [^]'

everything looks fine to me now
(0013315)
Ru5tK1ng   
2015-08-29 20:30   
I tested a bunch of different video modes with 3.0-alpha-150819-2351. The sliders and the player background looked fine. The only weird thing was the border/background behind the player's name. The right edge would stretch past the window/screen under certain aspect ratios.
(0013318)
Edward-san   
2015-08-29 22:53   
Quote
The only weird thing was the border/background behind the player's name. The right edge would stretch past the window/screen under certain aspect ratios.


Does it happen with GZDoom 1.8.6?
(0013319)
Dusk   
2015-08-29 23:21   
(edited on: 2015-08-29 23:22)
This is because of our long name limit. If the resolution is small enough the field simply bleeds past the end of the screen due to sheer longevity.

IMO nick length and color profile should be separate but this won't be changed anytime soon.

(0013347)
Ru5tK1ng   
2015-09-01 03:26   
Everything still looks fine in 3.0-alpha-150831-1814. Guess this can be closed now.