MantisBT - Zandronum
View Issue Details
0002249Zandronum[All Projects] Bugpublic2015-05-24 18:062018-09-30 22:26
StrikerMan780 
Dusk 
normalminoralways
closedfixed 
MicrosoftWindowsXP/Vista/7
3.0-beta 
3.03.0 
0002249: [MENUDEF] NumberFields don't update correctly.
Quoting from a post I made earlier: Changing the Skill and Botskill in the Skirmish menu changes the value of the skills, but it doesn't update in the menu. Ie. If botskill was initially at 1, and you click on it or hit the right arrow, the skill will change to 2 internally, but the value displayed in the menu still says 1.
No tags attached.
Issue History
2015-05-24 18:06StrikerMan780New Issue
2015-05-24 18:48DuskProduct Version => 3.0
2015-05-24 18:48DuskSummary[3.0 Alpha][MENUDEF] NumberFields don't update correctly. => [MENUDEF] NumberFields don't update correctly.
2015-05-24 19:37DuskProduct Version3.0 => 3.0-beta
2015-05-25 08:23Torr SamahoNote Added: 0012377
2015-05-25 08:24Torr SamahoAssigned To => Dusk
2015-05-25 08:24Torr SamahoStatusnew => assigned
2015-05-25 11:34DuskNote Added: 0012378
2015-05-25 11:44DuskNote Added: 0012379
2015-05-25 11:44DuskStatusassigned => needs review
2015-05-25 11:45DuskNote Edited: 0012378bug_revision_view_page.php?bugnote_id=12378#r7149
2015-05-25 12:42cobaltStatusneeds review => needs testing
2015-05-25 12:42cobaltTarget Version => 3.0
2015-05-25 12:42cobaltNote Added: 0012382
2015-05-25 12:45DuskStatusneeds testing => resolved
2015-05-25 12:45DuskFixed in Version => 3.0
2015-05-25 12:45DuskResolutionopen => fixed
2018-09-30 22:26Blzut3Statusresolved => closed

Notes
(0012377)
Torr Samaho   
2015-05-25 08:23   
Dusk, you implemented the NumberField, didn't you? Can you look into this?
(0012378)
Dusk   
2015-05-25 11:34   
(edited on: 2015-05-25 11:45)
I think I know what's causing this. Skill and botskill are latched CVars so changing their values does not take immediate effect when changed from in-game. I'll have to make it use temporary menu CVars as a workaround.

(Now that I think of it, having the skirmish menu set skill and botskill directly was a rather bad idea in retrospect. Oh well.)

(0012379)
Dusk   
2015-05-25 11:44   
Fixed
(0012382)
cobalt   
2015-05-25 12:42   
Issue addressed by commit e0a5057c3829: Do not change skill and botskill directly in the skirmish menu, instead set temporary CVars that take effect when the skirmish starts (fixes 2249).
Committed by Teemu Piippo [Dusk] on Monday 25 May 2015 14:43:45

Changes in files:

 src/menu/multiplayermenu.cpp | 11 +++++++++++
 wadsrc/static/menudef.za | 4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)