0002226: Zandronum accidentally moves the files from '.zdoom', instead of '.zandronum', to '.config/zandronum'

MantisBT - Zandronum

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0002226

Zandronum

[All Projects] Bug

public

2015-05-10 20:42

2018-09-30 21:50

Reporter

Edward-san

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

Linux

Ubuntu

OS Version

14.04 x86-64

Product Version

3.0-beta

Target Version

3.0

Fixed in Version

3.0

Summary

0002226: Zandronum accidentally moves the files from '.zdoom', instead of '.zandronum', to '.config/zandronum'

Description

This is caused by this code snippet in src/m_misc.cpp:

// This can be removed after a release or two
// Transfer the old zdoom directory to the new location
bool moved = false;
FString oldpath = NicePath("~/.zdoom/");
if (stat (oldpath, &extrainfo) != -1)
{
    if (rename(oldpath, path) == -1)
    {
        I_Error ("Failed to move old zdoom directory (%s) to new location (%s).",
            oldpath.GetChars(), path.GetChars());
    }
    else
        moved = true;
}

if (!moved && mkdir (path, S_IRUSR | S_IWUSR | S_IXUSR) == -1)
{
    I_FatalError ("Failed to create %s directory:\n%s",
        path.GetChars(), strerror (errno));
}

The fix is to replace 'zdoom' with 'GAMENAMELOWERCASE', which is 'zandronum' in our case.

Steps To Reproduce

Additional Information

This is kind of dangerous. I lost some of the old .zdoom files (screenshots, savegames, inis) because of that.

If an user has run zandronum 3.0, he could be able to recover these by moving back the files to .zdoom, except for zandronum.ini.

Also, even if the issue above is fixed by changing the folder name, all the .zandronum data is moved away to .config/zandronum, causing problems when running zandronum 2.0. In order to avoid complications, it's better to 'copy' instead of 'rename'. No idea how to do this, though.