MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002222Zandronum[All Projects] Bugpublic2015-05-09 19:122018-09-30 21:50
ReporterArco 
Assigned ToTorr Samaho 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002222: Using "restart" results in a crash
DescriptionZandronum crashes whenever the "restart" CCMD is executed.
Steps To Reproduce1. Zandronum.exe -iwad doom2.wad
2. Type "restart" in the console.
Additional Information
TagsNo tags attached.
Relationships
child of 0002172closed Torr Samaho Upgrade GZDoom base to 1.8.6 
Attached Fileszip CrashReport-restart-hexentohexen.zip (23,921) 2015-05-18 00:31
/tracker/file_download.php?file_id=1496&type=bug
png restart.png (536,778) 2015-08-09 23:59
/tracker/file_download.php?file_id=1612&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-05-09 19:12ArcoNew Issue
2015-05-10 13:54ArcoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7060#r7060
2015-05-12 13:19ArcoRelationship addedchild of 0002172
2015-05-16 15:54Torr SamahoNote Added: 0012289
2015-05-16 15:55Torr SamahoAssigned To => Torr Samaho
2015-05-16 15:55Torr SamahoStatusnew => needs testing
2015-05-16 18:58WaTaKiDNote Added: 0012298
2015-05-17 23:28ArcoNote Added: 0012330
2015-05-17 23:28ArcoStatusneeds testing => assigned
2015-05-17 23:36ArcoNote Edited: 0012330bug_revision_view_page.php?bugnote_id=12330#r7113
2015-05-18 00:28WaTaKiDNote Added: 0012332
2015-05-18 00:29WaTaKiDNote Edited: 0012332bug_revision_view_page.php?bugnote_id=12332#r7115
2015-05-18 00:31WaTaKiDFile Added: CrashReport-restart-hexentohexen.zip
2015-05-24 18:54DuskProduct Version => 3.0
2015-05-24 18:54DuskSummary[Merge experiments] Using "restart" results in a crash => Using "restart" results in a crash
2015-05-24 19:32DuskProduct Version3.0 => 3.0-beta
2015-08-09 11:02Torr SamahoNote Added: 0013144
2015-08-09 11:03Torr SamahoStatusassigned => needs testing
2015-08-09 23:58WaTaKiDNote Added: 0013183
2015-08-09 23:59WaTaKiDFile Added: restart.png
2016-02-01 00:34Ru5tK1ngNote Added: 0014274
2016-02-01 00:35Ru5tK1ngStatusneeds testing => feedback
2016-02-01 07:32Torr SamahoNote Added: 0014280
2016-02-01 22:48Ru5tK1ngNote Added: 0014292
2016-11-21 15:14Edward-sanNote Added: 0016252
2016-12-24 22:42DuskTarget Version => 3.0
2017-01-26 05:08Ru5tK1ngNote Added: 0016691
2017-01-28 15:41Torr SamahoNote Added: 0016706
2017-01-28 15:41Torr SamahoStatusfeedback => needs testing
2017-01-28 20:51Ru5tK1ngNote Added: 0016709
2017-01-28 20:51Ru5tK1ngStatusneeds testing => resolved
2017-01-28 20:51Ru5tK1ngResolutionopen => fixed
2017-01-28 20:51Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:50Blzut3Statusresolved => closed

Notes
(0012289)
Torr Samaho   
2015-05-16 15:54   
Should work better now. Still seems to have some problems, but I'm not sure whether they were also present in ZDoom 2.7.0 or not.
(0012298)
WaTaKiD   
2015-05-16 18:58   
after testing with 3.0-r150516-1553, the basic use of restart seems to work fine offline, but calling restart with rcon crashes, and calling restart as a client will leave u at the console with "None is not an actor"
(0012330)
Arco   
2015-05-17 23:28   
(edited on: 2015-05-17 23:36)
And to add on to what WaTaKiD was saying, Zandronum 3.0 appears to freeze when switching Iwads.

EDIT: it appears to happen when the iwad is switched from Hexen. I'm not sure whether it's the same case with Heretic and/or Strife.
(0012332)
WaTaKiD   
2015-05-18 00:28   
(edited on: 2015-05-18 00:29)
it appears that when switching FROM hexen/hexdd to anything (including themselves), itll freeze, however i managed to get one crash report for wutever reason

'https://www.dropbox.com/s/t8jeb6wr7b5mjd4/zandronum-3.0-150517-2229-82d094f-windows.zip?dl=0 [^]'

'https://www.dropbox.com/s/ebrxoomppc08yhv/pdb-82d094f.zip?dl=0 [^]'

> zandronum.exe!FMetaTable::GetMetaString(unsigned int id=610305) Line 188 + 0x10 bytes C++
     zandronum.exe!D_PlayerClassToInt(const char * classname=0x00000000) Line 312 + 0xe bytes C++
     zandronum.exe!userinfo_t::PlayerClassChanged(const char * classname=0x02f6d970) Line 690 C++
     zandronum.exe!D_SetupUserInfo() Line 599 + 0xe bytes C++
     zandronum.exe!D_UserInfoChanged(FBaseCVar * cvar=0x00000000) Line 1021 C++
     zandronum.exe!FBaseCVar::SetGenericRep(UCVarValue value={...}, ECVarType type=CVAR_String) Line 199 + 0x28 bytes C++
     zandronum.exe!FGameConfigFile::ReadCVars(unsigned long flags=289) Line 535 + 0xe bytes C++
     zandronum.exe!FGameConfigFile::DoGameSetup(const char * gamename=0x0359544c) Line 407 C++
     zandronum.exe!D_DoomMain() Line 2766 C++
     zandronum.exe!DoMain(HINSTANCE__ * hInstance=0x00000000) Line 1058 C++
     zandronum.exe!WinMain(HINSTANCE__ * hInstance=0x00400000, HINSTANCE__ * nothing=0x00000000, char * cmdline=0x002c3ee8, int nCmdShow=10) Line 1354 C++
     zandronum.exe!__tmainCRTStartup() Line 315 + 0x1c bytes C

EDIT: also, each time "restart" is used, optional pwads will be loaded again, resulting in multiples
(0013144)
Torr Samaho   
2015-08-09 11:02   
I fixed some more network related restart problems and the ZDoom backports seem to have taken care of other restart problems. Can you check if restart works properly now?
(0013183)
WaTaKiD   
2015-08-09 23:58   
using'https://www.dropbox.com/s/sd5bqw0l7qfxovi/zandronum-3.0-r150809-1439-b7cf5f6-windows.zip?dl=0 [^]' with newtextcolours1_220.pk3 set as optional

offline:
restart (or for example: restart -iwad hexen) seems to work fine, except for the optional wad is being loading again for every restart

client:
restart will disconnect u from the server and put u in singleplayer, although the optional wad will not be loaded at all

server:
restart will disconnect all clients and load optional wads again, and after what seems to be consistent, the 3rd restart, the server will error out
see attached screenshot (the server error is in the middle, while on the left is the error clients recieve when servers use restart)
(0014274)
Ru5tK1ng   
2016-02-01 00:34   
I tested this with 160131-2023.

offline restart:
I used doom2.wad and ragectf.wad. The pwad isn't loaded up after issuing the Restart command and if you have other IWADS in your directory, the IWAD selection window pops up.

client:
Disconnects and stays at console with a WAD authentication error (due to the PWAD not being load on the server after Restart).

server:
My server didn't load up the PWADs and the IWAD selection window popped up each time. I couldn't get the server to crash after many restarts at least.
(0014280)
Torr Samaho   
2016-02-01 07:32   
FYI, unless specified with " -file" in the restart command, e.g. "restart -file test.pk3", no pwads will be loaded. This is intentional, because the restart command is intended to allow you to change which wads are loaded.

The client behavior sounds wrong though. Restart should disconnect you without an authentication error.
(0014292)
Ru5tK1ng   
2016-02-01 22:48   
Actually scratch what I said earlier regarding the client behavior, I misread the console. When using restart, you are simply kicked with the 'Player was kicked from the server. . .server encountered error. . .etc.' message.


Using the syntax above with restart loaded the specified pwad correctly with -file

However, one thing I noticed when switching between IWADs with restart is that going from MAPXX based wads (doom2, strife, hexen, etc.) to EXMX based (doom, heretic) caused the server console to flood with "Error could not find map01" endlessly.
(0016252)
Edward-san   
2016-11-21 15:14   
What's the situation with latest beta?
(0016691)
Ru5tK1ng   
2017-01-26 05:08   
As of r170122, using restart and, for example, switching out doom2.wad for heretic.wad on the server results in the "Error could not find map01" spam. Going from heretic to doom also produces "Error could not find map e1m1".
(0016706)
Torr Samaho   
2017-01-28 15:41   
Switching between MAPXX and EXMX IWADs should be possible now on the server.
(0016709)
Ru5tK1ng   
2017-01-28 20:51   
The message spam is no longer present when switching between IWADs.