MantisBT - Zandronum
View Issue Details
0002213Zandronum[All Projects] Bugpublic2015-04-26 14:012015-04-26 14:08
Ch0wW 
 
highmajoralways
newopen 
AnyAnyAny
2.0 
 
0002213: Spectators are counted as valid voters with sv_nocallvote 2
If someone calls a vote, if there are at least less than 50% players than spectators, the vote doesn't end.

This all happens because of a forgotten check in ULONG CALLVOTE_CountNumEligibleVoters( void ) .
Get 3 players, with sv_nocallvote 2.

1 player, 2 spectators.
Let the player call a vote ==> yes.

Nothing happens.
This error happens because of the way the server checks votes.

Ie: The server only accept/discards a vote IF at least 50% of legit clients have voted.

Problem is: when the server only allows players to vote with sv_nocallvote 2, the way it's handled is wrong.

For the current case, only 33% of the players have voted Yes. If players have only the right to vote, that should have been 100%.


Function fixed on the file.
No tags attached.
txt fix.txt (1,163) 2015-04-26 14:01
/tracker/file_download.php?file_id=1474&type=bug
Issue History
2015-04-26 14:01Ch0wWNew Issue
2015-04-26 14:01Ch0wWFile Added: fix.txt
2015-04-26 14:08Ch0wWNote Added: 0012174

Notes
(0012174)
Ch0wW   
2015-04-26 14:08   
Also, because I like things done correctly: in scoreboard.cpp , if player is a spectator while sv_nocallvote 2 is set, don't show "VOTE NOW". That might remove a possible confusion for spectators thinking they are able to vote while it isn't the case.