MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002197Zandronum[All Projects] Bugpublic2015-04-19 21:402018-09-30 22:22
ReporterDusk 
Assigned ToDusk 
PriorityhighSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002197: Rebuild Zandronum menus for MENUDEF
DescriptionNow that MENUDEF has been (un?)officially ported for Zandronum, we need to rebuild all Zandronum-specific menus for it. I guess I'll be doing that..

This is a rather big thing and requires some sub-tickets so be prepared for that..
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
parent of 0002198closed Dusk [MENUDEF] Userinfo name field does not accept color codes 
parent of 0002199closed Dusk [MENUDEF] Weapon setup needs to be rebuilt 
parent of 0002200closed Dusk [MENUDEF] Multiplayer options must be rebuilt 
parent of 0002201closed Dusk [MENUDEF] Re-add Zandronum-specific CVar info 
parent of 0001984closed Dusk Make a simple login config at multiplayer menu 
parent of 0002206closed Dusk Space to join doesn't work anymore 
parent of 0001438closed Dusk "Connection type" option player kick 
parent of 0001649closed Dusk Disconnect before starting a new game prompt misses a way to do so 
parent of 0000855closed Dusk Move the Multiplayer Menu from the Main Menu to the Options Menu 
parent of 0002261closed Dusk Add a forcespec option in the "Call Vote" menu 
related to 0002168closed Dusk Tweak Unlagged menu/cvar 
child of 0001091closed Torr Samaho Introduction of MENUDEF LUMP 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-19 21:40DuskNew Issue
2015-04-19 21:40DuskStatusnew => assigned
2015-04-19 21:40DuskAssigned To => Dusk
2015-04-19 21:41DuskRelationship addedparent of 0002198
2015-04-19 21:43DuskRelationship addedparent of 0002199
2015-04-19 21:44DuskRelationship addedparent of 0002200
2015-04-19 21:49DuskRelationship addedparent of 0002201
2015-04-19 21:49Blzut3Relationship addedchild of 0001091
2015-04-19 21:53DuskPriorityurgent => high
2015-04-19 21:53DuskOSMint =>
2015-04-19 21:53DuskOS Version16 (Petra) =>
2015-04-19 21:53DuskPlatformGNU/Linux =>
2015-04-20 16:06DuskRelationship addedparent of 0001984
2015-04-25 09:23Torr SamahoRelationship addedhas duplicate 0002206
2015-04-25 15:55DuskRelationship replacedparent of 0002206
2015-04-27 13:08DuskRelationship addedparent of 0002168
2015-04-28 18:22DuskRelationship addedparent of 0001438
2015-05-02 00:49DuskNote Added: 0012195
2015-05-02 00:50DuskNote Edited: 0012195bug_revision_view_page.php?bugnote_id=12195#r7035
2015-05-02 00:51DuskNote Edited: 0012195bug_revision_view_page.php?bugnote_id=12195#r7036
2015-05-09 17:45Torr SamahoNote Added: 0012215
2015-05-18 10:48DuskRelationship addedparent of 0001649
2015-05-24 11:40cobaltStatusassigned => needs testing
2015-05-24 11:40cobaltDescription Updatedbug_revision_view_page.php?rev_id=7135#r7135
2015-05-24 11:40cobaltNote Added: 0012362
2015-05-24 19:38DuskProduct Version3.0 => 3.0-beta
2015-05-24 19:38DuskDescription Updatedbug_revision_view_page.php?rev_id=7143#r7143
2015-05-25 08:08Edward-sanNote Added: 0012376
2015-05-26 00:25DuskNote Edited: 0012362bug_revision_view_page.php?bugnote_id=12362#r7168
2015-05-26 00:29DuskRelationship addedchild of 0000855
2015-05-26 13:36DuskRelationship addedparent of 0002261
2015-05-26 18:13DuskRelationship replacedparent of 0000855
2015-09-01 16:28DuskRelationship replacedrelated to 0002168
2015-09-01 16:28DuskStatusneeds testing => resolved
2015-09-01 16:28DuskFixed in Version => 3.0
2015-09-01 16:28DuskResolutionopen => fixed
2018-09-30 22:22Blzut3Statusresolved => closed

Notes
(0012195)
Dusk   
2015-05-02 00:49   
(edited on: 2015-05-02 00:51)
It has turned out that the player setup is hardcoded enough that it cannot support the Zandronum items at all. There's no support for scrolling nor sub-menus. Zandronum items (e.g. handicap, railgun color, weapon setup) simply don't fit in the menu. This means that for now, all Zandronum items need to be moved into a separate submenu I'm calling "more player setup".

Blzut3 suggested to make the player setup be an option menu for ZDoom. I'll try see what I can do there. But if it doesn't pan out, we have no choice but to live with two player setup menus.

In other news, most of the menus have been rebuilt now. I hope I haven't forgotten too much out but it seems good so far.
(0012215)
Torr Samaho   
2015-05-09 17:45   
Quote from Dusk

In other news, most of the menus have been rebuilt now. I hope I haven't forgotten too much out but it seems good so far.

Nice work! Let me know when it's ready to be pulled in.
(0012362)
cobalt   
2015-05-24 11:40   
(edited on: 2015-05-26 00:25)
Issue addressed by commit 482828a: Rebuilt menus for Zandronum. Moved the Multiplayer menu from the main menu to options under the name "Multiplayer Options". Menus in general have seen a general reorganization and many Zandronum-specific items have been renamed. Network options are now under multiplayer options. Multiplayer options menu has been populated with CVars introduced over the past few years. Added new features to the option menu for MENUDEF: - TextField for inputting string CVars - NumberField as a spinbox for int and float CVars - PlayerField as a player selector field - JoinMenuTeamOption and JoinMenuPlayerOption as ad hoc widgets for the join menu (do not use) - NetGameOnly to make a menu only be available online.
Committed by Teemu Piippo [Dusk] on Tuesday 19 May 2015 20:40:37

Changes in files:

 gzdoom.vcproj | 4 +
 src/CMakeLists.txt | 1 +
 src/c_cvars.cpp | 12 +
 src/c_cvars.h | 17 +-
 src/chat.cpp | 22 +
 src/d_main.cpp | 13 +-
 src/d_netinf.h | 3 +-
 src/d_netinfo.cpp | 19 +-
 src/g_game.cpp | 76 ++-
 src/g_game.h | 3 +
 src/menu/menu.cpp | 9 +
 src/menu/menu.h | 15 +-
 src/menu/menudef.cpp | 209 +++++++++++
 src/menu/menuinput.cpp | 10 +-
 src/menu/multiplayermenu.cpp | 768 ++++++++++++++++++++++++++++++++++++++++++
 src/menu/optionmenu.cpp | 25 +-
 src/menu/optionmenuitems.h | 442 ++++++++++++++++++++++++-
 src/menu/playermenu.cpp | 44 ++-
 src/team.h | 3 -
 wadsrc/static/menudef.txt | 131 ++++++-
 wadsrc/static/menudef.z | 3 +-
 wadsrc/static/menudef.za | 363 +++++++++++++++++++
 22 files changed, 2125 insertions(+), 67 deletions(-)
(0012376)
Edward-san   
2015-05-25 08:08   
I believe we can purge for good the old menu code which is still present in the repository.