MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002195Zandronum[All Projects] Bugpublic2015-04-17 20:152018-09-30 21:37
ReporterCatastrophe 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version 
Target Version2.1Fixed in Version2.1 
Summary0002195: a_changeflag and +thruspecies is very jittery online
DescriptionBasically, giving players an item that changes their +thruspecies flag to false makes them really jittery when colliding with other players who've also had their flag changed.

This works fine offline, but online it is broken.
Steps To ReproduceStart a server with the attached wad
Add a bunch of bots
Puke 203 to remove +thruspecies from everyone
Try to bump into other players, and notice how jittery it is compared to online
Additional Information
TagsNo tags attached.
Relationships
Attached Files? thruspeciesbug.wad (101,932) 2015-04-17 20:15
/tracker/file_download.php?file_id=1466&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-04-17 20:15CatastropheNew Issue
2015-04-17 20:15CatastropheFile Added: thruspeciesbug.wad
2015-04-17 20:16CatastropheNote Added: 0012126
2015-04-17 20:37Edward-sanNote Added: 0012128
2015-04-17 20:37Edward-sanAssigned To => Edward-san
2015-04-17 20:37Edward-sanStatusnew => assigned
2015-04-17 21:40Edward-sanNote Added: 0012129
2015-04-17 21:40Edward-sanStatusassigned => needs review
2015-04-17 21:40Edward-sanNote Deleted: 0012128
2015-04-18 13:19Torr SamahoNote Added: 0012131
2015-04-18 13:20Torr SamahoStatusneeds review => feedback
2015-04-18 14:31Edward-sanNote Added: 0012135
2015-04-18 14:32Edward-sanNote Edited: 0012135bug_revision_view_page.php?bugnote_id=12135#r6980
2015-04-23 20:31Edward-sanStatusfeedback => needs review
2015-04-23 20:31Edward-sanTarget Version => 2.1
2015-04-25 09:31cobaltStatusneeds review => needs testing
2015-04-25 09:31cobaltDescription Updatedbug_revision_view_page.php?rev_id=6999#r6999
2015-04-25 09:31cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7001#r7001
2015-04-25 09:31cobaltNote Added: 0012167
2015-04-25 22:28HypnotoadNote Added: 0012171
2015-04-25 22:59Edward-sanNote Added: 0012172
2015-05-10 20:19Edward-sanStatusneeds testing => needs review
2015-05-24 11:50Torr SamahoNote Added: 0012363
2015-05-24 11:50Torr SamahoStatusneeds review => needs testing
2015-06-24 22:46DuskStatusneeds testing => resolved
2015-06-24 22:46DuskFixed in Version => 2.2
2015-06-24 22:46DuskResolutionopen => fixed
2015-06-24 22:47DuskFixed in Version2.2 => 2.1
2018-09-30 21:37Blzut3Statusresolved => closed

Notes
(0012126)
Catastrophe   
2015-04-17 20:16   
compared to offline* not online.
(0012129)
Edward-san   
2015-04-17 21:40   
Done:'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/bbaf2fa9c7e6b1ceb1b5a41aa633041a90d70fdf [^]'
(0012131)
Torr Samaho   
2015-04-18 13:19   
See my comment on bitbucket.
(0012135)
Edward-san   
2015-04-18 14:31   
(edited on: 2015-04-18 14:32)
Fixed in the same head. While working on this, I noticed that the clients don't relink the actors in case MF_NOSECTOR is changed (like it's done in the A_ChangeFlag code). See'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/e8cfadb7f3fd0be56eb7903da83fd716e91be52c [^]' for a fix.
(0012167)
cobalt   
2015-04-25 09:31   
Issue addressed by commit 3fb9a04c953c: - Fixed: clients were not informed of some actor flag modifications with A_ChangeFlag (addresses 2195).
Committed by edward_san [edward-san] on Sunday 19 April 2015 13:26:58

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/cl_main.cpp | 15 ++++++++++++---
 src/network.h | 17 +++++++++++------
 src/sv_commands.cpp | 7 ++++---
 src/sv_commands.h | 2 +-
 src/thingdef/thingdef_codeptr.cpp | 18 ++++++++++--------
 6 files changed, 39 insertions(+), 21 deletions(-)
(0012171)
Hypnotoad   
2015-04-25 22:28   
Confirmed fixed after testing in local server.
(0012172)
Edward-san   
2015-04-25 22:59   
WaTaKiD and I discovered that the clients, after the puke is done, would desync again after a changemap map change.'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/67ef3e0be7f4652acccdb27cbed2a609f7dd29ff [^]' should fix this.
(0012363)
Torr Samaho   
2015-05-24 11:50   
I transplanted the fix.