MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002143Zandronum[All Projects] Bugpublic2015-03-30 01:012018-09-30 21:38
Reporter-Jes- 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0 
Target Version2.1Fixed in Version2.1 
Summary0002143: Desync: A_LookEx fails entirely on client.
DescriptionA_LookEx fails entirely during network games, desyncing gameplay:
When Offline/Server, A_LookEx does what it's meant to do.
When Client, A_LookEx does nothing. Cue desync.
Steps To ReproduceRun attached wad.
When server, zombieman blinks and spawns two archvilefire actors, then disappears.
When client, zombieman spawns one archvilefire. (the latter is SXF_CLIENTSIDE)

When server, doomimp behaves as default.
When client, doomimp will desync, standing idle on client while behaving normally on server.

Desync will end on serverside change to actor, ie state change. (attacking, in pain, dying)
Additional Information
TagsNo tags attached.
Relationships
Attached Files? lookexbug.wad (489) 2015-03-30 01:01
/tracker/file_download.php?file_id=1435&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-03-30 01:01-Jes-New Issue
2015-03-30 01:01-Jes-File Added: lookexbug.wad
2015-03-30 09:03DuskNote Added: 0011927
2015-03-30 09:03DuskAssigned To => Dusk
2015-03-30 09:03DuskStatusnew => needs review
2015-03-30 10:43DuskProduct Version => 2.0
2015-03-30 10:43DuskTarget Version => 2.1
2015-03-30 18:58Torr SamahoNote Added: 0011945
2015-03-30 19:03Torr SamahoStatusneeds review => feedback
2015-03-30 19:04DuskNote Added: 0011946
2015-03-30 19:04DuskStatusfeedback => assigned
2015-03-31 11:26DuskNote Added: 0011950
2015-03-31 11:26DuskStatusassigned => needs review
2015-04-03 10:04Torr SamahoNote Added: 0011999
2015-04-03 10:05Torr SamahoStatusneeds review => feedback
2015-04-16 18:55Edward-sanNote Added: 0012119
2015-04-16 18:56Edward-sanStatusfeedback => needs review
2015-04-18 13:23cobaltStatusneeds review => needs testing
2015-04-18 13:23cobaltDescription Updatedbug_revision_view_page.php?rev_id=6976#r6976
2015-04-18 13:23cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6978#r6978
2015-04-18 13:23cobaltNote Added: 0012133
2015-04-24 01:28HypnotoadNote Added: 0012165
2015-04-24 03:59DuskStatusneeds testing => resolved
2015-04-24 03:59DuskFixed in Version => 2.1
2015-04-24 03:59DuskResolutionopen => fixed
2018-09-30 21:38Blzut3Statusresolved => closed

Notes
(0011927)
Dusk   
2015-03-30 09:03   
'https://bitbucket.org/crimsondusk/zandronum-sandbox/compare/a_lookex_desync..Torr_Samaho/zandronum [^]'
(0011945)
Torr Samaho   
2015-03-30 18:58   
When the server informs the clients about the relevant outcomes of a code pointer, the client should usually jump out of the pointer at the beginning, see A_Look for example. Did you intentionally not do this for A_LookEx or is this just an oversight?
(0011946)
Dusk   
2015-03-30 19:04   
Oh right, the client should probably break out of that. I'll address this soon enough.
(0011950)
Dusk   
2015-03-31 11:26   
That is addressed now.
(0011999)
Torr Samaho   
2015-04-03 10:04   
Are you sure that (unlike A_Look) A_LookEx doesn't need the stealth monsters stuff on the client? I guess that this is either needed in both functions or in none of them.
(0012119)
Edward-san   
2015-04-16 18:55   
Added the missing stealth monsters part.
(0012133)
cobalt   
2015-04-18 13:23   
Issue addressed by commit 7e6e88086740: - fixed: A_LookEx desynced completely online (fixes 2143)
Committed by edward_san [edward-san] on Thursday 16 April 2015 20:54:09

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/p_enemy.cpp | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 0 deletions(-)
(0012165)
Hypnotoad   
2015-04-24 01:28   
Can confirm fix works fine after testing on local server.