MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002136 | Zandronum | [All Projects] Bug | public | 2015-03-25 04:08 | 2018-09-30 21:38 |
|
| Reporter | Ru5tK1ng | |
| Assigned To | Dusk | |
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | |
| Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 |
| Product Version | 1.3 | |
| Target Version | 2.1 | Fixed in Version | 2.1 | |
|
| Summary | 0002136: Railgun ignores armor completely |
| Description | Rail attacks currently ignore armor and mods that make use of a rail attack, either from a monster or player, has to rely on fast projectiles if they wish to respect armour. The issue with relying on fast projectiles is that they get laggy with higher latency. I couldn't find the changelog version, but I know GZDoom and perhaps ZDoom fixed this issue. |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  railguytest.wad (934) 2015-03-25 19:58
/tracker/file_download.php?file_id=1432&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-03-25 04:08 | Ru5tK1ng | New Issue | |
| 2015-03-25 10:33 | Edward-san | Note Added: 0011885 | |
| 2015-03-25 19:58 | Ru5tK1ng | File Added: railguytest.wad | |
| 2015-03-25 20:00 | Ru5tK1ng | Note Added: 0011886 | |
| 2015-03-25 23:23 | Edward-san | Note Added: 0011891 | |
| 2015-03-25 23:23 | Edward-san | Note Edited: 0011891 | bug_revision_view_page.php?bugnote_id=11891#r6827 |
| 2015-03-25 23:51 | Dusk | Category | Suggestion => Bug |
| 2015-03-25 23:51 | Dusk | Summary | Backport GZDoom Railgun Armor Fix => Railgun ignores armor completely |
| 2015-03-25 23:52 | Dusk | Note Added: 0011894 | |
| 2015-03-26 00:38 | Edward-san | Note Added: 0011895 | |
| 2015-03-26 00:39 | Edward-san | Note Edited: 0011895 | bug_revision_view_page.php?bugnote_id=11895#r6829 |
| 2015-03-26 01:10 | Ru5tK1ng | Note Added: 0011896 | |
| 2015-03-28 01:15 | Dusk | Note Added: 0011902 | |
| 2015-03-28 02:08 | Ru5tK1ng | Note Added: 0011904 | |
| 2015-03-30 15:11 | Dusk | Assigned To | => Dusk |
| 2015-03-30 15:11 | Dusk | Status | new => assigned |
| 2015-03-30 15:12 | Dusk | Target Version | => 2.1 |
| 2015-03-30 22:01 | Dusk | Note Added: 0011948 | |
| 2015-03-30 22:01 | Dusk | Status | assigned => needs review |
| 2015-04-03 15:02 | Torr Samaho | Note Added: 0012004 | |
| 2015-04-03 15:03 | Torr Samaho | Status | needs review => feedback |
| 2015-04-03 18:53 | Dusk | Status | feedback => assigned |
| 2015-04-25 16:03 | Dusk | Note Added: 0012169 | |
| 2015-04-25 16:03 | Dusk | Status | assigned => needs review |
| 2015-05-24 11:12 | cobalt | Status | needs review => needs testing |
| 2015-05-24 11:12 | cobalt | Note Added: 0012354 | |
| 2015-06-24 22:46 | Dusk | Status | needs testing => resolved |
| 2015-06-24 22:46 | Dusk | Fixed in Version | => 2.2 |
| 2015-06-24 22:46 | Dusk | Resolution | open => fixed |
| 2015-06-24 22:47 | Dusk | Fixed in Version | 2.2 => 2.1 |
| 2018-09-30 21:38 | Blzut3 | Status | resolved => closed |
|
Notes |
|
|
|
|
Do you have an example wad with a monster which does a rail attack with not high damage? |
|
|
|
|
|
I attached a simple zombieman replacement wad. In this test wad simply grab the blue armor then shoot the zombieman. He will return fire with a basic rail attack that takes off 50 health and leaves the armor untouched. |
|
|
|
|
Interesting, I tested with gzdoom 900 and seems to work fine, but in zandronum 1.3 and 2.0 it doesn't work.
|
|
|
|
(0011894)
|
|
Dusk
|
|
2015-03-25 23:52
|
|
|
|
|
(0011895)
|
|
Edward-san
|
2015-03-26 00:38
(edited on: 2015-03-26 00:39) |
|
According to the Skulltag history, the railgun attacks become armor piercing since v96b:
- - The railgun attacks are now armor piercing, like they were meant to be.
But in zdoom, there's no trace of this in the code history, so my guess is that Skulltag did it intentionally.
How many mods rely on this?
|
|
|
|
|
|
I'm not sure how many mods explicitly rely on the rail's armor piercing. It would be a safe bet that it's more likely that a mod uses a projectile with the PIERCEARMOR flag on rather than use a rail. Of course, there is no real way to find out the number of mods relying on the armor piercing rail unless the mod authors speak up. It seems that the rail attacks are either piercing or not(essentially being mutually exclusive). Ultimately it depends whether or not Zandronum wants to maintain consistency with (g)ZDoom or continue on a decision made by Carn. I would suggest the former. |
|
|
|
(0011902)
|
|
Dusk
|
|
2015-03-28 01:15
|
|
|
Considering how old the change is, I guess Carn intended the change to affect the Skulltag railgun, which IMO means we should remove DMG_NO_ARMOR from P_RailAttack's P_DamageMobj calls and add PIERCEARMOR to Railgun. If this change somehow breaks some wad, we can use compatibility.txt to cater for it. |
|
|
|
|
|
That is a fair course of action. Currently there isn't any real way to get around the armor piercing factor of rail attacks. Going the route you suggested enables modders to decide on their own whether armor piercing should be on or off. |
|
|
|
(0011948)
|
|
Dusk
|
|
2015-03-30 22:01
|
|
Changed
This one was annoying, ugh. |
|
|
|
|
Looks fine except that you forget to mark the change from
DEFINE_ACTION_FUNCTION(AActor, A_FireRailgun)
to
DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FireRailgun)
with your initials. |
|
|
|
(0012169)
|
|
Dusk
|
|
2015-04-25 16:03
|
|
|
That is done now. I figured the comment inside was good enough. Moved it outside now. |
|
|
|
(0012354)
|
|
cobalt
|
|
2015-05-24 11:12
|
|
|