MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002088Zandronum[All Projects] Bugpublic2015-02-01 21:102018-09-30 23:00
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002088: Some surfaces of 3d floors aren't affected by fog.
DescriptionThis happens in jumpmaze2 map63. I'll attach some screenshots to show the problem.

This did not happen in zandronum 1.3.
Steps To Reproducecommand: zandronum -iwad DOOM2.WAD -file skulltag_actors.pk3 skulltag_data.pk3 jumpmaze2_v8.pk3
then in console:
map map63
warp -1850 18750
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot_Doom_20150201_220732.png (352,240) 2015-02-01 21:11
/tracker/file_download.php?file_id=1402&type=bug
png Screenshot_Doom_20150201_220817.png (385,122) 2015-02-01 21:12
/tracker/file_download.php?file_id=1403&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-01 21:10Edward-sanNew Issue
2015-02-01 21:11Edward-sanReproducibilityhave not tried => always
2015-02-01 21:11Edward-sanOSUbuntu =>
2015-02-01 21:11Edward-sanOS Version14.04 x86-64 =>
2015-02-01 21:11Edward-sanPlatformLinux =>
2015-02-01 21:11Edward-sanFile Added: Screenshot_Doom_20150201_220732.png
2015-02-01 21:12Edward-sanFile Added: Screenshot_Doom_20150201_220817.png
2015-02-01 21:15Edward-sanNote Added: 0011586
2015-02-01 22:43Edward-sanNote Edited: 0011586bug_revision_view_page.php?bugnote_id=11586#r6565
2015-02-01 22:43Edward-sanAssigned To => Torr Samaho
2015-02-01 22:43Edward-sanStatusnew => assigned
2015-02-02 07:10Torr SamahoNote Added: 0011588
2015-02-02 07:11Torr SamahoStatusassigned => needs testing
2015-02-02 07:11Torr SamahoTarget Version => 2.0
2015-02-02 11:04cobaltNote Added: 0011589
2015-02-02 14:01Edward-sanNote Added: 0011591
2015-03-29 20:20DuskStatusneeds testing => resolved
2015-03-29 20:20DuskFixed in Version => 2.0
2015-03-29 20:20DuskResolutionopen => fixed
2018-09-30 23:00Blzut3Statusresolved => closed

Notes
(0011586)
Edward-san   
2015-02-01 21:15   
(edited on: 2015-02-01 22:43)
Copying what I wrote in ticket 0001990 and should've been here:

I suspect the real fix to everything regarding the fogs is in r1401, and this applies also for the issues seen in jumpmaze2 map63, where everything is fogged, except for the sector planes of some houses done with 3d floors.

[edit] These commits contain the backported changes, which are: 945, 1162 and 1401.
(0011588)
Torr Samaho   
2015-02-02 07:10   
I backported the commits you mentioned.
(0011589)
cobalt   
2015-02-02 11:04   
Issue addressed by commit 313b589c8443: out of sequence fix backport from GZDoom revision 1401: - fixed: Fog checks for sector planes need to use the actual light levels calculated for the plane, not the sector defaults. Those won't be correct for 3D-floors. This fixes 2088.
Committed by Benjamin Berkels [Torr Samaho] on Monday 02 February 2015 08:06:09

Changes in files:
 src/gl/renderer/gl_lightdata.cpp | 34 ++++++++++++++++++++++++++++++++++
 src/gl/renderer/gl_lightdata.h | 1 +
 src/gl/scene/gl_flats.cpp | 6 +++---
 src/gl/scene/gl_wall.h | 2 +-
 4 files changed, 39 insertions(+), 4 deletions(-)
(0011591)
Edward-san   
2015-02-02 14:01   
Thanks. A win32 build would help some testers to check this in other maps.