MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002085Zandronum[All Projects] Bugpublic2015-01-29 21:132018-09-30 21:38
Reporteribm5155 
Assigned ToTorr Samaho 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformX64OSwindowsOS Version8.1
Product Version2.0 
Target Version2.1Fixed in Version2.1 
Summary0002085: Crash when loading a corrupt archive
DescriptionI got this message when the file "zdoom-dhtp-20130802.pk3" was inside skins folder, removing it stoped the problem.

Note:first I was only getting this image when I was trying to run it from doom builder, but I went to zandronum folder to run it just vanilla, and now I only get a crash report and not this pic anymore
'http://i.imgur.com/33playZ.png [^]'

It bugs when it reach the loading zdoomhtp line.
Steps To ReproduceInclude zdoom-dhtp-20130802.pk3 inside skins folder, have fun with software or gl
Additional InformationTested on zandronum 2.0 - 150118-1152.

Link to download the file:http://www.wad-archive.com/wad/de3e2dd0dcc6dc40144c352050df8117

On the official website there's a new version of hd texture pack, but idk if that will bug too'http://dhtp.freelanzer.com/?page_id=17 [^]'
TagsNo tags attached.
Relationships
has duplicate 0002153closed  Zandronum crashes with Address not mapped to object (signal 11) 
has duplicate 0002154closed  Crash when clicking on server 
Attached Fileszip CrashReport.zip (15,902) 2015-01-29 21:13
/tracker/file_download.php?file_id=1397&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-01-29 21:13ibm5155New Issue
2015-01-29 21:13ibm5155File Added: CrashReport.zip
2015-01-29 21:15ibm5155Note Added: 0011564
2015-01-29 21:21ibm5155Note Edited: 0011564bug_revision_view_page.php?bugnote_id=11564#r6547
2015-01-29 22:13DevilHunterNote Added: 0011565
2015-01-30 17:59ibm5155Note Added: 0011567
2015-01-30 19:44DrinkyBirdNote Added: 0011568
2015-01-30 19:51Edward-sanNote Added: 0011569
2015-01-31 00:33ibm5155Note Added: 0011573
2015-01-31 00:42ibm5155Note Edited: 0011573bug_revision_view_page.php?bugnote_id=11573#r6553
2015-02-15 21:08DuskTarget Version => 2.0
2015-03-08 21:06DuskNote Edited: 0011573bug_revision_view_page.php?bugnote_id=11573#r6733
2015-03-09 04:51DuskTarget Version2.0 =>
2015-04-02 17:59Torr SamahoRelationship addedhas duplicate 0002153
2015-04-02 18:01Torr SamahoSummaryRuntime Error! R6025 - Pure Virtual Function Call => Crash when loading a corrupt archive
2015-04-02 18:01Torr SamahoProduct Version2.0-beta => 2.0
2015-04-03 10:50Torr SamahoNote Added: 0012001
2015-04-03 12:25Torr SamahoRelationship addedhas duplicate 0002154
2015-04-12 07:19Torr SamahoNote Added: 0012091
2015-04-12 14:40ibm5155Note Added: 0012094
2015-04-12 14:41ibm5155Note Edited: 0012094bug_revision_view_page.php?bugnote_id=12094#r6949
2015-04-13 18:30Torr SamahoNote Added: 0012096
2015-04-13 19:18Edward-sanNote Added: 0012098
2015-04-13 19:37Edward-sanNote Edited: 0012098bug_revision_view_page.php?bugnote_id=12098#r6951
2015-04-13 19:37Edward-sanNote Edited: 0012098bug_revision_view_page.php?bugnote_id=12098#r6952
2015-04-13 19:48cobaltAssigned To => Torr Samaho
2015-04-13 19:48cobaltStatusnew => needs testing
2015-04-13 19:48cobaltTarget Version => 2.1
2015-04-13 19:48cobaltDescription Updatedbug_revision_view_page.php?rev_id=6954#r6954
2015-04-13 19:48cobaltAdditional Information Updatedbug_revision_view_page.php?rev_id=6956#r6956
2015-04-13 19:49cobaltNote Added: 0012099
2015-04-13 20:51Edward-sanNote Added: 0012102
2015-04-13 23:02ibm5155Note Added: 0012104
2015-04-13 23:07ibm5155Note Edited: 0012104bug_revision_view_page.php?bugnote_id=12104#r6958
2015-04-13 23:34ibm5155Note Edited: 0012104bug_revision_view_page.php?bugnote_id=12104#r6959
2015-04-13 23:46ibm5155Note Edited: 0012104bug_revision_view_page.php?bugnote_id=12104#r6960
2015-04-14 12:56Edward-sanNote Added: 0012107
2015-04-14 12:56Edward-sanStatusneeds testing => confirmed
2015-04-14 13:29Edward-sanStatusconfirmed => new
2015-04-18 16:54cobaltStatusnew => needs testing
2015-04-18 16:54cobaltNote Added: 0012136
2015-04-24 01:19HypnotoadNote Added: 0012164
2015-04-24 03:59DuskStatusneeds testing => resolved
2015-04-24 03:59DuskFixed in Version => 2.1
2015-04-24 03:59DuskResolutionopen => fixed
2018-09-30 21:38Blzut3Statusresolved => closed

Notes
(0011564)
ibm5155   
2015-01-29 21:15   
(edited on: 2015-01-29 21:21)
here's the zandronum "log"
OS: Windows NT (NT 6.2) Build 9200
    
M_LoadDefaults: Load system defaults.
Gameinfo scan took 5 ms
W_Init: Init WADfiles.
 adding C:/Program Files (x86)/Zandronum/zandronum.pk3, 694 lumps
 adding C:/Program Files (x86)/Zandronum/DOOM2.WAD, 2919 lumps
 adding C:/Program Files (x86)/Zandronum/skins/zdoom-dhtp-20130802.pk3
C:/Program Files (x86)/Zandronum/skins/zdoom-dhtp-20130802.pk3: ZIP file corrupt!

EDIT:ofc I didnt noticed the file was corrupt...
but, just saying, that didn't happened on 1.3, only on 2.0 it gave me this fatal error.
(0011565)
DevilHunter   
2015-01-29 22:13   
So.. the pk3 itself was corrupt? if so, this isn't a bug.. Also, this does not happen to me.
(0011567)
ibm5155   
2015-01-30 17:59   
Yes the pk3 was corrupted, but what I mean is, with zandronum 1.3 it just ignored the corrupted file and unload it, while here it crash if he found a corrupt pk3 file...

But, looking at zdoom 2.7, the same thing happened.
Well, I just think it's weird if you try to load a corrupt file you just crash the app and not just free the loaded file :S, but, it can be closed, since the same happens on 2.7.1
(0011568)
DrinkyBird   
2015-01-30 19:44   
I think there's still a bug. It should unload the PK3 as soon as it realises it's corrupt, and not crash.
(0011569)
Edward-san   
2015-01-30 19:51   
ibm5155, can you reproduce the crash with the last build of zdoom, in'http://devbuilds.drdteam.org/zdoom/ [^]' ?
(0011573)
ibm5155   
2015-01-31 00:33   
(edited on: 2015-03-08 21:06)
zdoom-2.8pre-287-g1e50a0a.7z crash (fatal error window)
zdoom-2.8pre-362-g79abe2d.7z crash (zdoom is not responding window)
zdoom-2.8pre-382-ga9bea7d.7z crash (runtime error)
zdoom-2.8pre-412-g584dd78.7z (corrupted build)
zdoom-2.8pre-412-g584dd78.7z crash (zdoom is not responding window)
zdoom-2.8pre-420-g3f8c723.7z crash (zdoom is not responding window)
zdoom-2.8pre-423-g94c4f38.7z works
zdoom-2.8pre-530-gbd5bf2a.7z works
zdoom-2.8pre-1132-gb69edbb.7z works

Problem fixed on:zdoom-2.8pre-423-g94c4f38.7z

EDIT:idk if I'm right (it's a bit confused the build release and the changelog on zdoom page), but, I think the problem was fixed here
'http://zdoom.org/Changelog/5c6ec94/files [^]'
(0012001)
Torr Samaho   
2015-04-03 10:50   
Can somebody provide a broken archive so that I can test this? The file linked to above works fine for me.
(0012091)
Torr Samaho   
2015-04-12 07:19   
This crash was reported three times. Yet, nobody is willing to provide an archive that causes the crash?
(0012094)
ibm5155   
2015-04-12 14:40   
(edited on: 2015-04-12 14:41)
Here we go :D
'http://www.mediafire.com/download/pc2wj1wsbjd4xfa/skulltag_actors_1-1-1+-+corrupt.pk3 [^]'

EDIT:Well, it's kinda easy, take a working pk3 file, open notepad++, add some stuff on the middle of the code and tadah :D
(0012096)
Torr Samaho   
2015-04-13 18:30   
The latest ZDoom build from'http://devbuilds.drdteam.org/zdoom/ [^]' (2.8pre-1399-g7217c69) crashes for me with your example wad. So looks like this problem is not fixed in ZDoom yet.
(0012098)
Edward-san   
2015-04-13 19:18   
(edited on: 2015-04-13 19:37)
To me it sounds like ibm5155 made the wrong example wad. ibm5155, did you lose the old file which was working for you in latest zdoom?

[edit] anyways, I can confirm it crashes with zdoom, so I filed a bug report here.
(0012099)
cobalt   
2015-04-13 19:49   
Issue addressed by commit 732cf98c3d10: out of sequence fix backport from ZDoom commit 3fa89b4e9fb9579b2b77927997dbc41c4cc876e8: Fixed crash on attempt to load corrupted data file Instance of FileReader is no longer destructed when header of data file is valid but complete loading of file fails Loading of truncated .zip file is the simplest test case -- This partially fixes 2085. Truncated .zip files seem to work now, but files where some garbage is added in the middle still cause a crash.
Committed by Benjamin Berkels [Torr Samaho] on Monday 13 April 2015 20:01:41

Changes in files:
 src/resourcefiles/file_7z.cpp | 2 ++
 src/resourcefiles/file_grp.cpp | 2 ++
 src/resourcefiles/file_pak.cpp | 2 ++
 src/resourcefiles/file_rff.cpp | 2 ++
 src/resourcefiles/file_wad.cpp | 2 ++
 src/resourcefiles/file_zip.cpp | 2 ++
 6 files changed, 12 insertions(+), 0 deletions(-)
(0012102)
Edward-san   
2015-04-13 20:51   
Graf fixed the issue with the current example wad with this commit.
(0012104)
ibm5155   
2015-04-13 23:02   
(edited on: 2015-04-13 23:46)
I think I've lost the main file that was causing the bug, but, good to know I already found another one rofl...

But I'm 70% right the file is on my first backup HDD (that thing is from the time of skulltag 97 hehe)

EDIT: WOW, I actually found after some minutes of research (windows search software) and found a desktop area over my external hdd, well, I'll upload this 127mb test xD


This is the file that I was talking about before:http://www.mediafire.com/download/m3zskjaqzwa40jk/zdoom-dhtp-20130802.pk3


EDIT2 : Status "needs testing", well, if I get some zandronum.exe I can test it :p (or some linux build [I can't remember right now if my linux vm is working :S ])
(0012107)
Edward-san   
2015-04-14 12:56   
It should not be 'needs testing' yet...
(0012136)
cobalt   
2015-04-18 16:54   
Issue addressed by commit ad971d3c9e89: out of sequence fix backport from ZDoom commit 6fc63daabd41a4dffbd63045ee72f1f3eb07bf82: - fixed: Zips whose central directory cannot be read need to print an error message. -- This fixes 2085.
Committed by Benjamin Berkels [Torr Samaho] on Saturday 18 April 2015 18:21:52

Changes in files:
 src/resourcefiles/file_zip.cpp | 22 +++++++++++++++-------
 1 files changed, 15 insertions(+), 7 deletions(-)
(0012164)
Hypnotoad   
2015-04-24 01:19   
Fix works fine when testing with IBM's wad, Zandronum logs it as corrupt in console and doesn't load it.