MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002084Doomseeker[All Projects] Suggestionpublic2015-01-28 23:142018-09-29 14:42
ReporterBlzut3 
Assigned ToBlzut3 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.0Fixed in Version1.0 
Summary0002084: Optional wad support improvements
DescriptionOptional wad support is currently pretty minimal (which makes sense it was a carry over from ZDaemon support).

Add support for flagging a file as optional when creating a server. Probably easiest to present a check box regardless if the engine supports optionals and then let the plugin return -optfile/-file accordingly.

Secondly, present some way to download optional files. Might be ideal to present a check list of optional files when downloading any missing required files. And/or provide a content menu option to download specific optional files or all.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-28 23:14Blzut3New Issue
2015-03-15 00:09Blzut3Note Added: 0011824
2015-03-15 00:09Blzut3Assigned To => Blzut3
2015-03-15 00:09Blzut3Statusnew => needs review
2015-03-15 10:25ZalewaNote Added: 0011826
2015-03-15 10:26ZalewaNote Edited: 0011826bug_revision_view_page.php?bugnote_id=11826#r6780
2015-03-16 06:37Blzut3Note Added: 0011837
2015-03-16 06:51Blzut3Note Edited: 0011837bug_revision_view_page.php?bugnote_id=11837#r6787
2015-03-16 17:50ZalewaNote Added: 0011845
2015-03-16 18:00ZalewaNote Added: 0011846
2015-04-06 10:06DevilHunterNote Added: 0012063
2015-04-06 10:07DevilHunterNote Edited: 0012063bug_revision_view_page.php?bugnote_id=12063#r6924
2015-04-06 20:08Blzut3Note Added: 0012065
2015-04-06 23:32DevilHunterNote Added: 0012069
2015-04-07 09:23DevilHunterNote Edited: 0012069bug_revision_view_page.php?bugnote_id=12069#r6930
2015-05-28 21:08Blzut3Statusneeds review => resolved
2015-05-28 21:08Blzut3Fixed in Version => 1.0
2015-05-28 21:08Blzut3Resolutionopen => fixed
2018-09-29 14:42WubTheCaptainStatusresolved => closed

Notes
(0011824)
Blzut3   
2015-03-15 00:09   
'https://bitbucket.org/Blzut3/doomseeker/commits/905977135020d873e24fe3b9374e214313750a85 [^]'
'https://bitbucket.org/Blzut3/doomseeker/commits/97563babf6ee6628f15ca0ddd9238f369e0e5271 [^]'
'https://bitbucket.org/Blzut3/doomseeker/commits/e2c7c4cd7529ef5936f39fd84ae2d051f00557d9 [^]'

Should be complete although I'll admit I didn't test it too heavily since it needed to be done sooner than later.
(0011826)
Zalewa   
2015-03-15 10:25   
(edited on: 2015-03-15 10:26)
There are some peculiarities.

1. When you try to "Find missing WADs" from the context menu on a passworded server, Doomseeker will first ask you to specify password instead of displaying the download box directly.

2. Using the context menu option mentioned before, when the only WADs that are missing are the optional WADs, and you deselect them in the confirmation box, Doomseeker will still open an empty Wadseeker dialog box. I think in this case an error message should be displayed instead, or the "Yes" button should become grayed out.
(0011837)
Blzut3   
2015-03-16 06:37   
(edited on: 2015-03-16 06:51)
'https://bitbucket.org/Blzut3/doomseeker/commits/fa2a0513ddeddd6472e51200cbdd8096e9409ebf [^]'

Both issues should be addressed.

Edit: Realized I was going to do your suggestion of disabling the button or something like that. Will further adjust it later I suppose. :P Just remembered why I was thinking the change would be difficult (pretty much need to make a new class for the dialog which we should probably have any way).
(0011845)
Zalewa   
2015-03-16 17:50   
Quote from Blzut3
pretty much need to make a new class for the dialog which we should probably have any way

Yeah, that'd be good.

Anyway, the feature seems to be working so I guess we can tick this one off. I'll release an update package right away.
(0011846)
Zalewa   
2015-03-16 18:00   
By the way, I'm still not getting notification emails...
(0012063)
DevilHunter   
2015-04-06 10:06   
(edited on: 2015-04-06 10:07)
So.. Does doomseeker know if its an optional wad?? and if so, is there an option im not seeing to make it not download the optional wad?

I notice this feature in DE (Doom Explorer), and it work awesomely.
(0012065)
Blzut3   
2015-04-06 20:08   
Optional wads should be marked in brackets, and if missing, appear orange in the tooltip.

Is there a particular server that seems to be demonstrating a problem?
(0012069)
DevilHunter   
2015-04-06 23:32   
(edited on: 2015-04-07 09:23)
Well what i mean is.. Is there anyway doomseeker knows its an Opt wad? And the User should choose weather or not he/she/it wants to download it or not.

There is an option in both IDE/DE that has a checkbox under Options>GetWAD labeled "Download Optional Wads"

EDIT: I just now noticed.. When right clicking on the server with a "missing" optional wad, there is an option to download missing wads, in where it tells me its an optional wad. My bad for missing this..

However, I doubt most know about this yet. Would be nice if people started using it heh.