MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002082 | Zandronum | [All Projects] Bug | public | 2015-01-25 11:18 | 2018-09-30 21:38 |
|
| Reporter | Zalewa | |
| Assigned To | Dusk | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 |
| Product Version | | |
| Target Version | 2.1 | Fixed in Version | 2.1 | |
|
| Summary | 0002082: .deh files are not reported by the server if they're loaded with -deh. |
| Description | To load a .deh file you need to use '-deh' argument. However, the .deh file loaded in such way is not reported by the server, so the server browser don't know that it needs to load it too when launching the client. .deh file is reported properly when loaded with '-file', but in such case its contents aren't really loaded by the game at all. |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | 0002081 | closed | Zalewa | Doomseeker | .deh/.bex files may need to be loaded with different cmd line args depending on game |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-01-25 11:18 | Zalewa | New Issue | |
| 2015-01-25 11:21 | Zalewa | Relationship added | related to 0002081 |
| 2015-03-29 19:08 | Dusk | Target Version | => 2.1 |
| 2015-03-30 13:54 | Dusk | Assigned To | => Dusk |
| 2015-03-30 13:54 | Dusk | Status | new => assigned |
| 2015-03-30 15:09 | Dusk | Note Added: 0011937 | |
| 2015-03-30 15:11 | Dusk | Status | assigned => needs review |
| 2015-03-30 16:05 | Zalewa | Note Added: 0011938 | |
| 2015-04-03 15:16 | Torr Samaho | Note Added: 0012005 | |
| 2015-04-03 15:16 | Torr Samaho | Status | needs review => feedback |
| 2015-04-03 15:21 | Torr Samaho | Note Edited: 0012005 | bug_revision_view_page.php?bugnote_id=12005#r6899 |
| 2015-04-03 18:53 | Dusk | Note Added: 0012009 | |
| 2015-04-03 18:53 | Dusk | Status | feedback => assigned |
| 2015-04-03 18:55 | Dusk | Note Edited: 0012009 | bug_revision_view_page.php?bugnote_id=12009#r6903 |
| 2015-04-25 16:35 | Dusk | Note Added: 0012170 | |
| 2015-04-25 16:35 | Dusk | Status | assigned => needs review |
| 2015-05-24 11:12 | cobalt | Status | needs review => needs testing |
| 2015-05-24 11:12 | cobalt | Note Added: 0012353 | |
| 2015-06-24 22:46 | Dusk | Status | needs testing => resolved |
| 2015-06-24 22:46 | Dusk | Fixed in Version | => 2.2 |
| 2015-06-24 22:46 | Dusk | Resolution | open => fixed |
| 2015-06-24 22:47 | Dusk | Fixed in Version | 2.2 => 2.1 |
| 2018-09-30 21:38 | Blzut3 | Status | resolved => closed |
|
Notes |
|
|
(0011937)
|
|
Dusk
|
|
2015-03-30 15:09
|
|
|
|
|
(0011938)
|
|
Zalewa
|
|
2015-03-30 16:05
|
|
|
|
|
(0012005)
|
|
Torr Samaho
|
2015-04-03 15:16
(edited on: 2015-04-03 15:21) |
|
Looks fine. Just two minor comments:
- Any particular reason why you implemented the same thing for SQF_OPTIONAL_WADS and SQF_DEH quite differently, i.e.
// [TP] Optional wads
if ( ulFlags & SQF_OPTIONAL_WADS )
{
int numIndices = NETWORK_ReadByte( pByteStream );
while ( numIndices-- )
NETWORK_ReadByte( pByteStream );
}
vs.
// [TP] Dehacked patches
if ( ulFlags & SQF_DEH )
{
for ( int i = NETWORK_ReadByte( pByteStream ); i > 0; --i )
NETWORK_ReadString( pByteStream );
}
? Both code snippets are perfectly fine, it's just a little strange to see the very same thing being implemented differently, even though the code snippets are right after each other in the source and were implemented by the same person ;).
- SQF_OPTIONAL_WADS has
// [TP] Don't send optional wads if there isn't any.
if ( g_OptionalWadIndices.Size() == 0 )
ulBits &= ~SQF_OPTIONAL_WADS;
SQF_DEH doesn't do this. Wouldn't it be nicer to have the two things behave consistently?
EDIT: Tiny thing: The history entry has "-" and "+" switched, but I can easily correct this locally.
|
|
|
|
(0012009)
|
|
Dusk
|
2015-04-03 18:53
(edited on: 2015-04-03 18:55) |
|
Quote
Any particular reason why you implemented the same thing for SQF_OPTIONAL_WADS and SQF_DEH quite differently
Because somebody said I'm not supposed to change unrelated code in patches. :p
TBH I didn't even notice this.
Quote
SQF_OPTIONAL_WADS has <code> SQF_DEH doesn't do this. Wouldn't it be nicer to have the two things behave consistently?
That's a minor oversight indeed. I'll fix this.
|
|
|
|
(0012170)
|
|
Dusk
|
|
2015-04-25 16:35
|
|
|
|
|
(0012353)
|
|
cobalt
|
|
2015-05-24 11:12
|
|
|