MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002075Zandronum[All Projects] Bugpublic2015-01-21 18:502018-09-30 23:04
ReporterInkubus 
Assigned ToTorr Samaho 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformpcOSWindowsOS Version8.1
Product Version2.0-beta 
Target VersionFixed in Version2.0 
Summary0002075: Program crash when activating Polyobj_DoorSwing
DescriptionWhen activating a polyobj that is meant to swing open, Zandronum crashes. The map is in UDMF format. In Doom in Hexen format, the polyobj swings as intended with no crash, so it only happens in UDMF.
Steps To ReproduceIn the wad provided, simply press on the bookcase. It should swing open but instead the game crashes.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? Polyobj Crash.wad (7,820) 2015-01-21 18:50
https://zandronum.com/tracker/file_download.php?file_id=1388&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-01-21 18:50InkubusNew Issue
2015-01-21 18:50InkubusFile Added: Polyobj Crash.wad
2015-01-21 18:54Torr SamahoNote Added: 0011481
2015-01-21 20:21WaTaKiDNote Added: 0011487
2015-01-21 20:58InkubusNote Added: 0011491
2015-01-23 11:44Edward-sanNote Added: 0011515
2015-01-23 11:45Edward-sanNote Edited: 0011515bug_revision_view_page.php?bugnote_id=11515#r6514
2015-01-23 11:47Edward-sanNote Edited: 0011515bug_revision_view_page.php?bugnote_id=11515#r6515
2015-01-23 11:47Edward-sanAssigned To => Torr Samaho
2015-01-23 11:47Edward-sanStatusnew => assigned
2015-01-23 11:51Edward-sanNote Edited: 0011515bug_revision_view_page.php?bugnote_id=11515#r6516
2015-01-23 13:20Edward-sanNote Edited: 0011515bug_revision_view_page.php?bugnote_id=11515#r6517
2015-01-23 15:20Edward-sanNote Edited: 0011515bug_revision_view_page.php?bugnote_id=11515#r6518
2015-01-23 15:22Edward-sanNote Edited: 0011515bug_revision_view_page.php?bugnote_id=11515#r6519
2015-01-25 10:16Torr SamahoNote Added: 0011526
2015-01-25 10:16Torr SamahoStatusassigned => needs testing
2015-01-25 19:52WaTaKiDNote Added: 0011545
2015-01-25 21:24DuskStatusneeds testing => resolved
2015-01-25 21:24DuskFixed in Version => 2.0
2015-01-25 21:24DuskResolutionopen => fixed
2018-09-30 23:04Blzut3Statusresolved => closed

Notes
(0011481)
Torr Samaho   
2015-01-21 18:54   
Thanks! I can reproduce the crash in Zandronum 2.0 and also in GZDoom revision 900. It's fixed in recent GZDoom versions though. Can somebody check when (G)ZDoom fixed this?
(0011487)
WaTaKiD   
2015-01-21 20:21   
if it helps, the crash stops with gzdoom 1.6.0-r1418, tho when 'using' the polyobject, it seems to work fine but displays an error message:
"Invalid mirror polyobj num -45 for polyobj num 1"
i dont know anything about polyobjects so idk if this is mapper error or wut, but the message goes away with 1.8.2

for zdoom: 2.6.0: no crash, 2.7.1: no message
(0011491)
Inkubus   
2015-01-21 20:58   
Thanks, I noticed the message as well when playing on zdoom.
(0011515)
Edward-san   
2015-01-23 11:44   
(edited on: 2015-01-23 15:22)
It's fixed in r3288. Applied the patch (only po_man.cpp) to 2.0, works like a charm offline. When static code analysis (done by me) helps finding issues ...

Meanwhile, with the fix, online, there's an inconsistency, which happens when a client blocks a polyobject: offline, the polyobject is blocked until the player moves away, but online, the client sees the polyobject rotate continuously, even if it should not, until the client moves away, then the polyobject works fine.

[edit] Just mentioning that this commit is the same as the one reported in 0001910 , with the changes in p_setup.cpp.

[edit] Ok, I'll move discussion of the problems with the fixed program on another ticket, in order to keep it clean from the original purpose of this ticket, ie just fix the crash.
(0011526)
Torr Samaho   
2015-01-25 10:16   
I backported the fix.
(0011545)
WaTaKiD   
2015-01-25 19:52   
after testing with 2.0-r150125-1008, crash seems fixed (that message is gone too)