MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002060Doomseeker[All Projects] Suggestionpublic2015-01-10 08:292018-09-29 14:43
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version1.0 
Summary0002060: Query speed - introduce preset buttons
DescriptionRight now the "query" config page has a lot of settings that can be confusing to an average user. We could add a bunch of buttons there with presets like "aggressive", "cautious", "average" and explain what they do in tooltips. The buttons wouldn't do anything more than just setting the already exsiting widgets to some predefined value. The "cautious" setting would be the default one.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng queryspeeds.png (50,742) 2015-01-19 21:18
https://zandronum.com/tracker/file_download.php?file_id=1383&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-01-10 08:29ZalewaNew Issue
2015-01-19 21:18ZalewaFile Added: queryspeeds.png
2015-01-19 21:20ZalewaNote Added: 0011450
2015-01-19 21:20ZalewaAssigned To => Zalewa
2015-01-19 21:20ZalewaStatusnew => assigned
2015-01-19 21:20ZalewaStatusassigned => needs review
2015-01-21 16:30ZalewaNote Added: 0011478
2015-01-21 16:30ZalewaStatusneeds review => needs testing
2015-01-21 19:55HypnotoadNote Added: 0011482
2015-01-21 19:57HypnotoadNote Edited: 0011482bug_revision_view_page.php?bugnote_id=11482#r6490
2015-01-21 19:58ZalewaNote Added: 0011483
2015-01-21 20:02Blzut3Note Added: 0011484
2015-01-21 20:05ZalewaNote Added: 0011485
2015-01-21 20:35HypnotoadNote Added: 0011488
2015-01-21 20:35HypnotoadNote Edited: 0011488bug_revision_view_page.php?bugnote_id=11488#r6492
2015-01-21 20:45ZalewaNote Added: 0011489
2015-01-21 20:49HypnotoadNote Added: 0011490
2015-01-28 16:14ZalewaStatusneeds testing => resolved
2015-01-28 16:14ZalewaFixed in Version => 1.0
2015-01-28 16:14ZalewaResolutionopen => fixed
2015-01-29 00:39Blzut3Note Added: 0011557
2015-01-29 06:04ZalewaNote Added: 0011559
2015-01-29 07:39ZalewaNote Added: 0011560
2015-01-29 11:37ZalewaNote Added: 0011561
2015-01-29 11:37ZalewaStatusresolved => assigned
2015-01-29 16:24ZalewaNote Added: 0011562
2015-01-29 16:24ZalewaStatusassigned => resolved
2018-09-29 14:43WubTheCaptainStatusresolved => closed

Notes
(0011450)
Zalewa   
2015-01-19 21:20   
Change:'https://bitbucket.org/Blzut3/doomseeker/commits/b0d096ffbee41e347767a4b9456cfdf4a8f0f0d0 [^]'

I've also attached a screenshot showing how this looks now.
The values for presets are following:

Cautious:
Attempts = 3
Delay between attempts = 3500ms
Interval between servers = 60ms

Moderate:
Attempts = 3
Delay between attempts = 3000ms
Interval between servers = 30ms

Aggressive:
Attempts = 3
Delay between attempts = 2000ms
Interval between servers = 10ms
(0011478)
Zalewa   
2015-01-21 16:30   
Update on "Beta" channel is now available. Please verify if all buttons work as intended and whether refresh operations still work.
(0011482)
Hypnotoad   
2015-01-21 19:55   
(edited on: 2015-01-21 19:57)
I just did the auto update on the beta channel, and now no servers are displayed at all.

edit: I changed to 'cautious' query settings as suggested by Blzut3, but this did not fix anything. Here is my log output:

[19:56:50] Total refresh process initialized!
[19:56:50] Removing old update packages from local temporary space.
[19:56:50] Checking for updates...
[19:56:50] IP2C database read in 72 ms. Entries read: 140154
[19:56:50] IP2C parsing thread has finished.
[19:56:50] IP2C database updated successfully.
[19:56:50] IP2C parsing finished.
[19:56:50] IP2C update finished.
[19:56:50] No new program updates detected.
[19:56:50] Program update detection & download finished with status: [0] Ok
(0011483)
Zalewa   
2015-01-21 19:58   
What does the log say when you refresh? Can you refresh or is the button grayed out? Make sure that Zandronum plugin is enabled in 'Query' menu or in bottom-right corner. Perhaps you could try moving out doomseeker.ini from %APPDATA%/.doomseeker somewhere else (just change its name) and trying again? If resetting the .ini file helps, please attach the offending one (don't forget to prune the passwords first).
(0011484)
Blzut3   
2015-01-21 20:02   
Just adding a note to point out that Jroc edited his post with the log output in the time you were writing that response.
(0011485)
Zalewa   
2015-01-21 20:05   
Yes, I noticed. But apart of missing refresh completion message I see nothing out of the ordinary in this log.

I just tried updating Doomseeker from stable version to newest beta on another PC and it works fine there.
(0011488)
Hypnotoad   
2015-01-21 20:35   
I'm not even able to do total refresh on the top left, it remains greyed out as doomseeker is stuck on "Querying...". Zandronum and Odamex are both enabled in the query menu and in the bottom right corner. Unfortunately resetting the .ini did not fix the issue.

By the way, I updated from the previous beta, not from the stable branch initially. If I revert back to the stable branch however, it works fine.
(0011489)
Zalewa   
2015-01-21 20:45   
Argh!!! Thanks for testing. I just uploaded a new build to the beta channel. Check it out, please.
(0011490)
Hypnotoad   
2015-01-21 20:49   
Downloaded the update, issue is fixed now thanks.
(0011557)
Blzut3   
2015-01-29 00:39   
Might be an issue with the settings transfer. I think people are being set with a 50ms delay which drastically slows down the query speed when upgrading.
(0011559)
Zalewa   
2015-01-29 06:04   
That would be strange given that the default setting is "moderate", which is 30ms, and there's also no preset that would be 50ms. "cautious" is 60ms.
(0011560)
Zalewa   
2015-01-29 07:39   
Thinking of it now, I made the change backwards compatible. All refresh intervals are still read from the same configuration settings as before. The old default was in fact 50ms, and so it remains at 50ms. Upon deleting the .ini file I get 30ms. Perhaps it would be better to move these values to new configuration settings so that they get reset to the current defaults.
(0011561)
Zalewa   
2015-01-29 11:37   
I'm reopening this so that I don't forget to change the settings so that they reset.
(0011562)
Zalewa   
2015-01-29 16:24   
And done:'https://bitbucket.org/Blzut3/doomseeker/commits/d624df71ec13d814ac3f1c2381d97134f8a802b0 [^]'