MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002042Zandronum[All Projects] Bugpublic2015-01-01 22:002018-09-30 23:10
ReporterDusk 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002042: A_WeaponBob exists
Description'http://zdoom.org/wiki/A_WeaponBob [^]'

Quote

    11:50, 19 July 2009 Graf Zahl (Talk | contribs) deleted page A WeaponBob (A_WeaponBob only existed in a few SVN revisions. No need to document a non-existent feature.)


Zandronum 2.0 has this and it sounds like it's something we don't want to keep around.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-01 22:00DuskNew Issue
2015-01-01 22:01DuskProduct Version2.0 => 2.0-beta
2015-01-01 22:15Edward-sanNote Added: 0011198
2015-01-01 22:17DuskNote Added: 0011199
2015-01-01 22:20Edward-sanNote Added: 0011200
2015-01-01 22:21Edward-sanNote Edited: 0011200bug_revision_view_page.php?rev_id=6235
2015-01-01 22:30Edward-sanNote Edited: 0011200bug_revision_view_page.php?rev_id=6236
2015-01-01 22:32Edward-sanNote Deleted: 0011200
2015-01-01 22:39DuskNote Edited: 0011199bug_revision_view_page.php?bugnote_id=11199#r6238
2015-01-01 22:48DuskNote Edited: 0011199bug_revision_view_page.php?bugnote_id=11199#r6239
2015-01-01 22:49DuskNote Edited: 0011199bug_revision_view_page.php?bugnote_id=11199#r6240
2015-01-01 22:53Edward-sanNote Added: 0011202
2015-01-01 22:54Edward-sanNote Edited: 0011202bug_revision_view_page.php?bugnote_id=11202#r6242
2015-01-01 22:54DuskNote Edited: 0011199bug_revision_view_page.php?bugnote_id=11199#r6243
2015-01-02 13:16cobaltAssigned To => Torr Samaho
2015-01-02 13:16cobaltStatusnew => needs testing
2015-01-02 13:16cobaltTarget Version => 2.0
2015-01-02 13:16cobaltDescription Updatedbug_revision_view_page.php?rev_id=6255#r6255
2015-01-02 13:17cobaltNote Added: 0011208
2015-01-02 13:18Torr SamahoNote Added: 0011209
2015-01-02 13:23cobaltNote Added: 0011210
2015-01-02 13:27Torr SamahoNote Deleted: 0011208
2015-01-05 20:11DuskNote Added: 0011291
2015-01-05 20:11DuskStatusneeds testing => resolved
2015-01-05 20:11DuskFixed in Version => 2.0
2015-01-05 20:11DuskResolutionopen => fixed
2018-09-30 23:10Blzut3Statusresolved => closed

Notes
(0011198)
Edward-san   
2015-01-01 22:15   
To be more precise, it was introduced in ZDoom r1698, then it was removed in r1711.
(0011199)
Dusk   
2015-01-01 22:17   
(edited on: 2015-01-01 22:54)
Was removed here:'http://zdoom.org/Changelog/23e4c47/files [^]' (thanks edward-san for pointing this out)
Looks like it was otherwise backported but the action function implementation was never removed. It looks like it's not exported to DECORATE through an 'action native' statement in Inventory currently either.

EDIT:
So turns out this was first backported out of sequence (what.) and then backported in sequence. It must've been removed somewhere in between, can't find out where...
(0011202)
Edward-san   
2015-01-01 22:53   
(edited on: 2015-01-01 22:54)
In other words:

- Backport out-of-sequence of zdoom r1689
- Backport out-of-sequence of zdoom r1711 (which removed A_WeaponBob properly)
- Backport in sequence of r1689
- Backport inf sequence of r1711 (whoops!)
(0011209)
Torr Samaho   
2015-01-02 13:18   
You are right, this was a merge error. The code is removed now.
(0011210)
cobalt   
2015-01-02 13:23   
Issue addressed by commit 8ad299b21096: Removed some obsolete ZDoom code that already should have been removed in 81e9ceb7635539aa528e7db49c999e23365c6f67 (fixes 2042).
Committed by Benjamin Berkels [Torr Samaho] on Friday 02 January 2015 14:12:11

Changes in files:
 src/p_pspr.cpp | 23 -----------------------
 1 files changed, 0 insertions(+), 23 deletions(-)
(0011291)
Dusk   
2015-01-05 20:11   
Since we ultimately only ended up removing dead code, there is no testing to do.