MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002024Zandronum[All Projects] Suggestionpublic2014-12-09 17:572015-01-10 11:36
ReporterVicious Pariah 
Assigned ToDusk 
PrioritylowSeveritytweakReproducibilityN/A
StatusfeedbackResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.3 
Target VersionFixed in Version 
Summary0002024: Zandronum server statistics in Windows -- make ccmd to allow access to this data outside of server window (via RCON)
DescriptionSee attached picture.

In Windows, Zandronum is able to accurately track the average number of players as well as the peak number of players in a server, among other things.

As far as I know, I do not believe this is available to the admin via a ccmd. So, this could even be a feature limited only to Windows, and probably doesn't really make a lot of sense.

If this ccmd could be added, then that would be great!

-VP
Steps To ReproduceStart a server in Windows.

Go to File -> Statistics...

This will show you the information. Attached is also a picture of what the statistics window looks like.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng zandro server stats.png (25,568) 2014-12-09 17:57
/tracker/file_download.php?file_id=1344&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-12-09 17:57Vicious PariahNew Issue
2014-12-09 17:57Vicious PariahFile Added: zandro server stats.png
2014-12-09 19:35DuskAssigned To => Dusk
2014-12-09 19:35DuskStatusnew => assigned
2014-12-22 04:16DevilHunterNote Added: 0011083
2014-12-25 00:22DuskNote Added: 0011090
2014-12-25 00:22DuskStatusassigned => needs review
2014-12-28 15:43Torr SamahoNote Added: 0011099
2014-12-28 15:43Torr SamahoStatusneeds review => feedback
2015-01-09 16:39DuskNote Added: 0011344
2015-01-10 11:36Torr SamahoNote Added: 0011348

Notes
(0011083)
DevilHunter   
2014-12-22 04:16   
Would be nice to have.. No clue how to make this work however
(0011090)
Dusk   
2014-12-25 00:22   
Branch here:'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/branch/serverstats_ccmd [^]'
Could use a comment before I pull request it.
(0011099)
Torr Samaho   
2014-12-28 15:43   
From what I can tell, you are not only adding the new command serverstats, but also change how the Windows server console displays the stats. In particular, the uptime string gets much longer since you write out the "time words". The server window has limited space, so I think it's not a good idea to make this string longer. Also, SERVER_FormatBytes formats values below 1 KB different from all other values (and different from the old code). Is this intentional?

Other than that you change the existing display used by the Windows server console, the patch looks fine.

On a side note: If you want to slightly reduce code duplication, you could introduce SERVER_STATISTIC_GetAverageInboundDataTransfer/OutboundDataTransfer/Numplayers and use this in your new command and in the server console code. That's not a must though.
(0011344)
Dusk   
2015-01-09 16:39   
I made the server console display short time again.

Quote
Also, SERVER_FormatBytes formats values below 1 KB different from all other values (and different from the old code). Is this intentional?

I thought it'd be clearer for it to be printed this way rather than just printing a number which could be interpreted as anything.
(0011348)
Torr Samaho   
2015-01-10 11:36   
Quote from Dusk

I thought it'd be clearer for it to be printed this way rather than just printing a number which could be interpreted as anything.

I must be overlooking something. The old way always displayed a unit behind the number and didn't leave any room for interpretation (aside from whether 1000 or 1024 is used to go from one prefix to the next, but the new display doesn't change this either).