MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002022Zandronum[All Projects] Suggestionpublic2014-12-09 00:022014-12-31 11:01
ReporterCh0wW 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusnewResolutionopen 
PlatformAnyOSOS Version
Product Version1.3 
Target VersionFixed in Version 
Summary0002022: cl_spectator_flybob CVAR
Descriptioncl_spectator_flybob is a CVAR that disables flybob as a spectator.
It is a feature ported from prodamex, a (now dead) competitive port made specifically from odamex 0.6.4.
Steps To ReproduceTo keep it simple:

1) in p_mobj.cpp OR p_user.cpp
2) Check in P_CalcHeight the bob when the player is not on the ground.
3) Check in P_ZMovement the z position when the player is in the air.

The file provided gives the code to modify.
Additional InformationFind a way to reset to 0 the z floating bob when cl_spectator_flybob is set to 0.
TagsNo tags attached.
Relationships
Attached Filestxt cl_spectator_flybob.txt (1,696) 2014-12-09 00:02
/tracker/file_download.php?file_id=1342&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-12-09 00:02Ch0wWNew Issue
2014-12-09 00:02Ch0wWFile Added: cl_spectator_flybob.txt
2014-12-09 00:14DuskNote Added: 0011048
2014-12-09 00:15DuskNote Edited: 0011048bug_revision_view_page.php?bugnote_id=11048#r6130
2014-12-09 00:45Ch0wWNote Added: 0011049
2014-12-09 00:50Ch0wWNote Edited: 0011049bug_revision_view_page.php?bugnote_id=11049#r6132
2014-12-09 00:50Ch0wWNote Edited: 0011049bug_revision_view_page.php?bugnote_id=11049#r6133
2014-12-09 00:54Ch0wWNote Edited: 0011049bug_revision_view_page.php?bugnote_id=11049#r6134
2014-12-31 11:01Torr SamahoProduct Version2.0-beta => 1.3

Notes
(0011048)
Dusk   
2014-12-09 00:14   
(edited on: 2014-12-09 00:15)
Please provide patches in diff format, they would be easier to deal with than text files like this. Also I don't think the bob field does anything for spectators. What is desired is the modification of the mo->z field.

I have an implementation on disabling the flybob as well stashed though it's a boolean cvar. I didn't finish it because I also wanted to remove the sliding of the spectator movement.
(0011049)
Ch0wW   
2014-12-09 00:45   
(edited on: 2014-12-09 00:54)
Sorry for the .diff format, but when doing so, it reveals also every patch i'm doing, and that's not the thing I want. I'll try to find a solution next time.

- For the movebob: Check by yourself:
> SP => movebob 0 + sv_cheats 1 + Fly cmd.
You'll notice that you'll get a very very low bobbing.

As Spectators are exactly like a player without a weapon, that check and modification was done.

For the boolean, I also did it, but people could appreciate having an extremely low flyingbob when spectating. Hence the [0<x<1] float, or even for future moviemaking.

EDIT: And it's not that important if the sliding is still present or not. People that are joining with the cvar set to 0 will be on the ground first. (so maybe set the z value of the ground or ceiling when the spectator hits it could be a possible solution to have)