MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002010Zandronum[All Projects] Bugpublic2014-11-25 19:322017-11-08 21:40
ReporterCh0wW 
Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionunable to reproduce 
PlatformAnyOSAnyOS VersionAny
Product Version1.3 
Target VersionFixed in Version 
Summary0002010: Admin lists aren't working at all.
DescriptionI tried to understand why the adminlists aren't letting me to connect on the server when it was full.

It simply looks like it doesn't work at all, as it doesn't understand the netadress of the player.

It confirmed when I tried Konar6's patch with auto-rcon for people in the adminlist.

Steps To Reproduce[PRE-REQUISITES] Get yourself into the Adminlist file.

1) Join a server full (or make a server with sv_maxclients to 0)
2) Join it.
3) "Server is full" while it should accept you.
Additional Information======= FIXING THE PROBLEM ========

In SV_MAIN.CPP :

Line 1994:

Replace:
if ( g_AdminIPList.isIPInList ( AddressFrom ) )
By:
if ( SERVER_GetAdminList()->isIPInList ( szAddress ))

vvvvvvvvvvvvvvvvvvvvvv

For Konar6:

Replace:
if ( SERVER_GetAdminList()->isIPInList( SERVER_GetClient( lClient )->Address ) )
by:
if ( g_AdminIPList.isIPInList( szAddress ) )
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-25 19:32Ch0wWNew Issue
2014-11-25 20:02Ch0wWNote Added: 0010975
2014-11-25 20:41Ch0wWNote Edited: 0010975bug_revision_view_page.php?bugnote_id=10975#r6031
2014-11-25 21:38DevilHunterNote Added: 0010976
2014-12-02 13:52DuskNote Added: 0011026
2014-12-02 13:52DuskStatusnew => feedback
2017-11-08 21:40DuskNote Added: 0018826
2017-11-08 21:40DuskStatusfeedback => closed
2017-11-08 21:40DuskResolutionopen => unable to reproduce

Notes
(0010975)
Ch0wW   
2014-11-25 20:02   
(edited on: 2014-11-25 20:41)
for the fix, I forgot to add this, which should be ABOVE:

NETWORK_AddressToIPStringArray( AddressFrom, szAddress );

So it works for [Maxplayers]+1 person... Kinda strange then, if we have the possibility to add multiple admins to the list, don't you think?

If multiple admins would connect to it, other than localhost, what could we do, unless commenting the very first check for the SERVER_FindFreeClientSlot( void ) function?
(0010976)
DevilHunter   
2014-11-25 21:38   
It works fine for me™
(0011026)
Dusk   
2014-12-02 13:52   
SERVER_GetAdminList returns a pointer to g_AdminIPList. How does changing the way it's called fix any scemantic behavior?

To me this sounds like the problem in 0001194. What happens if you revert the change and compile the binary? Do admin lists work then?
(0018826)
Dusk   
2017-11-08 21:40   
Still works fine for me and no feedback was given, closing.