MantisBT - Zandronum
View Issue Details
0001977Zandronum[All Projects] Suggestionpublic2014-10-29 17:282018-09-30 23:33
Karakurt 
Torr Samaho 
normalfeatureN/A
closedfixed 
WIndowsWindowsn 764 bits
1.3 
1.41.4 
0001977: Requesting screenshot_scores
When enabled, screenshot_scores (aka screenshot_intermission) do an automatic screen of the intermission.
No tags attached.
Issue History
2014-10-29 17:28KarakurtNew Issue
2014-10-29 17:35KarakurtNote Added: 0010714
2014-10-29 18:03KarakurtNote Edited: 0010714bug_revision_view_page.php?rev_id=5877
2014-10-29 19:49DuskDescription Updatedbug_revision_view_page.php?rev_id=5881#r5881
2014-10-29 19:50DuskNote Deleted: 0010714
2014-10-29 20:13WatermelonNote Added: 0010721
2014-10-29 23:50CatastropheNote Added: 0010725
2014-10-29 23:50CatastropheNote Edited: 0010725bug_revision_view_page.php?bugnote_id=10725#r5885
2014-10-30 13:21KarakurtNote Added: 0010732
2014-10-30 13:34WatermelonNote Added: 0010733
2014-10-30 13:56CatastropheNote Added: 0010734
2014-10-30 16:49DuskNote Added: 0010737
2014-10-30 18:02KarakurtNote Added: 0010739
2014-10-30 22:42WatermelonNote Added: 0010741
2014-10-30 22:42WatermelonAssigned To => Watermelon
2014-10-30 22:42WatermelonStatusnew => needs review
2014-10-31 02:42DuskNote Added: 0010745
2014-10-31 02:56DuskNote Edited: 0010745bug_revision_view_page.php?bugnote_id=10745#r5896
2014-11-01 00:25WatermelonNote Added: 0010754
2014-11-01 11:32Torr SamahoNote Added: 0010760
2014-11-01 11:33Torr SamahoStatusneeds review => feedback
2014-11-02 19:22WatermelonNote Added: 0010796
2014-11-02 19:22WatermelonStatusfeedback => needs review
2014-11-02 20:57KarakurtNote Added: 0010799
2014-11-02 22:20KarakurtNote Edited: 0010799bug_revision_view_page.php?bugnote_id=10799#r5922
2014-11-03 03:53WatermelonNote Added: 0010809
2014-11-03 12:41DuskNote Added: 0010811
2014-11-03 12:42DuskNote Edited: 0010811bug_revision_view_page.php?bugnote_id=10811#r5933
2014-11-03 13:39KarakurtNote Added: 0010812
2014-11-03 15:13WatermelonNote Added: 0010813
2014-11-03 19:51Torr SamahoNote Added: 0010817
2014-11-03 19:52Torr SamahoStatusneeds review => feedback
2014-11-10 03:27WatermelonNote Added: 0010851
2014-11-10 03:27WatermelonStatusfeedback => needs review
2014-11-10 22:37WatermelonNote Added: 0010853
2014-11-15 14:51cobaltStatusneeds review => needs testing
2014-11-15 14:51cobaltTarget Version => 1.4
2014-11-15 14:51cobaltNote Added: 0010887
2014-11-15 15:01cobaltNote Added: 0010888
2014-11-15 15:02DuskNote Deleted: 0010888
2014-11-21 12:04ArcoStatusneeds testing => feedback
2014-11-21 12:04ArcoAdditional Information Updatedbug_revision_view_page.php?rev_id=5988#r5988
2014-11-21 12:04ArcoNote Added: 0010915
2014-11-21 12:04ArcoAdditional Information Updatedbug_revision_view_page.php?rev_id=5989#r5989
2014-11-21 12:06ArcoNote Edited: 0010915bug_revision_view_page.php?bugnote_id=10915#r5991
2014-11-21 15:02KarakurtNote Added: 0010918
2014-11-21 15:02KarakurtStatusfeedback => assigned
2014-11-21 15:14WatermelonNote Added: 0010919
2014-11-21 15:55KarakurtNote Added: 0010920
2014-11-21 17:17WatermelonNote Added: 0010921
2014-11-21 17:41DuskNote Added: 0010922
2014-11-21 18:42KarakurtNote Added: 0010924
2014-11-21 19:51DuskNote Deleted: 0010924
2014-11-24 12:56WatermelonNote Added: 0010950
2014-11-24 12:56WatermelonStatusassigned => needs review
2014-11-24 19:18DuskNote Added: 0010956
2014-11-24 19:23Torr SamahoNote Added: 0010959
2014-11-24 19:24Torr SamahoStatusneeds review => feedback
2014-11-24 22:44DuskNote Added: 0010964
2014-11-24 22:49DuskNote Edited: 0010964bug_revision_view_page.php?bugnote_id=10964#r6023
2014-12-04 04:30WatermelonStatusfeedback => assigned
2014-12-31 11:16Torr SamahoProduct Version2.0-beta => 1.3
2015-01-01 17:44Torr SamahoNote Added: 0011166
2015-01-01 17:44Torr SamahoAssigned ToWatermelon => Torr Samaho
2015-01-01 17:44Torr SamahoStatusassigned => needs testing
2015-01-01 17:54cobaltNote Added: 0011168
2015-01-18 03:46WaTaKiDNote Added: 0011422
2015-01-18 11:00Torr SamahoNote Added: 0011432
2015-01-18 11:11WaTaKiDNote Added: 0011435
2015-01-18 11:14Torr SamahoNote Added: 0011436
2015-01-19 15:04fulecoNote Added: 0011445
2015-01-19 19:48Torr SamahoNote Added: 0011446
2015-01-20 14:51fulecoNote Added: 0011457
2015-01-21 07:06Torr SamahoNote Added: 0011468
2015-01-21 07:06Torr SamahoNote Edited: 0011468bug_revision_view_page.php?bugnote_id=11468#r6477
2015-01-21 15:33LeonardNote Added: 0011474
2015-03-16 20:05StrikerMan780Note Added: 0011856
2015-03-17 00:27DuskStatusneeds testing => resolved
2015-03-17 00:27DuskFixed in Version => 1.4
2015-03-17 00:27DuskResolutionopen => fixed
2018-09-30 23:33Blzut3Statusresolved => closed

Notes
(0010721)
Watermelon   
2014-10-29 20:13   
bind z "+showscores; wait 1; screenshot; wait 1;-showscores;"

I thought this would work but someone might be able to refine something better. It keeps auto screenshotting if I hold 'z' down sadly.
(0010725)
Catastrophe   
2014-10-29 23:50   
You misinterpreted water. He wants a cvar that automatically screenshots end game results. As in, auto screenie the intermission screen.

(0010732)
Karakurt   
2014-10-30 13:21   
Eh sorry for that. I just noticed that you thought I was talking about showing scores for an amount of time, just like you've done for Zan+.
(0010733)
Watermelon   
2014-10-30 13:34   
Ah I see, my mistake.

I'm guessing the most reasonable way to do this would be to screenshot as soon as the gamestate changes to intermission and is rendered?


My plan is to notice when it changes from any gamestate to the intermission gamestate, and then take a screenshot there after the scoreboard rendering is done. This should be possible, when I get home later today I'll make up a cvar for it.


cl_screenshot_scores?
(0010734)
Catastrophe   
2014-10-30 13:56   
Sounds clear to me.
(0010737)
Dusk   
2014-10-30 16:49   
Maybe 'screenshot_intermissions' for the CVar name?
(0010739)
Karakurt   
2014-10-30 18:02   
Yeah sounds better. Screenshot_scores might be confusing actualy, hence why Water has been.
(0010741)
Watermelon   
2014-10-30 22:42   
Pull req. sent
(0010745)
Dusk   
2014-10-31 02:42   
(edited on: 2014-10-31 02:56)
Instead of detecting gamestate changes you should probably do the auto-screenshot in WI_Start.

Thinking further, the CVAR could also be called "wi_autoscreenshot".

(0010754)
Watermelon   
2014-11-01 00:25   
Is the full scoreboard rendered there if I put it in WI_Start?
(0010760)
Torr Samaho   
2014-11-01 11:32   
I agree with Dusk, this should be doable without trying to manually detect gamestate changes. WI_Start should be a good starting point.
(0010796)
Watermelon   
2014-11-02 19:22   
Updated to the better WI_ version:
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/96/added-a-cvar-to-allow-screenshots-to/diff [^]'
(0010799)
Karakurt   
2014-11-02 20:57   
(edited on: 2014-11-02 22:20)
Thanks for adding it up anyway!!!

(0010809)
Watermelon   
2014-11-03 03:53   
We have two options:

1) wi_autoscreenshot
2) autoscreenshot

Torr can you choose the one you want to see? Then I'll commit it.
(0010811)
Dusk   
2014-11-03 12:41   
(edited on: 2014-11-03 12:42)
A 'wi_' prefix is needed for the name to imply being related to intermissions...

(0010812)
Karakurt   
2014-11-03 13:39   
Yeah Dusk is right actually. Didn't know there were commands starting with this prefix. Anyway how will that work on the multiplayer, will it be controllable by the player?
(0010813)
Watermelon   
2014-11-03 15:13   
It's all controllable by the player. As long as the flag is set to True, it will screenshot once every intermission.
(0010817)
Torr Samaho   
2014-11-03 19:51   
I prefer wi_autoscreenshot.
(0010851)
Watermelon   
2014-11-10 03:27   
Updated pull request with the proper name
(0010853)
Watermelon   
2014-11-10 22:37   
Updated again
(0010887)
cobalt   
2014-11-15 14:51   
Issue addressed by commit cb89c20c17d8: Added a CVAR to allow screenshots to automatically be taken upon entering the intermission screen (fixes 1977).
Committed by WChrisK [Watermelon] on Friday 14 November 2014 14:56:45

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/wi_stuff.cpp | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 0 deletions(-)
(0010915)
Arco   
2014-11-21 12:04   
(edited on: 2014-11-21 12:06)
The screenshot does not show the proper image.

(0010918)
Karakurt   
2014-11-21 15:02   
Ok so here is how it works:

1) As stated above, the autoscreenshot takes a screenshot when the fraglimit / timelimit is hit -- even though the screenshot message appears in the intermission and not at the same time, which is how it should work -- :

'http://www.hostingpics.net/viewer.php?id=470274ScreenshotDoom20141121155439.png [^]'

2) The screenshot will only be registered if you are still in game when the intermission shows up, meaning that if you leave the server, or if you alt-tab before the intermission, no autoscreenshot.
(0010919)
Watermelon   
2014-11-21 15:14   
Can you give me the settings you guys used so I can try this out?
(0010920)
Karakurt   
2014-11-21 15:55   
Make a server, load up shoot.wad
Add 2 bots and set the fraglimit at 1
Set wi_autoscreenshot at 1, screenshot_quiet at true (so you could see the screenshot message)
Watch
(0010921)
Watermelon   
2014-11-21 17:17   
Do you use OpenGL? I only tested this in Software, but Dusk brought up that OpenGL rendering may take a different path.
(0010922)
Dusk   
2014-11-21 17:41   
Quote
[19:36:08] < Dusk> what happens if you do vid_hw2d false
[19:36:10] < Dusk> and try it
[19:36:24] < Dusk> you might need to restart(?)
[19:36:24] -!- Water` [~quassel@Watermelon.users.zandronum.com] has quit [Connection closed]
[19:37:32] < Arco> Works.
[19:37:42] < Arco> Withoue restarting.
[19:37:49] < Arco> without*
[19:39:17] < Dusk> so that's the culprit
[19:39:30] < Dusk> goddamn microsoft hindering us with its lousy directx :P


bam
(0010950)
Watermelon   
2014-11-24 12:56   
Ok what do we want to do here? I have no idea why DirectX is causing the code to not be properly screenshotted at the right time. Should we just put a warning for anyone who is using vid_hw2d and not perform the screenshot?
(0010956)
Dusk   
2014-11-24 19:18   
Pretty much everyone who uses Windows has vid_hw2d set to true so this would be a rather bad idea.
(0010959)
Torr Samaho   
2014-11-24 19:23   
Yeah, this needs to be fixed. The screenshot CCMD does work with vid_hw2d true, doesn't it?
(0010964)
Dusk   
2014-11-24 22:44   
(edited on: 2014-11-24 22:49)
Right, it does.

Quote

[23:44:45] < Dusk> have you tried letting it render twice before taking the screenshot?
[23:45:08] < Dusk> instead of having a bool as a lock, make it an integer
[23:45:17] < Dusk> if (++counter == 2) M_ScreenShot();


(0011166)
Torr Samaho   
2015-01-01 17:44   
Since Water is away for a bit, I went ahead and tried to take care of this. At least on my system, this works now under with "vid_hw2d 1" and the software renderer under Windows. Can those who had problems with this, check if it works now?
(0011168)
cobalt   
2015-01-01 17:54   
Issue addressed by commit c645d96a186b: wi_autoscreenshot should now also work with the software renderer if hardware acceleration is used. This addresses 1977.
Committed by Benjamin Berkels [Torr Samaho] on Thursday 01 January 2015 18:40:34

Changes in files:
 src/wi_stuff.cpp | 5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
(0011422)
WaTaKiD   
2015-01-18 03:46   
this seems to work just fine in opengl, windowed or fullscreen, alt tabbed or not
however in software while in fullscreen and alt tabbed, "could not create screenshot" is shown and no screenshot is created
(0011432)
Torr Samaho   
2015-01-18 11:00   
You want it to make a screenshot when Zandronum is running in full screen, but you are alt-tabbed out of Zandronum? In particular, nothing of what you want to be in the screenshot is visible? I don't think that this is supposed to work with the software renderer (and I'm surprised that this actually works with the OpenGL renderer). I'd expect ZDoom not to render anything in this case and thus there is nothing to make a screenshot of.
(0011435)
WaTaKiD   
2015-01-18 11:11   
well i wasnt sure so i figured what was the harm in mentioning it? if its simply a "dont do that" type of thing, then i guess thats that
(0011436)
Torr Samaho   
2015-01-18 11:14   
No, it surely didn't harm to mention it. It's good if we talk about the limitations so that everybody is aware of them.
(0011445)
fuleco   
2015-01-19 15:04   
in ogl and fullscreen the wi_autoscreenshot works like this'http://i.imgur.com/NkkaYG2.png. [^]' Capture too early.
(0011446)
Torr Samaho   
2015-01-19 19:48   
Strange, so far it seemed to work for everyone with OpenGL. Are you using the latest beta, i.e. 150118-1152? If so, which GPU are you using?
(0011457)
fuleco   
2015-01-20 14:51   
Yes i am using latest build and ati 7790 OC 2 GB RAM. Also can you try fix this pleas'http://zandronum.com/tracker/view.php?id=424. [^]' I am still waiting for fix this problem, the problem isnt in version zdoom 2.6.0 and higher.
(0011468)
Torr Samaho   
2015-01-21 07:06   
Does the feature work for anybody with an ATI GPU? I only tested it with NVIDIA GPUs so far.

(0011474)
Leonard   
2015-01-21 15:33   
It works fine for me. (ATI Radeon HD 5570)
(0011856)
StrikerMan780   
2015-03-16 20:05   
This feature seems to be working fine.