MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001950Zandronum[All Projects] Suggestionpublic2014-10-09 00:302018-10-01 00:12
ReporterWatermelon 
Assigned ToWatermelon 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.4 
Target Version1.4Fixed in Version1.4 
Summary0001950: Network options menu
DescriptionWith the new netcode being added, there isn't a place to store them that makes sense. Right now we have a mixing of our netcode fields in different places: Unlagged is in the Player Setup (why?) and Connection Type which determines some small things netcode related is in Multiplayer.


Since I plan on adding 4-5 things that users will need to toggle (in addition to unlagged/connection type/what-have-you), it might be nice to have them under a Network Options somewhere. I was thinking of putting it in the Multiplayer menu.


Since some of these network options will be closely related, it would make sense to keep them together as well.


I'm unsure if the fields should be left where they are for unlagged/connection type, while duplicating them in the Network Options menu, and then phasing them out in the next version (allowing people to adjust to the new location). Thoughts?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-10-09 00:30WatermelonNew Issue
2014-10-09 00:30WatermelonStatusnew => assigned
2014-10-09 00:30WatermelonAssigned To => Watermelon
2014-10-09 10:20FritsNote Added: 0010417
2014-10-09 15:32WatermelonNote Added: 0010425
2014-10-09 17:55FritsNote Added: 0010431
2014-10-09 17:56FritsNote Edited: 0010431bug_revision_view_page.php?bugnote_id=10431#r5638
2014-10-10 09:57Konar6Note Added: 0010448
2014-10-10 14:11WatermelonNote Added: 0010451
2014-10-10 14:13WatermelonNote Added: 0010452
2014-10-10 14:13WatermelonStatusassigned => needs review
2014-10-10 14:14WatermelonNote Edited: 0010452bug_revision_view_page.php?bugnote_id=10452#r5662
2014-10-11 08:58Torr SamahoNote Added: 0010471
2014-10-11 09:21Torr SamahoStatusneeds review => feedback
2014-10-11 11:26DuskNote Added: 0010474
2014-10-11 15:50WatermelonNote Added: 0010492
2014-10-11 15:50WatermelonStatusfeedback => assigned
2014-10-11 16:00WatermelonStatusassigned => needs review
2014-10-11 16:00WatermelonNote Edited: 0010492bug_revision_view_page.php?bugnote_id=10492#r5693
2014-10-11 16:53Torr SamahoNote Added: 0010501
2014-10-11 16:54Torr SamahoStatusneeds review => feedback
2014-10-11 17:19WatermelonNote Added: 0010504
2014-10-11 17:19WatermelonStatusfeedback => assigned
2014-10-12 00:32WatermelonNote Added: 0010514
2014-10-12 00:32WatermelonStatusassigned => needs review
2014-10-12 00:33WatermelonNote Edited: 0010514bug_revision_view_page.php?bugnote_id=10514#r5706
2014-10-12 02:36StrikerMan780Note Added: 0010522
2014-10-12 13:05cobaltStatusneeds review => needs testing
2014-10-12 13:05cobaltDescription Updatedbug_revision_view_page.php?rev_id=5727#r5727
2014-10-12 13:05cobaltNote Added: 0010528
2014-10-12 13:19Torr SamahoNote Added: 0010530
2014-10-12 16:40WatermelonNote Added: 0010546
2014-10-13 13:14Edward-sanNote Added: 0010567
2014-10-13 23:31ArcoNote Added: 0010576
2014-10-13 23:31ArcoStatusneeds testing => resolved
2014-10-13 23:31ArcoResolutionopen => fixed
2014-10-13 23:31ArcoFixed in Version => 1.4
2014-10-13 23:31ArcoDescription Updatedbug_revision_view_page.php?rev_id=5755#r5755
2018-10-01 00:12Blzut3Statusresolved => closed

Notes
(0010417)
Frits   
2014-10-09 10:20   
Good idea, don't forget cl_ticsperupdate too. Many new players don't even know they can customize these options right now.
(0010425)
Watermelon   
2014-10-09 15:32   
I wanted to make a ticket on converting that to being a default of 1 or 2.
3 is really choppy.
(0010431)
Frits   
2014-10-09 17:55   
(edited on: 2014-10-09 17:56)
That's true but I never noticed it was choppy until I went back from 1 to 3. Now i can never go back ;)

It would benefit new players that aren't familiar with these settings so it's definitely worth considering.
(0010448)
Konar6   
2014-10-10 09:57   
Same stance as 0001824:0010447. cl_ticsperupdate could have been safely set to 2 or 1 by default. The ancient way of sending an update to clients only every 3 tics originates from early 2000s when people were still riding their 56k modems and ISDN. Today, for most players, bandwidth is not an issue, but we still keep this relic default for new players to degrade their experience. Or just anyone who doesn't read long changelogs or look for config tweaks.
(0010451)
Watermelon   
2014-10-10 14:11   
I ninja'd it down from 3 to 2.
I honestly think it should be at 1 though. As Konar said, I doubt anyone in this day and age could not handle a value of 1.

It looks really really bad if you switch from 1 to 3 after playing with cl_ticsperupdate at 1 for 10-15 minutes.
(0010452)
Watermelon   
2014-10-10 14:13   
(edited on: 2014-10-10 14:14)
Created the menu and put some of our fields in it

Base commit:
'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/eac1b4f4fd1a2dddf2ebb96a78a7d9bbada43bdc [^]'

Show spawns addition (included because it may be needed):
'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/f1d53cc9cca768db3a963f6a73e006028e4ee4c2 [^]'

Further network options commit and changing of cl_ticsperupdate to 2 (can we do 1?)
'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/463f4a7f29b4fcdeb8eb607834fbf2a3a3adfdfc [^]'
(0010471)
Torr Samaho   
2014-10-11 08:58   
I like the idea of a network settings menu. Can you create a changeset that introduces the menu, but doesn't rely on any stuff that is not in 1.3, like cl_unlaggedtype? This way I could add it immediately before we need to progress further on the other new features.

Regarding cl_ticsperupdate, I heard reports about problems with "cl_ticsperupdate 1", so we could set the default to 2, but not 1. At least not for now.
(0010474)
Dusk   
2014-10-11 11:26   
I'd like to point out that current ZDoom also has a network options menu, though what's in said network options aren't really relevant to us.
(0010492)
Watermelon   
2014-10-11 15:50   
(edited on: 2014-10-11 16:00)
Before I commit, is it fine where it is (Options menu above display options)?

If that's fine, I'll make the history changes and push the commit.
(0010501)
Torr Samaho   
2014-10-11 16:53   
Quote from Dusk
I'd like to point out that current ZDoom also has a network options menu
Where is it hidden? I tried the latest GZDoom git build and didn't see it.
Quote from Watermelon

Before I commit, is it fine where it is (Options menu above display options)?

If ZDoom already has a reasonable place, we could use the same. Otherwise above display options sounds ok.
(0010504)
Watermelon   
2014-10-11 17:19   
I think its for ZDoom 2.8 or w/e branch Edward850 is working
(0010514)
Watermelon   
2014-10-12 00:32   
(edited on: 2014-10-12 00:33)
Pull request made

NOTE: I'm sorry the .hgignore got bundled with it. Can that go in too? It's annoying having to add them every time I clone a repository.
(0010522)
StrikerMan780   
2014-10-12 02:36   
I'd put network options under multiplayer, and move the existing settings strewn about for things like unlagged into it. But, that's just me.
(0010528)
cobalt   
2014-10-12 13:05   
Issue addressed by commit f0a57e3cf052: Added network menu where all the new network options and cvars will go (fixes 1950).
Committed by WChrisK on Saturday 11 October 2014 20:26:32

2 files modified, 39 lines added, no lines removed
Files changed: docs/zandronum-history.txt, src/m_options.cpp
(0010530)
Torr Samaho   
2014-10-12 13:19   
I had to fix your patch, it didn't link for me because you had
EXTERN_CVAR( Bool, cl_ticsperupdate )

instead of
EXTERN_CVAR( Int, cl_ticsperupdate )

Did this link for you under Linux?

Regarding .hgignore: I don't think we should add all possible directory names people could use for their build folders in there. If you use one of the existing ones (debug, release, Debug, Release, releaseobj, debugobj, server-releaseobj, server-debugobj), you don't have to alter .hgignore. Adding FMOD is a good idea though and I updated .hgignore to (hopefully) cover all FMOD versions.
(0010546)
Watermelon   
2014-10-12 16:40   
Yes it linked for me under linux. I always compile/test them before submitting ;)

I don't recall seeing it complain either with a warning... usually I look for those as well to make sure it's error free. This is interesting, I wonder if there's a setting I should have on?
(0010567)
Edward-san   
2014-10-13 13:14   
Quote from Torr Samaho
Where is it hidden? I tried the latest GZDoom git build and didn't see it.


It's between 'Miscellaneous options' and 'sound options'.
(0010576)
Arco   
2014-10-13 23:31   
Works as intended in v1.4 r141013-1525,