MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001932Zandronum[All Projects] Suggestionpublic2014-09-11 23:202018-09-30 21:35
ReporterMazterQyoun-ae 
Assigned ToEdward-san 
PrioritynoneSeveritytextReproducibilityalways
StatusclosedResolutionfixed 
PlatformAllOS-OS Version-
Product Version1.2 
Target VersionFixed in Version1.3 
Summary0001932: Automute on spam timing displayed to player is wrong
DescriptionWhen one sends several messages quite, he gets a warning:
«Please refrain from chatting so much. You've been muted for 15 seconds.»
When one tries to talk, he gets:
«The server has muted you. Nobody can hear you chat for the next 1 minute.»
With the time actually being 15 seconds. Yeah, it's understandable that the counter might work and display in minutes but… there should be a better way, no?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001933closed  Consider removing the 1 minute mute 
Attached Filestxt muting.diff.txt (4,898) 2014-09-13 20:09
/tracker/file_download.php?file_id=1288&type=bug
txt muting_fix.diff.txt (1,174) 2014-09-30 11:05
/tracker/file_download.php?file_id=1299&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-09-11 23:20MazterQyoun-aeNew Issue
2014-09-13 18:51DuskRelationship addedrelated to 0001933
2014-09-13 20:09Edward-sanFile Added: muting.diff.txt
2014-09-13 20:11Edward-sanNote Added: 0010262
2014-09-13 20:11Edward-sanNote Edited: 0010262bug_revision_view_page.php?bugnote_id=10262#r5560
2014-09-13 20:12Edward-sanAssigned To => Edward-san
2014-09-13 20:12Edward-sanStatusnew => needs review
2014-09-13 20:14Edward-sanNote Edited: 0010262bug_revision_view_page.php?bugnote_id=10262#r5561
2014-09-13 20:15Edward-sanNote Edited: 0010262bug_revision_view_page.php?bugnote_id=10262#r5562
2014-09-16 09:30Edward-sanNote Added: 0010270
2014-09-16 09:30Edward-sanStatusneeds review => needs testing
2014-09-29 01:37ArcoNote Added: 0010302
2014-09-29 01:37ArcoStatusneeds testing => resolved
2014-09-29 01:37ArcoResolutionopen => fixed
2014-09-29 01:37ArcoProduct Version => 1.2
2014-09-29 01:37ArcoFixed in Version => 1.3
2014-09-29 18:17Edward-sanNote Added: 0010307
2014-09-29 22:14Edward-sanStatusresolved => feedback
2014-09-29 22:14Edward-sanResolutionfixed => reopened
2014-09-30 11:04Edward-sanNote Edited: 0010307bug_revision_view_page.php?bugnote_id=10307#r5576
2014-09-30 11:05Edward-sanFile Added: muting_fix.diff.txt
2014-09-30 11:06Edward-sanNote Edited: 0010307bug_revision_view_page.php?bugnote_id=10307#r5577
2014-09-30 11:34Edward-sanNote Edited: 0010307bug_revision_view_page.php?bugnote_id=10307#r5578
2014-09-30 23:34Edward-sanStatusfeedback => needs review
2014-10-03 16:57Torr SamahoNote Added: 0010317
2014-10-03 16:58Torr SamahoStatusneeds review => needs testing
2014-10-05 19:58ArcoNote Added: 0010336
2014-10-05 19:58ArcoStatusneeds testing => resolved
2014-10-05 19:58ArcoResolutionreopened => fixed
2018-09-30 21:35Blzut3Statusresolved => closed

Notes
(0010262)
Edward-san   
2014-09-13 20:11   
(edited on: 2014-09-13 20:15)
I made a patch which:
- changes the phrase "Nobody can hear you chat" to "Nobody can see your messages" for English grammar purposes;
- prints the minutes and the seconds if the tics are enough, else it will print 'less than a second';
- While we're at it, as a first step for this suggestion, moves the chat flooding code in a separated static function.
(0010270)
Edward-san   
2014-09-16 09:30   
Patch committed:'https://bitbucket.org/Torr_Samaho/zandronum-stable/commits/c95a7f3980e92513e81509da375d73e77c7f65de [^]'
(0010302)
Arco   
2014-09-29 01:37   
There is a typo when the player receives a message while muted. Otherwise, it works as intended in v1.3 r140920-1619.
(0010307)
Edward-san   
2014-09-29 18:17   
(edited on: 2014-09-30 11:34)
Do you mean, by any chance, 'messagesfor'?

[edit]It seems like that. Attached a patch, I did not add an entry to zandronum-history.txt since it's a tiny change: "Fixed typo in commit <insert commit id here>."
(0010317)
Torr Samaho   
2014-10-03 16:57   
I added the patch.
(0010336)
Arco   
2014-10-05 19:58   
Issue fixed.