MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001907Zandronum[All Projects] Bugpublic2014-08-04 19:442018-09-30 21:35
ReporterKonar6 
Assigned ToBlzut3 
PriorityhighSeverityminorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3 
Target Version1.3Fixed in Version1.3 
Summary0001907: Problems with the new huffman
DescriptionBeginning with the revision where the new huffman was introduced ('https://bitbucket.org/Torr_Samaho/zandronum/commits/109ab2dbc5fef9888b3733d6196b8379a2b0e6d2 [^]' ), the server->launcher messages sometimes seem to arrive corrupted - the launcher shows an absurd ping value, and in addition, the whole server info is corrupted in IDE as can be seen here ->'http://prntscr.com/48z8hu [^]'
Steps To ReproduceRefresh a 1.3 or 2.0 server in IDE or Doomseeker. The bug happens at random every 0000010:0000030-50 attempts.
Additional InformationSince there are 600+ servers on Zandronum, I anticipate this problem to become more apparent if not fixed until 1.3 is released.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-04 19:44Konar6New Issue
2014-08-04 20:19Torr SamahoAssigned To => Blzut3
2014-08-04 20:19Torr SamahoStatusnew => assigned
2014-08-11 06:51Blzut3Note Added: 0010175
2014-08-11 17:50Konar6Note Added: 0010178
2014-08-12 17:31Torr SamahoNote Added: 0010187
2014-08-12 18:40Torr SamahoNote Added: 0010188
2014-08-12 21:29Blzut3Note Added: 0010191
2014-08-14 10:53Blzut3Note Added: 0010202
2014-08-14 10:53Blzut3Statusassigned => needs review
2014-08-14 10:54Blzut3Product Version2.0-beta => 1.3
2014-08-14 10:54Blzut3Target Version => 1.3
2014-08-14 17:27Torr SamahoNote Added: 0010204
2014-08-14 18:29Torr SamahoStatusneeds review => needs testing
2014-10-05 22:20DuskFixed in Version => 1.3
2014-10-05 22:22DuskNote Added: 0010346
2014-10-05 22:22DuskStatusneeds testing => resolved
2014-10-05 22:22DuskResolutionopen => fixed
2018-09-30 21:35Blzut3Statusresolved => closed

Notes
(0010175)
Blzut3   
2014-08-11 06:51   
Not having much luck reproducing this with a local server.
(0010178)
Konar6   
2014-08-11 17:50   
I would suggest using IDE if you don't do already - it doesn't throttle refreshing. You can also turn on the Auto refresh feature in ServerInfo and wait. You will get to know that the bug occurred from the "average ping" value.

Several players have already spotted this bug just by refreshing the server list.
(0010187)
Torr Samaho   
2014-08-12 17:31   
Quote from Konar6
the server->launcher messages sometimes seem to arrive corrupted
Since the server<->client communication appears to work flawlessly, I think it's more likely that Vortex Cortex' Huffman implementation is not 100% compatible with the old code.
(0010188)
Torr Samaho   
2014-08-12 18:40   
Looks as my suspicion is correct. I used the old implementation of HUFFMAN_Decode to decode messages encoded by Vortex Cortex's HUFFMAN_Encode while playing on a 2.0 server. I didn't do any statistics, but at first glance it seems that the new HUFFMAN_Encode is not compatible with the old HUFFMAN_Decode in more than 1% of the cases. In less than a minute of playtime there were dozens of mismatches when decoding the packets for the client<->server communication.

Either I'm doing something wrong in my tests or Vortex Cortex didn't really test the compatibility or something went wrong when Blzut3 replaced the old with the new Huffman implementation.
(0010191)
Blzut3   
2014-08-12 21:29   
OK, that explains that. Of course if IDE is using the old code then bond is obligated by the GPL to release the source code to IDE. :P

I will investigate a bit since I don't recall Doomseeker having problems communicating with servers before the switch.
(0010202)
Blzut3   
2014-08-14 10:53   
Pull request sent against Zandronum-stable.
(0010204)
Torr Samaho   
2014-08-14 17:27   
Thanks! Pulled and also merged with 2.0.
(0010346)
Dusk   
2014-10-05 22:22   
Marking as resolved as 1.3 is now released.